Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Marcin Bernatowicz <marcin.bernatowicz@linux.intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [PATCH v2 i-g-t] benchmarks/gem_wsim: Fix array index issue in xe_sync object referencing
Date: Fri,  8 Dec 2023 11:24:38 +0100	[thread overview]
Message-ID: <20231208102438.12894-1-marcin.bernatowicz@linux.intel.com> (raw)

During the split of xe_sync types from flags introduced in commit
ce4e53b0faec ("drm-uapi/xe: Split xe_sync types from flags"), the array
index of xe_sync objects was unnecessarily incremented in one of the lines.
This caused the next line to reference the wrong xe_sync object.

This patch fixes the array index issue, ensuring the correct xe_sync
object is referenced.

Fixes: ce4e53b0faec ("drm-uapi/xe: Split xe_sync types from flags")
Signed-off-by: Marcin Bernatowicz <marcin.bernatowicz@linux.intel.com>
---
 benchmarks/gem_wsim.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/benchmarks/gem_wsim.c b/benchmarks/gem_wsim.c
index e937e1027..30673da8f 100644
--- a/benchmarks/gem_wsim.c
+++ b/benchmarks/gem_wsim.c
@@ -1784,7 +1784,7 @@ xe_alloc_step_batch(struct workload *wrk, struct w_step *w)
 	i = 0;
 	/* out fence */
 	w->xe.syncs[i].handle = syncobj_create(fd, 0);
-	w->xe.syncs[i++].type = DRM_XE_SYNC_TYPE_SYNCOBJ;
+	w->xe.syncs[i].type = DRM_XE_SYNC_TYPE_SYNCOBJ;
 	w->xe.syncs[i++].flags = DRM_XE_SYNC_FLAG_SIGNAL;
 	/* in fence(s) */
 	for_each_dep(dep, w->data_deps) {
-- 
2.31.1

             reply	other threads:[~2023-12-08 10:24 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-08 10:24 Marcin Bernatowicz [this message]
2023-12-08 11:42 ` ✗ Fi.CI.BAT: failure for benchmarks/gem_wsim: Fix array index issue in xe_sync object referencing (rev2) Patchwork
2023-12-11 12:32   ` Kamil Konieczny
2023-12-13 13:34     ` Illipilli, TejasreeX
2023-12-08 12:32 ` ✓ CI.xeBAT: success " Patchwork
2023-12-11  9:43 ` [PATCH v2 i-g-t] benchmarks/gem_wsim: Fix array index issue in xe_sync object referencing Laguna, Lukasz
2023-12-13 13:31 ` ✓ Fi.CI.BAT: success for benchmarks/gem_wsim: Fix array index issue in xe_sync object referencing (rev2) Patchwork
2023-12-13 14:27 ` ✗ Fi.CI.IGT: failure " Patchwork
2023-12-14  7:31 ` Patchwork
2023-12-14 18:00   ` Kamil Konieczny

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231208102438.12894-1-marcin.bernatowicz@linux.intel.com \
    --to=marcin.bernatowicz@linux.intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox