Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Matthew Auld <matthew.auld@intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [PATCH i-g-t 2/2] lib: restore FLAG_SCANOUT usage for Xe
Date: Mon, 11 Dec 2023 10:58:44 +0000	[thread overview]
Message-ID: <20231211105844.30534-2-matthew.auld@intel.com> (raw)
In-Reply-To: <20231211105844.30534-1-matthew.auld@intel.com>

Looks to have been accidentally removed in all the various uapi
refactoring and cleanup. Selecting SCANOUT here is needed to ensure that
WC is also selected for the cpu_caching.

Signed-off-by: Matthew Auld <matthew.auld@intel.com>
Cc: Francois Dugast <francois.dugast@intel.com>
---
 lib/igt_draw.c | 3 ++-
 lib/igt_fb.c   | 3 ++-
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/lib/igt_draw.c b/lib/igt_draw.c
index 6d0bcb997..637b9ba76 100644
--- a/lib/igt_draw.c
+++ b/lib/igt_draw.c
@@ -802,7 +802,8 @@ static void draw_rect_render(int fd, struct cmd_data *cmd_data,
 		tmp.handle = xe_bo_create(fd, 0,
 					  ALIGN(tmp.size, xe_get_default_alignment(fd)),
 					  vram_if_possible(fd, 0),
-					  DRM_XE_GEM_CREATE_FLAG_NEEDS_VISIBLE_VRAM);
+					  DRM_XE_GEM_CREATE_FLAG_NEEDS_VISIBLE_VRAM |
+					  DRM_XE_GEM_CREATE_FLAG_SCANOUT);
 
 	tmp.stride = rect->w * pixel_size;
 	tmp.bpp = buf->bpp;
diff --git a/lib/igt_fb.c b/lib/igt_fb.c
index 907464273..0446cefc9 100644
--- a/lib/igt_fb.c
+++ b/lib/igt_fb.c
@@ -1208,7 +1208,8 @@ static int create_bo_for_fb(struct igt_fb *fb, bool prefer_sysmem)
 		} else if (is_xe_device(fd)) {
 			fb->gem_handle = xe_bo_create(fd, 0, fb->size,
 						      vram_if_possible(fd, 0),
-						      DRM_XE_GEM_CREATE_FLAG_NEEDS_VISIBLE_VRAM);
+						      DRM_XE_GEM_CREATE_FLAG_NEEDS_VISIBLE_VRAM |
+						      DRM_XE_GEM_CREATE_FLAG_SCANOUT);
 		} else if (is_vc4_device(fd)) {
 			fb->gem_handle = igt_vc4_create_bo(fd, fb->size);
 
-- 
2.43.0

  reply	other threads:[~2023-12-11 10:58 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-11 10:58 [PATCH i-g-t 1/2] lib/xe_ioctl: fix default cpu_caching helper Matthew Auld
2023-12-11 10:58 ` Matthew Auld [this message]
2023-12-11 11:04   ` [PATCH i-g-t 2/2] lib: restore FLAG_SCANOUT usage for Xe Francois Dugast
2023-12-11 11:41 ` [PATCH i-g-t 1/2] lib/xe_ioctl: fix default cpu_caching helper Francois Dugast
2023-12-11 15:53 ` ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/2] " Patchwork
2023-12-11 16:20 ` ✓ CI.xeBAT: " Patchwork
2023-12-11 17:14 ` ✗ Fi.CI.IGT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231211105844.30534-2-matthew.auld@intel.com \
    --to=matthew.auld@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox