Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
To: igt-dev@lists.freedesktop.org, mitulkumar.ajitkumar.golani@intel.com
Subject: [i-g-t V7 3/8] tests/kms_vrr: Move all config constaints to new function
Date: Mon, 11 Dec 2023 17:06:45 +0530	[thread overview]
Message-ID: <20231211113650.3520399-4-bhanuprakash.modem@intel.com> (raw)
In-Reply-To: <20231211113650.3520399-1-bhanuprakash.modem@intel.com>

No functional change, cleanup only. Move all config checks
to new function.

Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
Reviewed-by: Mitul Golani <mitulkumar.ajitkumar.golani@intel.com>
---
 tests/kms_vrr.c | 24 ++++++++++++++++--------
 1 file changed, 16 insertions(+), 8 deletions(-)

diff --git a/tests/kms_vrr.c b/tests/kms_vrr.c
index 13e7f3ca6..df241aa6c 100644
--- a/tests/kms_vrr.c
+++ b/tests/kms_vrr.c
@@ -483,6 +483,21 @@ static void test_cleanup(data_t *data, enum pipe pipe, igt_output_t *output)
 	igt_remove_fb(data->drm_fd, &data->fb0);
 }
 
+static bool config_constraint(igt_output_t *output, uint32_t flags)
+{
+	if (!has_vrr(output))
+		return false;
+
+	/* For Negative tests, panel should be non-vrr. */
+	if ((flags & TEST_NEGATIVE) && vrr_capable(output))
+		return false;
+
+	if ((flags & ~TEST_NEGATIVE) && !vrr_capable(output))
+		return false;
+
+	return true;
+}
+
 /* Runs tests on outputs that are VRR capable. */
 static void
 run_vrr_test(data_t *data, test_t test, uint32_t flags)
@@ -492,14 +507,7 @@ run_vrr_test(data_t *data, test_t test, uint32_t flags)
 	for_each_connected_output(&data->display, output) {
 		enum pipe pipe;
 
-		if (!has_vrr(output))
-			continue;
-
-		/* For Negative tests, panel should be non-vrr. */
-		if ((flags & TEST_NEGATIVE) && vrr_capable(output))
-			continue;
-
-		if ((flags & ~TEST_NEGATIVE) && !vrr_capable(output))
+		if (!config_constraint(output, flags))
 			continue;
 
 		for_each_pipe(&data->display, pipe) {
-- 
2.40.0

  parent reply	other threads:[~2023-12-11 11:48 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-11 11:36 [i-g-t V7 0/8] tests/kms_vrr: Add new subtest to switch RR without modeset Bhanuprakash Modem
2023-12-11 11:36 ` [i-g-t V7 1/8] tests/kms_vrr: Use lib helper to print connector modes Bhanuprakash Modem
2023-12-11 11:36 ` [i-g-t V7 2/8] tests/kms_vrr: Clear VRR before exit Bhanuprakash Modem
2023-12-11 11:36 ` Bhanuprakash Modem [this message]
2023-12-11 11:36 ` [i-g-t V7 4/8] tests/kms_vrr: Fix pipe/output combo validity constraint Bhanuprakash Modem
2023-12-13  3:16   ` Golani, Mitulkumar Ajitkumar
2023-12-11 11:36 ` [i-g-t V7 5/8] tests/kms_vrr: Add new subtest to switch RR without modeset Bhanuprakash Modem
2023-12-13  3:03   ` Golani, Mitulkumar Ajitkumar
2023-12-11 11:36 ` [i-g-t V7 6/8] tests/kms_vrr: Add new subtest for DRRS " Bhanuprakash Modem
2023-12-12  6:45   ` Golani, Mitulkumar Ajitkumar
2023-12-11 11:36 ` [i-g-t V7 7/8] tests/kms_vrr: New subtest for toggle VRR during fastsets Bhanuprakash Modem
2023-12-11 11:36 ` [i-g-t V7 8/8] HAX: DO_NOT_MERGE: test only vrr tests Bhanuprakash Modem
2023-12-11 19:37 ` ✗ Fi.CI.BAT: failure for tests/kms_vrr: Add new subtest to switch RR without modeset (rev8) Patchwork
2023-12-11 20:15 ` ✓ CI.xeBAT: success " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231211113650.3520399-4-bhanuprakash.modem@intel.com \
    --to=bhanuprakash.modem@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=mitulkumar.ajitkumar.golani@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox