Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: Mitul Golani <mitulkumar.ajitkumar.golani@intel.com>
Subject: [i-g-t V8 2/7] tests/kms_vrr: Clear VRR before exit
Date: Wed, 13 Dec 2023 10:07:36 +0530	[thread overview]
Message-ID: <20231213043741.3640374-3-bhanuprakash.modem@intel.com> (raw)
In-Reply-To: <20231213043741.3640374-1-bhanuprakash.modem@intel.com>

Before exiting the subtest, make sure to clear the VRR.

V2: - New function for cleanup

Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
Reviewed-by: Mitul Golani <mitulkumar.ajitkumar.golani@intel.com>
---
 tests/kms_vrr.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/tests/kms_vrr.c b/tests/kms_vrr.c
index bbdb54682..13e7f3ca6 100644
--- a/tests/kms_vrr.c
+++ b/tests/kms_vrr.c
@@ -469,8 +469,11 @@ test_basic(data_t *data, enum pipe pipe, igt_output_t *output, uint32_t flags)
 	igt_assert_f(result < 10,
 		     "Refresh rate (%u Hz) %"PRIu64"ns: Target VRR %s threshold exceeded, result was %u%%\n",
 		     ((range.max + range.min) / 2), rate, (flags & TEST_NEGATIVE)? "on" : "off", result);
+}
 
-	/* Clean-up */
+static void test_cleanup(data_t *data, enum pipe pipe, igt_output_t *output)
+{
+	igt_pipe_set_prop_value(&data->display, pipe, IGT_CRTC_VRR_ENABLED, false);
 	igt_plane_set_fb(data->primary, NULL);
 	igt_output_set_pipe(output, PIPE_NONE);
 	igt_output_override_mode(output, NULL);
@@ -510,6 +513,9 @@ run_vrr_test(data_t *data, test_t test, uint32_t flags)
 				igt_dynamic_f("pipe-%s-%s",
 					      kmstest_pipe_name(pipe), output->name)
 					test(data, pipe, output, flags);
+
+				test_cleanup(data, pipe, output);
+
 				break;
 			}
 		}
-- 
2.40.0

  parent reply	other threads:[~2023-12-13  4:48 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-13  4:37 [i-g-t V8 0/7] tests/kms_vrr: Add new subtest to switch RR without modeset Bhanuprakash Modem
2023-12-13  4:37 ` [i-g-t V8 1/7] tests/kms_vrr: Use lib helper to print connector modes Bhanuprakash Modem
2023-12-13  4:37 ` Bhanuprakash Modem [this message]
2023-12-13  4:37 ` [i-g-t V8 3/7] tests/kms_vrr: Move all config constaints to new function Bhanuprakash Modem
2023-12-13  4:37 ` [i-g-t V8 4/7] tests/kms_vrr: Fix pipe/output combo validity constraint Bhanuprakash Modem
2023-12-13  4:37 ` [i-g-t V8 5/7] tests/kms_vrr: Add new subtest to switch RR without modeset Bhanuprakash Modem
2023-12-13  4:37 ` [i-g-t V8 6/7] tests/kms_vrr: Add new subtest for DRRS " Bhanuprakash Modem
2023-12-13  4:37 ` [i-g-t V8 7/7] tests/kms_vrr: New subtest for toggle VRR during fastsets Bhanuprakash Modem
2023-12-13  6:22 ` ✓ Fi.CI.BAT: success for tests/kms_vrr: Add new subtest to switch RR without modeset (rev9) Patchwork
2023-12-13  7:19 ` ✗ Fi.CI.IGT: failure " Patchwork
2023-12-13  7:24 ` ✓ CI.xeBAT: success " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231213043741.3640374-3-bhanuprakash.modem@intel.com \
    --to=bhanuprakash.modem@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=mitulkumar.ajitkumar.golani@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox