Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [i-g-t 1/2] tests/kms_vrr: Tweak flipline subtest
Date: Wed, 13 Dec 2023 13:46:51 +0530	[thread overview]
Message-ID: <20231213081652.3662325-1-bhanuprakash.modem@intel.com> (raw)

As per the spec: If there is no flip request with in Vmax,
Hardware will terminate the Vblank at Vmax.

If we flip with the interval > Vmax, the expected refresh rate
could be: (Vmax + time left for the next flip + Vmin), and it
is very difficult to generalize. For low refresh rate panels
(like 40 - 60 Hz), result is not falling into the threshold.

Hence, tweak the test to increase the flip request interval.

Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
 tests/kms_vrr.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/kms_vrr.c b/tests/kms_vrr.c
index 5c190cd8c..7cb7c3ef5 100644
--- a/tests/kms_vrr.c
+++ b/tests/kms_vrr.c
@@ -456,7 +456,7 @@ test_basic(data_t *data, enum pipe pipe, igt_output_t *output, uint32_t flags)
 	}
 
 	if (flags & TEST_FLIPLINE) {
-		rate = rate_from_refresh(range.min - 5);
+		rate = rate_from_refresh(range.min - 10);
 		result = flip_and_measure(data, output, pipe, rate, TEST_DURATION_NS);
 		igt_assert_f(result < 50,
 			     "Refresh rate (%u Hz) %"PRIu64"ns: Target VRR on threshold exceeded, result was %u%%\n",
-- 
2.40.0

             reply	other threads:[~2023-12-13  8:27 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-13  8:16 Bhanuprakash Modem [this message]
2023-12-13  8:16 ` [i-g-t 2/2] HAX: DO_NOT_MERGE: Add vrr flipline test to BAT Bhanuprakash Modem
2023-12-13  9:53 ` [i-g-t 1/2] tests/kms_vrr: Tweak flipline subtest Bhanuprakash Modem
2024-01-09  5:54   ` Srinivas, Vidya
2024-01-09 10:17   ` Modem, Bhanuprakash
2024-01-09 11:51     ` Golani, Mitulkumar Ajitkumar
2023-12-13 12:53 ` ✓ CI.xeBAT: success for series starting with [i-g-t,1/2] tests/kms_vrr: Tweak flipline subtest (rev2) Patchwork
2023-12-13 13:06 ` ✓ Fi.CI.BAT: " Patchwork
2023-12-13 14:02 ` ✗ Fi.CI.IGT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231213081652.3662325-1-bhanuprakash.modem@intel.com \
    --to=bhanuprakash.modem@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox