From: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: Sean Paul <seanpaul@chromium.org>
Subject: [i-g-t v3 1/9] tests/kms_vrr: Move fb0 and fb1 to an array
Date: Tue, 19 Dec 2023 07:36:05 +0530 [thread overview]
Message-ID: <20231219020613.113772-2-bhanuprakash.modem@intel.com> (raw)
In-Reply-To: <20231219020613.113772-1-bhanuprakash.modem@intel.com>
From: Sean Paul <seanpaul@chromium.org>
Consolidate the 2 fb variables into an array. No functional changes.
v2:
- Clarified commit msg (Bhanu)
v3: (Bhanu)
- Rebase
Cc: Mark Yacoub <markyacoub@chromium.org>
Reviewed-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
Signed-off-by: Sean Paul <seanpaul@chromium.org>
Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
tests/kms_vrr.c | 19 +++++++++----------
1 file changed, 9 insertions(+), 10 deletions(-)
diff --git a/tests/kms_vrr.c b/tests/kms_vrr.c
index 1ace970a5..dda716ff3 100644
--- a/tests/kms_vrr.c
+++ b/tests/kms_vrr.c
@@ -104,8 +104,7 @@ typedef struct data {
igt_display_t display;
int drm_fd;
igt_plane_t *primary;
- igt_fb_t fb0;
- igt_fb_t fb1;
+ igt_fb_t fb[2];
range_t range;
drmModeModeInfo switch_modes[RR_MODES_COUNT];
} data_t;
@@ -280,13 +279,13 @@ static void prepare_test(data_t *data, igt_output_t *output, enum pipe pipe)
/* Prepare resources */
igt_create_color_fb(data->drm_fd, mode.hdisplay, mode.vdisplay,
DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_LINEAR,
- 0.50, 0.50, 0.50, &data->fb0);
+ 0.50, 0.50, 0.50, &data->fb[0]);
igt_create_color_fb(data->drm_fd, mode.hdisplay, mode.vdisplay,
DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_LINEAR,
- 0.50, 0.50, 0.50, &data->fb1);
+ 0.50, 0.50, 0.50, &data->fb[1]);
- cr = igt_get_cairo_ctx(data->drm_fd, &data->fb0);
+ cr = igt_get_cairo_ctx(data->drm_fd, &data->fb[0]);
igt_paint_color(cr, 0, 0, mode.hdisplay / 10, mode.vdisplay / 10,
1.00, 0.00, 0.00);
@@ -295,7 +294,7 @@ static void prepare_test(data_t *data, igt_output_t *output, enum pipe pipe)
/* Take care of any required modesetting before the test begins. */
data->primary = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY);
- igt_plane_set_fb(data->primary, &data->fb0);
+ igt_plane_set_fb(data->primary, &data->fb[0]);
/* Clear vrr_enabled state before enabling it, because
* it might be left enabled if the previous test fails.
@@ -345,7 +344,7 @@ flip_and_measure(data_t *data, igt_output_t *output, enum pipe pipe,
vtest_ns_t vtest_ns = get_test_rate_ns(data->range);
/* Align with the flip completion event to speed up convergence. */
- do_flip(data, &data->fb0);
+ do_flip(data, &data->fb[0]);
start_ns = last_event_ns = target_ns = get_kernel_event_ns(data,
DRM_EVENT_FLIP_COMPLETE);
@@ -354,7 +353,7 @@ flip_and_measure(data_t *data, igt_output_t *output, enum pipe pipe,
int64_t diff_ns;
front = !front;
- do_flip(data, front ? &data->fb1 : &data->fb0);
+ do_flip(data, front ? &data->fb[1] : &data->fb[0]);
/* We need to cpture flip event instead of vblank event,
* because vblank is triggered after each frame, but depending
@@ -560,8 +559,8 @@ static void test_cleanup(data_t *data, enum pipe pipe, igt_output_t *output)
igt_output_override_mode(output, NULL);
igt_display_commit2(&data->display, COMMIT_ATOMIC);
- igt_remove_fb(data->drm_fd, &data->fb1);
- igt_remove_fb(data->drm_fd, &data->fb0);
+ igt_remove_fb(data->drm_fd, &data->fb[1]);
+ igt_remove_fb(data->drm_fd, &data->fb[0]);
}
static bool output_constraint(data_t *data, igt_output_t *output, uint32_t flags)
--
2.40.0
next prev parent reply other threads:[~2023-12-19 2:11 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-19 2:06 [i-g-t v3 0/9] tests/kms_vrr: Modify kms_vrr to allow flicker profiling Bhanuprakash Modem
2023-12-19 2:06 ` Bhanuprakash Modem [this message]
2023-12-19 2:06 ` [i-g-t v3 2/9] tests/kms_vrr: Move vtest_ns into data_t Bhanuprakash Modem
2023-12-19 2:06 ` [i-g-t v3 3/9] tests/kms_vrr: Allow test rate to be altered from the command line Bhanuprakash Modem
2023-12-19 4:56 ` [i-g-t v4 " Bhanuprakash Modem
2023-12-19 2:06 ` [i-g-t v3 4/9] tests/kms_vrr: Allow test duration to be specified " Bhanuprakash Modem
2023-12-19 2:06 ` [i-g-t v3 5/9] tests/kms_vrr: Change the pattern displayed in the test Bhanuprakash Modem
2023-12-19 2:06 ` [i-g-t v3 6/9] tests/kms_vrr: Add ability to flip static image for flicker profiling Bhanuprakash Modem
2023-12-19 2:06 ` [i-g-t v3 7/9] tests/kms_vrr: Allow for multiple rates in a test Bhanuprakash Modem
2023-12-19 2:06 ` [i-g-t v3 8/9] tests/kms_vrr: Add a max/min test to oscillate between rates Bhanuprakash Modem
2023-12-19 7:24 ` [i-g-t v4 " Bhanuprakash Modem
2023-12-19 2:06 ` [i-g-t v3 9/9] HAX/DO_NOT_MERGE: Test VRR only in BAT Bhanuprakash Modem
2023-12-19 6:07 ` ✓ CI.xeBAT: success for tests/kms_vrr: Modify kms_vrr to allow flicker profiling (rev4) Patchwork
2023-12-19 6:18 ` ✗ Fi.CI.BAT: failure " Patchwork
2023-12-19 8:45 ` ✗ Fi.CI.BAT: failure for tests/kms_vrr: Modify kms_vrr to allow flicker profiling (rev5) Patchwork
2023-12-19 8:52 ` ✓ CI.xeBAT: success " Patchwork
-- strict thread matches above, loose matches on Subject: below --
2023-12-18 8:21 [i-g-t v3 0/9] tests/kms_vrr: Modify kms_vrr to allow flicker profiling Bhanuprakash Modem
2023-12-18 8:21 ` [i-g-t v3 1/9] tests/kms_vrr: Move fb0 and fb1 to an array Bhanuprakash Modem
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231219020613.113772-2-bhanuprakash.modem@intel.com \
--to=bhanuprakash.modem@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=seanpaul@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox