From: Melissa Wen <mwen@igalia.com>
To: igt-dev@lists.freedesktop.org,
Petri Latvala <adrinael@adrinael.net>,
Arkadiusz Hiler <arek@hiler.eu>,
Kamil Konieczny <kamil.konieczny@linux.intel.com>,
Bhanuprakash Modem <bhanuprakash.modem@intel.com>,
Ashutosh Dixit <ashutosh.dixit@intel.com>,
Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
Cc: kernel-dev@igalia.com, Arun R Murthy <arun.r.murthy@intel.com>
Subject: [PATCH i-g-t 1/3] test/kms_async_flips: fix test abortion due to unreadable mod name
Date: Tue, 26 Dec 2023 17:57:32 -0100 [thread overview]
Message-ID: <20231226191054.23794-2-mwen@igalia.com> (raw)
In-Reply-To: <20231226191054.23794-1-mwen@igalia.com>
When looking for names of non-intel modifiers, igt_fb_modifier_name()
returns "?" which causes run_test_with_modifiers abortion and therefore
a regression to `async-flip-with-page-flip-events` test case, as below:
(kms_async_flips:9663) igt_core-CRITICAL: Invalid dynamic subtest name "pipe-A-eDP-1-?".
kms_async_flips: ../lib/igt_core.c:2296: igt_exit: Assertion `!test_with_subtests || skipped_one || succeeded_one || failed_one' failed.
Received signal SIGABRT.
Stack trace:
#0 [fatal_sig_handler+0x17b]
#1 [__sigaction+0x40]
#2 [pthread_key_delete+0x14c]
#3 [gsignal+0x12]
#4 [abort+0xd3]
#5 [<unknown>+0xd3]
#6 [__assert_fail+0x42]
#7 [igt_exit+0x1ca]
#8 [__igt_run_dynamic_subtest+0x122]
#9 [run_test_with_modifiers.constprop.0+0x1c7]
#10 [__igt_unique____real_main635+0x56b]
#11 [main+0x27]
#12 [__libc_init_first+0x8a]
#13 [__libc_start_main+0x85]
#14 [_start+0x21]
Aborted
Replacing "?" with "unknown" solves the issue and async flip tests run
again.
Fixes: 7fa7602ccf ("tests/kms_async_flips: Test all modifiers")
Signed-off-by: Melissa Wen <mwen@igalia.com>
---
lib/igt_fb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/igt_fb.c b/lib/igt_fb.c
index 683eb176b..2cf94013e 100644
--- a/lib/igt_fb.c
+++ b/lib/igt_fb.c
@@ -4951,6 +4951,6 @@ const char *igt_fb_modifier_name(uint64_t modifier)
case I915_FORMAT_MOD_4_TILED_DG2_RC_CCS_CC:
return "4-rc-ccs-cc";
default:
- return "?";
+ return "unknown";
}
}
--
2.43.0
next prev parent reply other threads:[~2023-12-26 19:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-26 18:57 [PATCH i-g-t 0/3] test/kms_async_flip: fixes to get execution Melissa Wen
2023-12-26 18:57 ` Melissa Wen [this message]
2024-01-04 18:22 ` [PATCH i-g-t 1/3] test/kms_async_flips: fix test abortion due to unreadable mod name Kamil Konieczny
2023-12-26 18:57 ` [PATCH i-g-t 2/3] lib/igt_fb: fix documentation of igt_create_color_fb return Melissa Wen
2024-01-04 18:24 ` Kamil Konieczny
2024-01-05 11:56 ` Melissa Wen
2023-12-26 18:57 ` [PATCH i-g-t 3/3] tests/kms_async_flips: test with modifiers only on intel devices Melissa Wen
2024-01-04 18:25 ` Kamil Konieczny
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231226191054.23794-2-mwen@igalia.com \
--to=mwen@igalia.com \
--cc=adrinael@adrinael.net \
--cc=arek@hiler.eu \
--cc=arun.r.murthy@intel.com \
--cc=ashutosh.dixit@intel.com \
--cc=bhanuprakash.modem@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=juhapekka.heikkila@gmail.com \
--cc=kamil.konieczny@linux.intel.com \
--cc=kernel-dev@igalia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox