Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [i-g-t] tests/intel/i915_suspend: Fix WARNs of invalid fd
Date: Tue,  9 Jan 2024 18:48:02 +0530	[thread overview]
Message-ID: <20240109131802.2624834-1-bhanuprakash.modem@intel.com> (raw)

Call drm_close_driver() only if fd >=0, otherwise it'll will throw WARN:

(i915_suspend:7563) drmtest-WARNING: Don't attempt to close standard/invalid file descriptor: -1

Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
 tests/intel/i915_suspend.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/tests/intel/i915_suspend.c b/tests/intel/i915_suspend.c
index c25805584..82cabfa41 100644
--- a/tests/intel/i915_suspend.c
+++ b/tests/intel/i915_suspend.c
@@ -300,7 +300,9 @@ test_suspend_without_i915(int state)
 		igt_pm_get_d3cold_allowed(card.pci_slot_name, &d3cold_allowed);
 		igt_pm_set_d3cold_allowed(card.pci_slot_name, 0);
 	}
-	drm_close_driver(fd);
+
+	if (fd >= 0)
+		drm_close_driver(fd);
 
 	igt_kmsg(KMSG_INFO "Unloading i915\n");
 	igt_assert_eq(igt_i915_driver_unload(),0);
-- 
2.40.0

             reply	other threads:[~2024-01-09 13:23 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-09 13:18 Bhanuprakash Modem [this message]
2024-01-09 15:53 ` ✓ Fi.CI.BAT: success for tests/intel/i915_suspend: Fix WARNs of invalid fd Patchwork
2024-01-09 17:15 ` ✓ CI.xeBAT: " Patchwork
2024-01-09 18:00 ` ✗ Fi.CI.IGT: failure " Patchwork
2024-01-17 11:12 ` [i-g-t] " Kamil Konieczny
2024-01-17 15:22   ` Modem, Bhanuprakash
2024-01-17 18:51     ` Kamil Konieczny
2024-01-18  4:44     ` Gupta, Anshuman
2024-01-19 13:32       ` Kamil Konieczny
2024-01-24  8:16         ` Modem, Bhanuprakash
2024-01-24 12:45           ` Kamil Konieczny

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240109131802.2624834-1-bhanuprakash.modem@intel.com \
    --to=bhanuprakash.modem@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox