From: Bommu Krishnaiah <krishnaiah.bommu@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: Bommu Krishnaiah <krishnaiah.bommu@intel.com>,
Rodrigo Vivi <rodrigo.vivi@intel.com>
Subject: [PATCH v3 3/3] tests/xe_waitfence: Removed duplicate code in waitfence
Date: Thu, 11 Jan 2024 11:55:18 +0530 [thread overview]
Message-ID: <20240111062518.393544-4-krishnaiah.bommu@intel.com> (raw)
In-Reply-To: <20240111062518.393544-1-krishnaiah.bommu@intel.com>
Removed duplicate cod in xe_waitfence@waitfence
Signed-off-by: Bommu Krishnaiah <krishnaiah.bommu@intel.com>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
---
lib/xe/xe_ioctl.c | 35 -----------------------------------
lib/xe/xe_ioctl.h | 2 --
tests/intel/xe_waitfence.c | 18 ++++++++++++++++--
3 files changed, 16 insertions(+), 39 deletions(-)
diff --git a/lib/xe/xe_ioctl.c b/lib/xe/xe_ioctl.c
index 39605a019..49c5d359e 100644
--- a/lib/xe/xe_ioctl.c
+++ b/lib/xe/xe_ioctl.c
@@ -523,41 +523,6 @@ int64_t xe_wait_ufence(int fd, uint64_t *addr, uint64_t value,
return timeout;
}
-/**
- * xe_wait_ufence_abstime:
- * @fd: xe device fd
- * @addr: address of value to compare
- * @value: expected value (equal) in @address
- * @exec_queue: exec_queue id
- * @timeout: absolute time when wait expire
- * @flag: wait flag
- *
- * Function compares @value with memory pointed by @addr until they are equal.
- * Asserts that ioctl returned without error.
- *
- * Returns elapsed time in nanoseconds if user fence was signalled.
- */
-int64_t xe_wait_ufence_abstime(int fd, uint64_t *addr, uint64_t value,
- uint32_t exec_queue, int64_t timeout,
- uint16_t flag)
-{
- struct drm_xe_wait_user_fence wait = {
- .addr = to_user_pointer(addr),
- .op = DRM_XE_UFENCE_WAIT_OP_EQ,
- .flags = flag,
- .value = value,
- .mask = DRM_XE_UFENCE_WAIT_MASK_U64,
- .timeout = timeout,
- .exec_queue_id = exec_queue,
- };
- struct timespec ts;
-
- igt_assert_eq(igt_ioctl(fd, DRM_IOCTL_XE_WAIT_USER_FENCE, &wait), 0);
- igt_assert_eq(clock_gettime(CLOCK_MONOTONIC, &ts), 0);
-
- return ts.tv_sec * 1e9 + ts.tv_nsec;
-}
-
void xe_force_gt_reset(int fd, int gt)
{
char reset_string[128];
diff --git a/lib/xe/xe_ioctl.h b/lib/xe/xe_ioctl.h
index 8a92073b0..03932561d 100644
--- a/lib/xe/xe_ioctl.h
+++ b/lib/xe/xe_ioctl.h
@@ -90,8 +90,6 @@ int __xe_wait_ufence(int fd, uint64_t *addr, uint64_t value,
uint32_t exec_queue, int64_t *timeout);
int64_t xe_wait_ufence(int fd, uint64_t *addr, uint64_t value,
uint32_t exec_queue, int64_t timeout);
-int64_t xe_wait_ufence_abstime(int fd, uint64_t *addr, uint64_t value, uint32_t
- exec_queue, int64_t timeout, uint16_t flag);
void xe_force_gt_reset(int fd, int gt);
#endif /* XE_IOCTL_H */
diff --git a/tests/intel/xe_waitfence.c b/tests/intel/xe_waitfence.c
index 2f0f00cf4..f4592bfb3 100644
--- a/tests/intel/xe_waitfence.c
+++ b/tests/intel/xe_waitfence.c
@@ -36,7 +36,21 @@ static void do_bind(int fd, uint32_t vm, uint32_t bo, uint64_t offset,
xe_vm_bind_async(fd, vm, 0, bo, offset, addr, size, sync, 1);
}
-static int64_t wait_with_eci_abstime(int fd, uint64_t *addr, uint64_t value,
+/**
+ * xe_wait_ufence_abstime:
+ * @fd: xe device fd
+ * @addr: address of value to compare
+ * @value: expected value (equal) in @address
+ * @exec_queue: exec_queue id
+ * @timeout: absolute time when wait expire
+ * @flag: wait flag
+ *
+ * Function compares @value with memory pointed by @addr until they are equal.
+ * Asserts that ioctl returned without error.
+ *
+ * Returns elapsed time in nanoseconds if user fence was signalled.
+ */
+static int64_t xe_wait_ufence_abstime(int fd, uint64_t *addr, uint64_t value,
uint32_t exec_queue, int64_t timeout,
uint16_t flag)
{
@@ -117,7 +131,7 @@ waitfence(int fd, enum waittype wt)
clock_gettime(CLOCK_MONOTONIC, &ts);
current = ts.tv_sec * 1e9 + ts.tv_nsec;
timeout = current + MS_TO_NS(10);
- signalled = wait_with_eci_abstime(fd, &wait_fence, 7,
+ signalled = xe_wait_ufence_abstime(fd, &wait_fence, 7,
exec_queue, timeout,
DRM_XE_UFENCE_WAIT_FLAG_ABSTIME);
igt_debug("wait type: ENGINE ABSTIME - timeout: %" PRId64
--
2.25.1
next prev parent reply other threads:[~2024-01-11 6:25 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-11 6:25 [PATCH v3 0/3] tests/xe_waitfence: removed invalid_engine subtest Bommu Krishnaiah
2024-01-11 6:25 ` [PATCH v3 1/3] tests/xe_waitfence: Rename invalid_engine to invalid-exec_queue Bommu Krishnaiah
2024-01-11 14:45 ` Rodrigo Vivi
2024-01-11 6:25 ` [PATCH v3 2/3] tests/xe_waitfence: Removed drm_xe_sync data in exec_queue_reset_wait Bommu Krishnaiah
2024-01-11 14:51 ` Rodrigo Vivi
2024-01-11 14:51 ` Rodrigo Vivi
2024-01-11 6:25 ` Bommu Krishnaiah [this message]
2024-01-11 14:54 ` [PATCH v3 3/3] tests/xe_waitfence: Removed duplicate code in waitfence Rodrigo Vivi
2024-01-11 7:09 ` ✓ CI.xeBAT: success for tests/xe_waitfence: removed invalid_engine subtest (rev3) Patchwork
2024-01-11 7:10 ` ✓ Fi.CI.BAT: " Patchwork
2024-01-11 8:21 ` ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240111062518.393544-4-krishnaiah.bommu@intel.com \
--to=krishnaiah.bommu@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox