From: Ashutosh Dixit <ashutosh.dixit@intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [PATCH i-g-t] i915/perf: Fix loop termination logic in two tests
Date: Wed, 17 Jan 2024 20:55:25 -0800 [thread overview]
Message-ID: <20240118045525.911523-1-ashutosh.dixit@intel.com> (raw)
The code in af9910b3967d ("i915/perf: Check regularly if we are done
reading reports") does not match the commit description. Fix the code to
match the commit description.
Fixes: af9910b3967d ("i915/perf: Check regularly if we are done reading reports")
Cc: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
Signed-off-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
---
tests/intel/perf.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/intel/perf.c b/tests/intel/perf.c
index 3565d61cc393..94738b8a58b4 100644
--- a/tests/intel/perf.c
+++ b/tests/intel/perf.c
@@ -3052,7 +3052,7 @@ test_buffer_fill(const struct intel_execution_engine2 *e)
first_timestamp = oa_timestamp(report, fmt);
last_timestamp = oa_timestamp(report, fmt);
- if (((last_timestamp - first_timestamp) * oa_period) < (fill_duration / 2))
+ if (((last_timestamp - first_timestamp) * oa_period) >= (fill_duration / 2))
break;
if (oa_report_is_periodic(oa_exponent, report)) {
@@ -3279,7 +3279,7 @@ test_enable_disable(const struct intel_execution_engine2 *e)
oa_report_is_periodic(oa_exponent, report),
oa_report_get_ctx_id(report));
- if (((last_timestamp - first_timestamp) * oa_period) < (fill_duration / 2))
+ if (((last_timestamp - first_timestamp) * oa_period) >= (fill_duration / 2))
break;
if (oa_report_is_periodic(oa_exponent, report)) {
--
2.41.0
next reply other threads:[~2024-01-18 4:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-18 4:55 Ashutosh Dixit [this message]
2024-01-18 5:34 ` ✓ CI.xeBAT: success for i915/perf: Fix loop termination logic in two tests Patchwork
2024-01-18 5:46 ` ✓ Fi.CI.BAT: " Patchwork
2024-01-18 7:09 ` ✗ Fi.CI.IGT: failure " Patchwork
2024-01-18 19:38 ` [PATCH i-g-t] " Dixit, Ashutosh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240118045525.911523-1-ashutosh.dixit@intel.com \
--to=ashutosh.dixit@intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox