Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Nirmoy Das <nirmoy.das@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: Nirmoy Das <nirmoy.das@intel.com>
Subject: [PATCH i-g-t] tests/intel/xe_exec_atomic: Skip early on unsupported platform
Date: Fri, 19 Jan 2024 11:18:44 +0100	[thread overview]
Message-ID: <20240119101844.15898-1-nirmoy.das@intel.com> (raw)

Skip early if the test is not supported without
creating a dynamic subtest.

Signed-off-by: Nirmoy Das <nirmoy.das@intel.com>
---
 tests/intel/xe_exec_atomic.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/tests/intel/xe_exec_atomic.c b/tests/intel/xe_exec_atomic.c
index a21def999..209df8419 100644
--- a/tests/intel/xe_exec_atomic.c
+++ b/tests/intel/xe_exec_atomic.c
@@ -137,14 +137,14 @@ igt_main
 
 			xe_for_each_mem_region(fd, memreg, region) {
 
+					igt_skip_on(!has_atomics(fd, region));
+
 				igt_dynamic_f("Engine-%s-Instance-%d-Tile-%d-%s-memory",
 					      xe_engine_class_string(hwe->engine_class),
 					      hwe->engine_instance,
-					      hwe->gt_id, xe_region_name(region)) {
+					      hwe->gt_id, xe_region_name(region))
 
-					igt_skip_on(!has_atomics(fd, region));
 					basic_inst(fd, MI_ATOMIC_DEC, hwe, region);
-				}
 			}
 		}
 	}
@@ -155,14 +155,14 @@ igt_main
 
 			xe_for_each_mem_region(fd, memreg, region) {
 
+					igt_skip_on(!has_atomics(fd, region));
+
 				igt_dynamic_f("Engine-%s-Instance-%d-Tile-%d-%s-memory",
 					      xe_engine_class_string(hwe->engine_class),
 					      hwe->engine_instance,
-					      hwe->gt_id, xe_region_name(region)) {
+					      hwe->gt_id, xe_region_name(region))
 
-					igt_skip_on(!has_atomics(fd, region));
 					basic_inst(fd, MI_ATOMIC_INC, hwe, region);
-				}
 			}
 		}
 	}
-- 
2.42.0


             reply	other threads:[~2024-01-19 10:32 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-19 10:18 Nirmoy Das [this message]
2024-01-19 11:00 ` ✓ CI.xeBAT: success for tests/intel/xe_exec_atomic: Skip early on unsupported platform Patchwork
2024-01-19 11:19 ` ✗ Fi.CI.BAT: failure " Patchwork
2024-01-19 12:50 ` [PATCH i-g-t] " Kamil Konieczny
2024-01-19 14:16 ` ✗ Fi.CI.BAT: failure for tests/intel/xe_exec_atomic: Skip early on unsupported platform (rev2) Patchwork
2024-01-19 15:14 ` ✓ CI.xeBAT: success " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240119101844.15898-1-nirmoy.das@intel.com \
    --to=nirmoy.das@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox