From: Kunal Joshi <kunal1.joshi@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: Kunal Joshi <kunal1.joshi@intel.com>
Subject: [PATCH i-g-t 2/2] tests/intel/kms_psr: enable given psr mode only after checking enable_psr modparam
Date: Tue, 23 Jan 2024 19:48:35 +0530 [thread overview]
Message-ID: <20240123141835.1211107-3-kunal1.joshi@intel.com> (raw)
In-Reply-To: <20240123141835.1211107-1-kunal1.joshi@intel.com>
don't enable a psr mode with psr_debug debugfs, instead check what's
the modparam value for i915_enable_psr
Signed-off-by: Kunal Joshi <kunal1.joshi@intel.com>
---
tests/intel/kms_psr.c | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/tests/intel/kms_psr.c b/tests/intel/kms_psr.c
index 349671b00..521d4c708 100644
--- a/tests/intel/kms_psr.c
+++ b/tests/intel/kms_psr.c
@@ -497,16 +497,28 @@ static void fill_render(data_t *data, const struct igt_fb *fb,
static bool psr_wait_entry_if_enabled(data_t *data)
{
+ if (!is_psr_enable_possible(data->drm_fd, data->op_psr_mode))
+ igt_skip("enable_psr modparam doesn't allow psr mode %d\n",
+ data->op_psr_mode);
+
return psr_wait_entry(data->debugfs_fd, data->op_psr_mode, data->output);
}
static bool psr_wait_update_if_enabled(data_t *data)
{
+ if (!is_psr_enable_possible(data->drm_fd, data->op_psr_mode))
+ igt_skip("enable_psr modparam doesn't allow psr mode %d\n",
+ data->op_psr_mode);
+
return psr_wait_update(data->debugfs_fd, data->op_psr_mode, data->output);
}
static bool psr_enable_if_enabled(data_t *data)
{
+ if (!is_psr_enable_possible(data->drm_fd, data->op_psr_mode))
+ igt_skip("enable_psr modparam doesn't allow psr mode %d\n",
+ data->op_psr_mode);
+
return psr_enable(data->drm_fd, data->debugfs_fd, data->op_psr_mode);
}
--
2.25.1
next prev parent reply other threads:[~2024-01-23 14:09 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-23 14:18 [PATCH i-g-t 0/2] check modparam before enabling psr mode Kunal Joshi
2024-01-23 14:18 ` [PATCH i-g-t 1/2] lib/igt_psr: add helper to check of given psr mode can be enabled Kunal Joshi
2024-01-23 14:44 ` B, Jeevan
2024-01-24 5:30 ` Modem, Bhanuprakash
2024-01-23 14:18 ` Kunal Joshi [this message]
2024-01-23 14:44 ` [PATCH i-g-t 2/2] tests/intel/kms_psr: enable given psr mode only after checking enable_psr modparam B, Jeevan
2024-01-23 15:11 ` Srinivas, Vidya
2024-01-23 17:22 ` ✓ Fi.CI.BAT: success for check modparam before enabling psr mode Patchwork
2024-01-23 18:11 ` ✓ CI.xeBAT: " Patchwork
2024-01-24 0:17 ` ✗ Fi.CI.IGT: failure " Patchwork
-- strict thread matches above, loose matches on Subject: below --
2024-01-24 10:34 [PATCH i-g-t 0/2] " Kunal Joshi
2024-01-24 10:34 ` [PATCH i-g-t 2/2] tests/intel/kms_psr: enable given psr mode only after checking enable_psr modparam Kunal Joshi
2024-01-24 14:42 ` Modem, Bhanuprakash
2024-01-24 15:06 ` Joshi, Kunal1
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240123141835.1211107-3-kunal1.joshi@intel.com \
--to=kunal1.joshi@intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox