From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A20DFC47258 for ; Thu, 25 Jan 2024 15:41:30 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5762610F924; Thu, 25 Jan 2024 15:41:30 +0000 (UTC) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.9]) by gabe.freedesktop.org (Postfix) with ESMTPS id 30DA310F921 for ; Thu, 25 Jan 2024 15:41:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1706197289; x=1737733289; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=vsVgFHU6zIL/GJ63Fhdt0FejRWJ8SWtuWSLm2n/XM6o=; b=Wxkee0UQoJ9wnYRlhdPxPBz+GNTnxeoT3GyB8+nuuYQISt3j5K+T1U5d 1K+7sCqtHPUpK9mwbQsXJjdUgTokXA4WFacsX03enjrQLeNeadE13aWtt tpC5LtR1wdJEpv1NejRdtgkbFIweo6MmcBp7iXJPnaWBsaWtooa6zK4ag Q2xqIS69YksGZ+ZvazigmnBGmpWZqwypKpVhXk6sHNsIeaFnLnrt2fwel +TTX4R0q9hQMi3LjUy8iYn7tz/mOmXPWpRHSai/gzrH1/tNm8gYTtTKKY 1wDqztZIw7kbYxLcNIqfTIeG4xfUGke/M+ljTGRZ9KRk5N2fTN/5vc0l/ Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10964"; a="20743806" X-IronPort-AV: E=Sophos;i="6.05,216,1701158400"; d="scan'208";a="20743806" Received: from orviesa001.jf.intel.com ([10.64.159.141]) by orvoesa101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Jan 2024 07:41:29 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.05,216,1701158400"; d="scan'208";a="35137500" Received: from anshuma1-desk.iind.intel.com ([10.190.239.112]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Jan 2024 07:41:28 -0800 From: Anshuman Gupta To: igt-dev@lists.freedesktop.org Subject: [PATCH i-g-t v7 2/4] lib/igt_pm: Add helper to get/set auto_suspenddelay_ms Date: Thu, 25 Jan 2024 21:11:12 +0530 Message-Id: <20240125154114.2164080-3-anshuman.gupta@intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20240125154114.2164080-1-anshuman.gupta@intel.com> References: <20240125154114.2164080-1-anshuman.gupta@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: igt-dev@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development mailing list for IGT GPU Tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rodrigo Vivi Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" Sometimes we want to test pm igt test with an explicit auto suspend delay, therefore adding helpers to get/set the pci_dev auto_suspenddelay_ms. v2: - close delay_fd. [Kamil] v3: - Addressed cosmetics comment. [Kamil] Reviewed-by: Rodrigo Vivi Signed-off-by: Anshuman Gupta Reviewed-by: Kamil Konieczny --- lib/igt_pm.c | 58 +++++++++++++++++++++++++++++++++++++++++----------- lib/igt_pm.h | 2 ++ 2 files changed, 48 insertions(+), 12 deletions(-) diff --git a/lib/igt_pm.c b/lib/igt_pm.c index c2d98fceb..fe7692960 100644 --- a/lib/igt_pm.c +++ b/lib/igt_pm.c @@ -1068,18 +1068,6 @@ static void igt_pm_write_power_attr(int fd, const char *val, int len) igt_assert(strncmp(buf, val, len) == 0); } -static int igt_pm_get_autosuspend_delay(struct pci_device *pci_dev) -{ - char delay_str[64]; - int delay, delay_fd; - - delay_fd = igt_pm_get_power_attr_fd(pci_dev, "autosuspend_delay_ms"); - if (igt_pm_read_power_attr(delay_fd, delay_str, 64, true)) - igt_assert(sscanf(delay_str, "%d", &delay) > 0); - - return delay; -} - static void igt_pm_setup_pci_dev_power_attrs(struct pci_device *pci_dev, struct igt_pm_pci_dev_pwrattr *pwrattr, int delay_ms) @@ -1165,6 +1153,52 @@ igt_pm_setup_pci_card_power_attrs(struct pci_device *pci_dev, bool save_attrs, i pci_iterator_destroy(iter); } +/** + * igt_pm_get_autosuspend_delay: + * @pci_dev: pci_dev. + * + * Get pci_dev autosuspend delay value from pci sysfs. + * + * Returns: + * autosuspend_delay_ms. + */ +int igt_pm_get_autosuspend_delay(struct pci_device *pci_dev) +{ + char delay_str[64]; + int delay, delay_fd; + + delay_fd = igt_pm_get_power_attr_fd(pci_dev, "autosuspend_delay_ms"); + if (igt_pm_read_power_attr(delay_fd, delay_str, 64, true)) + igt_assert(sscanf(delay_str, "%d", &delay) > 0); + + close(delay_fd); + return delay; +} + +/** + * igt_pm_set_autosuspend_delay: + * @pci_dev: pci_dev. + * @delay_ms: autosuspend delay in ms. + * + * Set pci_dev autosuspend delay value through pci sysfs. + */ +void igt_pm_set_autosuspend_delay(struct pci_device *pci_dev, int delay_ms) +{ + char delay_str[64]; + int delay_fd; + + delay_fd = igt_pm_get_power_attr_fd(pci_dev, "autosuspend_delay_ms"); + + if (delay_ms >= 0) { + int wc; + + wc = snprintf(delay_str, 64, "%d\n", delay_ms); + igt_pm_write_power_attr(delay_fd, delay_str, wc); + } + + close(delay_fd); +} + /** * igt_pm_enable_pci_card_runtime_pm: * @root: root port pci_dev. diff --git a/lib/igt_pm.h b/lib/igt_pm.h index 538b6e39e..91ee05cd1 100644 --- a/lib/igt_pm.h +++ b/lib/igt_pm.h @@ -82,6 +82,8 @@ int igt_pm_get_pcie_acpihp_slot(struct pci_device *pci_dev); bool igt_pm_acpi_d3cold_supported(struct pci_device *pci_dev); enum igt_acpi_d_state igt_pm_get_acpi_real_d_state(struct pci_device *pci_dev); +int igt_pm_get_autosuspend_delay(struct pci_device *pci_dev); +void igt_pm_set_autosuspend_delay(struct pci_device *pci_dev, int delay_ms); void igt_pm_enable_pci_card_runtime_pm(struct pci_device *root, struct pci_device *i915); void igt_pm_get_d3cold_allowed(const char *pci_slot_name, uint32_t *value); -- 2.25.1