Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Lucas De Marchi <lucas.demarchi@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: Lucas De Marchi <lucas.demarchi@intel.com>
Subject: [PATCH i-g-t 3/3] lib/igt_sysfs: Fix dir fd documentation
Date: Wed, 31 Jan 2024 16:50:30 -0800	[thread overview]
Message-ID: <20240201005115.352192-4-lucas.demarchi@intel.com> (raw)
In-Reply-To: <20240201005115.352192-1-lucas.demarchi@intel.com>

These functions can be used for any path in sysfs, not exclusively to
attributes under igt_sysfs_open(). In fact, they are already used to
access other files like module parameters.

Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
---
 lib/igt_sysfs.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/lib/igt_sysfs.c b/lib/igt_sysfs.c
index 814220ddb..bbcb16c81 100644
--- a/lib/igt_sysfs.c
+++ b/lib/igt_sysfs.c
@@ -343,7 +343,7 @@ int igt_sysfs_get_num_gt(int device)
 
 /**
  * igt_sysfs_write:
- * @dir: directory for the device from igt_sysfs_open()
+ * @dir: sysfs directory
  * @attr: name of the sysfs node to open
  * @data: the block to write from
  * @len: the length to write
@@ -369,7 +369,7 @@ int igt_sysfs_write(int dir, const char *attr, const void *data, int len)
 
 /**
  * igt_sysfs_read:
- * @dir: directory for the device from igt_sysfs_open()
+ * @dir: sysfs directory
  * @attr: name of the sysfs node to open
  * @data: the block to read into
  * @len: the maximum length to read
@@ -395,7 +395,7 @@ int igt_sysfs_read(int dir, const char *attr, void *data, int len)
 
 /**
  * igt_sysfs_set:
- * @dir: directory for the device from igt_sysfs_open()
+ * @dir: sysfs directory
  * @attr: name of the sysfs node to open
  * @value: the string to write
  *
@@ -412,7 +412,7 @@ bool igt_sysfs_set(int dir, const char *attr, const char *value)
 
 /**
  * igt_sysfs_get:
- * @dir: directory for the device from igt_sysfs_open()
+ * @dir: sysfs directory
  * @attr: name of the sysfs node to open
  *
  * This reads the value from the sysfs file.
-- 
2.43.0


  parent reply	other threads:[~2024-02-01  0:51 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-01  0:50 [PATCH i-g-t 0/3] igt_kmod and sysfs fixes Lucas De Marchi
2024-02-01  0:50 ` [PATCH i-g-t 1/3] lib/igt_kmod: stop using KMOD_REMOVE_FORCE Lucas De Marchi
2024-02-01 13:05   ` Kamil Konieczny
2024-02-01 14:03     ` Lucas De Marchi
2024-02-06 17:27       ` Kamil Konieczny
2024-02-01  0:50 ` [PATCH i-g-t 2/3] lib/igt_sysfs: make sure to write empty strings Lucas De Marchi
2024-02-01  3:11   ` [PATCH i-g-t v2] " Lucas De Marchi
2024-02-01 13:12     ` Kamil Konieczny
2024-02-01 13:59       ` Lucas De Marchi
2024-02-07 16:18       ` Kamil Konieczny
2024-02-07 16:46         ` Lucas De Marchi
2024-02-01 13:15   ` [PATCH i-g-t 2/3] " Janusz Krzysztofik
2024-02-01 13:51     ` Lucas De Marchi
2024-02-06 15:25       ` Janusz Krzysztofik
2024-02-06 17:13         ` Lucas De Marchi
2024-02-07 10:09           ` Janusz Krzysztofik
2024-02-01  0:50 ` Lucas De Marchi [this message]
2024-02-01 13:05   ` [PATCH i-g-t 3/3] lib/igt_sysfs: Fix dir fd documentation Kamil Konieczny
2024-02-01  2:56 ` ✗ Fi.CI.BAT: failure for igt_kmod and sysfs fixes Patchwork
2024-02-01  3:08 ` ✗ CI.xeBAT: " Patchwork
2024-02-01  3:41 ` ✗ CI.xeBAT: failure for igt_kmod and sysfs fixes (rev2) Patchwork
2024-02-01  4:05 ` ✗ Fi.CI.BAT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240201005115.352192-4-lucas.demarchi@intel.com \
    --to=lucas.demarchi@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox