From: "Zbigniew Kempczyński" <zbigniew.kempczynski@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: Karolina Drobnik <karolina.drobnik@intel.com>
Subject: [PATCH i-g-t v3 1/4] lib/intel_blt: Add helpers for calculating stride and aligned height
Date: Thu, 1 Feb 2024 10:22:24 +0100 [thread overview]
Message-ID: <20240201092227.252502-2-zbigniew.kempczynski@intel.com> (raw)
In-Reply-To: <20240201092227.252502-1-zbigniew.kempczynski@intel.com>
Tiled surfaces have stride / aligned height constraints. Currently
blt library has limitation and doesn't work properly when surface
stride is not valid for specific tiling.
As an example lets say we want to copy from linear to xmajor
33 x 33 x 32bpp surface. Xmajor surface expects stride aligned to
512 bytes and height to 8 rows so this surface will occupy 512B x 40
(128 x 40 x 32 bpp).
Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
Cc: Karolina Drobnik <karolina.drobnik@intel.com>
---
v2: Fix stride/aligned height calculation for Tile64
v3: Fix stride calculation for xmajor
Make helpers public (fixes compilation warning due to lack
or static function users)
---
lib/intel_blt.c | 64 +++++++++++++++++++++++++++++++++++++++++++++++++
lib/intel_blt.h | 4 ++++
2 files changed, 68 insertions(+)
diff --git a/lib/intel_blt.c b/lib/intel_blt.c
index 25d251c4f8..13b1dbba4f 100644
--- a/lib/intel_blt.c
+++ b/lib/intel_blt.c
@@ -521,6 +521,70 @@ static int __block_tiling(enum blt_tiling_type tiling)
return 0;
}
+/**
+ * blt_get_min_stride
+ * @width: width in pixels
+ * @bpp: bits per pixel
+ * @tiling: tiling
+ *
+ * Function returns minimum posibble stride in bytes for width, bpp and tiling.
+ *
+ * Returns:
+ * minimum possible stride in bytes.
+ */
+uint32_t blt_get_min_stride(uint32_t width, uint32_t bpp,
+ enum blt_tiling_type tiling)
+{
+ switch (tiling) {
+ case T_LINEAR:
+ return width * bpp / 8;
+ case T_XMAJOR:
+ return ALIGN(width * bpp / 8, 512);
+ case T_TILE64:
+ if (bpp == 8)
+ return ALIGN(width, 256);
+ else if (bpp == 16 || bpp == 32)
+ return ALIGN(width * bpp / 8, 512);
+ return ALIGN(width * bpp / 8, 1024);
+
+ default:
+ return ALIGN(width * bpp / 8, 128);
+ }
+}
+
+/**
+ * blt_get_aligned_height
+ * @height: height in pixels
+ * @bpp: bits per pixel (used for Tile64 due to different tile organization
+ * in pixels)
+ * @tiling: tiling
+ *
+ * Function returns aligned height for specific tiling. Height returned is
+ * important from memory allocation perspective, because each tiling has
+ * specific memory constraints.
+ *
+ * Returns:
+ * height (rows) expected for specific tiling
+ */
+uint32_t blt_get_aligned_height(uint32_t height, uint32_t bpp,
+ enum blt_tiling_type tiling)
+{
+ switch (tiling) {
+ case T_LINEAR:
+ return height;
+ case T_XMAJOR:
+ return ALIGN(height, 8);
+ case T_TILE64:
+ if (bpp == 8)
+ return ALIGN(height, 256);
+ else if (bpp == 16 || bpp == 32)
+ return ALIGN(height, 128);
+ return ALIGN(height, 64);
+ default:
+ return ALIGN(height, 32);
+ }
+}
+
static int __special_mode(const struct blt_copy_data *blt)
{
if (blt->src.handle == blt->dst.handle &&
diff --git a/lib/intel_blt.h b/lib/intel_blt.h
index d9be22fdf4..e3084dc0cd 100644
--- a/lib/intel_blt.h
+++ b/lib/intel_blt.h
@@ -212,6 +212,10 @@ bool blt_block_copy_supports_compression(int fd);
bool blt_uses_extended_block_copy(int fd);
const char *blt_tiling_name(enum blt_tiling_type tiling);
+uint32_t blt_get_min_stride(uint32_t width, uint32_t bpp,
+ enum blt_tiling_type tiling);
+uint32_t blt_get_aligned_height(uint32_t height, uint32_t bpp,
+ enum blt_tiling_type tiling);
void blt_copy_init(int fd, struct blt_copy_data *blt);
--
2.34.1
next prev parent reply other threads:[~2024-02-01 9:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-01 9:22 [PATCH i-g-t v3 0/4] Fill block-copy test gap for unaligned sizes Zbigniew Kempczyński
2024-02-01 9:22 ` Zbigniew Kempczyński [this message]
2024-02-01 9:22 ` [PATCH i-g-t v3 2/4] lib/intel_blt: Change surface size calculation Zbigniew Kempczyński
2024-02-01 9:22 ` [PATCH i-g-t v3 3/4] lib/intel_blt: Use object pitch and aligned height on png write Zbigniew Kempczyński
2024-02-01 9:22 ` [PATCH i-g-t v3 4/4] tests/xe-ccs: Add tests which exercise small to large blit sizes Zbigniew Kempczyński
2024-02-01 10:19 ` ✓ Fi.CI.BAT: success for Fill block-copy test gap for unaligned sizes (rev3) Patchwork
2024-02-01 10:39 ` ✓ CI.xeBAT: " Patchwork
2024-02-01 11:37 ` ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240201092227.252502-2-zbigniew.kempczynski@intel.com \
--to=zbigniew.kempczynski@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=karolina.drobnik@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox