From: Matthew Auld <matthew.auld@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: "Akshata Jahagirdar" <akshata.jahagirdar@intel.com>,
"Zbigniew Kempczyński" <zbigniew.kempczynski@intel.com>
Subject: [PATCH i-g-t v3 2/3] tests/intel/xe_ccs: require flat CCS on xe2
Date: Thu, 1 Feb 2024 14:03:14 +0000 [thread overview]
Message-ID: <20240201140315.334388-2-matthew.auld@intel.com> (raw)
In-Reply-To: <20240201140315.334388-1-matthew.auld@intel.com>
On Xe2 compression is handled via PAT indexes and flat CCS, even on
igpu. Ensure the device has flat CCS support on such hardware, to
determine if these tests are valid.
v2: (Zbigniew)
- There is at least one uncompressed test also, which is valid
regardless of CCS. Move the skip deeper.
v3:
- HAS_FLATCCS() expects dev_id.
Signed-off-by: Matthew Auld <matthew.auld@intel.com>
Cc: Akshata Jahagirdar <akshata.jahagirdar@intel.com>
Cc: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
---
tests/intel/xe_ccs.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/tests/intel/xe_ccs.c b/tests/intel/xe_ccs.c
index 7d0e8ed7a..9cfff8c50 100644
--- a/tests/intel/xe_ccs.c
+++ b/tests/intel/xe_ccs.c
@@ -532,6 +532,7 @@ static void block_copy_test(int xe,
struct igt_collection *set,
enum copy_func copy_function)
{
+ uint16_t dev_id = intel_get_drm_devid(xe);
struct drm_xe_engine_class_instance inst = {
.engine_class = DRM_XE_ENGINE_CLASS_COPY,
};
@@ -540,6 +541,9 @@ static void block_copy_test(int xe,
uint32_t vm, exec_queue;
int tiling;
+ if (AT_LEAST_GEN(dev_id, 20) && config->compression)
+ igt_require(HAS_FLATCCS(dev_id));
+
if (config->compression && !blt_block_copy_supports_compression(xe))
return;
--
2.43.0
next prev parent reply other threads:[~2024-02-01 14:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-01 14:03 [PATCH i-g-t v3 1/3] lib/intel_device_info: set has_flatccs on LNL Matthew Auld
2024-02-01 14:03 ` Matthew Auld [this message]
2024-02-01 14:03 ` [PATCH i-g-t v3 3/3] tests/intel/xe_pat: assert flat CSS support for xe2 Matthew Auld
2024-02-01 15:17 ` ✓ Fi.CI.BAT: success for series starting with [i-g-t,v3,1/3] lib/intel_device_info: set has_flatccs on LNL Patchwork
2024-02-01 15:33 ` ✓ CI.xeBAT: " Patchwork
2024-02-01 16:33 ` ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240201140315.334388-2-matthew.auld@intel.com \
--to=matthew.auld@intel.com \
--cc=akshata.jahagirdar@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=zbigniew.kempczynski@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox