From: Francois Dugast <francois.dugast@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: "Francois Dugast" <francois.dugast@intel.com>,
"John Harrison" <John.C.Harrison@Intel.com>,
"José Roberto de Souza" <jose.souza@intel.com>,
"Lucas De Marchi" <lucas.demarchi@intel.com>
Subject: [PATCH i-g-t 2/2] drm-uapi/xe: Add test to query HuC firmware version
Date: Wed, 7 Feb 2024 20:46:59 +0000 [thread overview]
Message-ID: <20240207204659.7-3-francois.dugast@intel.com> (raw)
In-Reply-To: <20240207204659.7-1-francois.dugast@intel.com>
This aligns with kernel commit ("drm/xe: Extend uAPI to query HuC
micro-controler firmware version").
Cc: John Harrison <John.C.Harrison@Intel.com>
Cc: José Roberto de Souza <jose.souza@intel.com>
Cc: Lucas De Marchi <lucas.demarchi@intel.com>
Signed-off-by: Francois Dugast <francois.dugast@intel.com>
---
include/drm-uapi/xe_drm.h | 1 +
tests/intel/xe_query.c | 46 +++++++++++++++++++++++++++++++++++++++
2 files changed, 47 insertions(+)
diff --git a/include/drm-uapi/xe_drm.h b/include/drm-uapi/xe_drm.h
index 3bd795f27..ce4acf9d4 100644
--- a/include/drm-uapi/xe_drm.h
+++ b/include/drm-uapi/xe_drm.h
@@ -583,6 +583,7 @@ struct drm_xe_query_engine_cycles {
struct drm_xe_query_uc_fw_version {
/** @uc: The micro-controller type to query firmware version */
#define XE_QUERY_UC_TYPE_GUC_SUBMISSION 0
+#define XE_QUERY_UC_TYPE_HUC 1
__u16 uc_type;
/** @pad: MBZ */
diff --git a/tests/intel/xe_query.c b/tests/intel/xe_query.c
index d51e73ea5..c2eebe801 100644
--- a/tests/intel/xe_query.c
+++ b/tests/intel/xe_query.c
@@ -825,6 +825,51 @@ test_query_uc_fw_version_invalid_mbz(int fd)
free(uc_fw_version);
}
+/**
+ * SUBTEST: query-uc-fw-version-huc
+ * Test category: functionality test
+ * Description: Display the HuC firmware version
+ *
+ * SUBTEST: multigpu-query-uc-fw-version-huc
+ * Test category: functionality test
+ * Sub-category: MultiGPU
+ * Description: Display HuC firmware version for all Xe devices.
+ */
+static void
+test_query_uc_fw_version_huc(int fd)
+{
+ struct drm_xe_query_uc_fw_version *uc_fw_version;
+ struct drm_xe_device_query query = {
+ .extensions = 0,
+ .query = DRM_XE_DEVICE_QUERY_UC_FW_VERSION,
+ .size = 0,
+ .data = 0,
+ };
+
+ igt_assert_eq(igt_ioctl(fd, DRM_IOCTL_XE_DEVICE_QUERY, &query), 0);
+
+ uc_fw_version = malloc(query.size);
+ igt_assert(uc_fw_version);
+
+ uc_fw_version->uc_type = XE_QUERY_UC_TYPE_HUC;
+ uc_fw_version->pad = 0;
+ uc_fw_version->pad2 = 0;
+ uc_fw_version->reserved = 0;
+ query.data = to_user_pointer(uc_fw_version);
+
+ if (igt_ioctl(fd, DRM_IOCTL_XE_DEVICE_QUERY, &query) == 0) {
+ igt_assert(uc_fw_version->major_ver > 0);
+
+ igt_info("XE_QUERY_UC_TYPE_HUC %u.%u.%u\n",
+ uc_fw_version->major_ver,
+ uc_fw_version->minor_ver,
+ uc_fw_version->patch_ver,
+ uc_fw_version->branch_ver);
+ }
+
+ free(uc_fw_version);
+}
+
igt_main
{
const struct {
@@ -839,6 +884,7 @@ igt_main
{ "query-topology", test_query_gt_topology },
{ "query-cs-cycles", test_query_engine_cycles },
{ "query-uc-fw-version-guc", test_query_uc_fw_version_guc },
+ { "query-uc-fw-version-huc", test_query_uc_fw_version_huc },
{ "query-invalid-cs-cycles", test_engine_cycles_invalid },
{ "query-invalid-query", test_query_invalid_query },
{ "query-invalid-size", test_query_invalid_size },
--
2.34.1
next prev parent reply other threads:[~2024-02-07 20:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-07 20:46 [PATCH i-g-t 0/2] Add tests to query firmware version Francois Dugast
2024-02-07 20:46 ` [PATCH i-g-t 1/2] drm-uapi/xe: Add test to query GuC firmware submission version Francois Dugast
2024-02-07 20:46 ` Francois Dugast [this message]
2024-02-07 20:52 ` [PATCH i-g-t 2/2] drm-uapi/xe: Add test to query HuC firmware version Souza, Jose
2024-02-07 21:31 ` ✓ CI.xeBAT: success for Add tests to query " Patchwork
2024-02-07 21:54 ` ✓ Fi.CI.BAT: " Patchwork
2024-02-08 2:26 ` ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240207204659.7-3-francois.dugast@intel.com \
--to=francois.dugast@intel.com \
--cc=John.C.Harrison@Intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=jose.souza@intel.com \
--cc=lucas.demarchi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox