Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Mauro Carvalho Chehab <mauro.chehab@linux.intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [PATCH i-g-t 3/3] scripts/igt_doc.py: fix trivial case handling
Date: Thu, 22 Feb 2024 08:40:01 +0100	[thread overview]
Message-ID: <20240222074208.173368-4-mauro.chehab@linux.intel.com> (raw)
In-Reply-To: <20240222074208.173368-1-mauro.chehab@linux.intel.com>

From: Mauro Carvalho Chehab <mchehab@kernel.org>

The check is done too late, causing it to not do what it was
expected: instead of checking for the gpu_set, it shall instead
check if the subnames dict is empty.

Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
---
 scripts/igt_doc.py | 25 +++++++++++++------------
 1 file changed, 13 insertions(+), 12 deletions(-)

diff --git a/scripts/igt_doc.py b/scripts/igt_doc.py
index 7985cdd5ac5e..db2713e65fa3 100755
--- a/scripts/igt_doc.py
+++ b/scripts/igt_doc.py
@@ -124,6 +124,10 @@ class IgtTestList(TestList):
         testlists = {}
         default_gpu = "default"
 
+        # Always create a default GPU, as not all GPUs may be
+        # listed at include/exclude testlists
+        gpu_set.add(default_gpu)
+
         for driver, run_types in tests_per_list.items():
             testlists[driver] = {}
             for run_type, subnames in run_types.items():
@@ -131,15 +135,10 @@ class IgtTestList(TestList):
                 if not run_type:
                     run_type = "other"
 
-                for subname, gpus in subnames.items():
-                    # Globally blocklisted values: ignore subtest
-                    if "all" in tests_per_list[driver][run_type][subname]:
-                        continue
-
-                    # Trivial case: fields not defined: add subtest
-                    if not gpu_set:
-                        if default_gpu not in testlists[driver]:
-                            testlists[driver][default_gpu] = {}
+                # Trivial case: no GPUs defined for the test
+                if not subnames:
+                    if default_gpu not in testlists[driver]:
+                        testlists[driver][default_gpu] = {}
 
                         if run_type not in testlists[driver][default_gpu]:
                             testlists[driver][default_gpu][run_type] = set()
@@ -147,6 +146,11 @@ class IgtTestList(TestList):
                         testlists[driver][default_gpu][run_type].add(subname)
                         continue
 
+                for subname, gpus in subnames.items():
+                    # Globally blocklisted values: ignore subtest
+                    if "all" in tests_per_list[driver][run_type][subname]:
+                        continue
+
                     if not gpus:
                         for gpu in gpu_set:
                             # blocked on all GPUs: ignore subtest
@@ -184,9 +188,6 @@ class IgtTestList(TestList):
 
                         testlists[driver][gpu][run_type].add(subname)
 
-        if len(gpu_set) == 0:
-            gpu_set.add(default_gpu)
-
         return (testlists, gpu_set)
 
 class IntelciTestlist:
-- 
2.43.2


  parent reply	other threads:[~2024-02-22  7:42 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-22  7:39 [PATCH i-g-t 0/3] Additional fixes for IntelCI testlist generation Mauro Carvalho Chehab
2024-02-22  7:39 ` [PATCH i-g-t 1/3] scripts/igt_doc.py: fix intelci testlist generation for complex cases Mauro Carvalho Chehab
2024-02-22  7:40 ` [PATCH i-g-t 2/3] scripts/igt_doc.py: ignore "all" when producing testlists Mauro Carvalho Chehab
2024-02-22  7:40 ` Mauro Carvalho Chehab [this message]
2024-02-22  9:02 ` ✓ CI.xeBAT: success for Additional fixes for IntelCI testlist generation Patchwork
2024-02-22  9:17 ` ✓ Fi.CI.BAT: " Patchwork
2024-02-22 16:38 ` ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240222074208.173368-4-mauro.chehab@linux.intel.com \
    --to=mauro.chehab@linux.intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox