Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Mauro Carvalho Chehab <mauro.chehab@linux.intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [PATCH i-g-t v2 1/4] scripts/igt_doc.py: fix intelci testlist generation for complex cases
Date: Thu, 22 Feb 2024 12:45:25 +0100	[thread overview]
Message-ID: <20240222114741.196042-2-mauro.chehab@linux.intel.com> (raw)
In-Reply-To: <20240222114741.196042-1-mauro.chehab@linux.intel.com>

From: Mauro Carvalho Chehab <mchehab@kernel.org>

The most complex case is when a test is included or block listed, via
GPU and "Excluded GPU platform" fields, as the same test might be
on both lists.

Currently, the handling logic doesn't go though all GPUs, which ends
supressing tests from testlists if the GPU is not mentioned.

Fix it, while simplifying the logic.

Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
---
 scripts/igt_doc.py | 26 ++++++++------------------
 1 file changed, 8 insertions(+), 18 deletions(-)

diff --git a/scripts/igt_doc.py b/scripts/igt_doc.py
index 3a45371a27e7..7404e3d0934c 100755
--- a/scripts/igt_doc.py
+++ b/scripts/igt_doc.py
@@ -163,36 +163,26 @@ class IgtTestList(TestList):
                             testlists[driver][gpu][run_type].add(subname)
                         continue
 
-                    default_gpu_value = True
-
                     # If GPU field is used, default is to block list
+                    default_gpu_value = True
                     for gpu, value in gpus.items():
                         if value:
                             default_gpu_value = False
                             break
 
-                    for gpu, value in gpus.items():
+                    for gpu in gpu_set:
+                        value = tests_per_list[driver][run_type][subname].get(gpu, default_gpu_value)
+
+                        if not value:
+                            continue
+
                         if gpu not in testlists[driver]:
                             testlists[driver][gpu] = {}
 
                         if run_type not in testlists[driver][gpu]:
                             testlists[driver][gpu][run_type] = set()
 
-                        value = default_gpu_value
-                        if gpu in tests_per_list[driver][run_type][subname]:
-                            value = tests_per_list[driver][run_type][subname]
-
-                        if value:
-                            testlists[driver][gpu][run_type].add(subname)
-
-                    if default_gpu_value:
-                        if default_gpu not in testlists[driver]:
-                            testlists[driver][default_gpu] = {}
-
-                        if run_type not in testlists[driver][default_gpu]:
-                            testlists[driver][default_gpu][run_type] = set()
-
-                        testlists[driver][default_gpu][run_type].add(subname)
+                        testlists[driver][gpu][run_type].add(subname)
 
         if len(gpu_set) == 0:
             gpu_set.add(default_gpu)
-- 
2.43.2


  reply	other threads:[~2024-02-22 11:47 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-22 11:45 [PATCH i-g-t v2 0/4] Additional fixes for IntelCI testlist generation Mauro Carvalho Chehab
2024-02-22 11:45 ` Mauro Carvalho Chehab [this message]
2024-02-26 10:54   ` [PATCH i-g-t v2 1/4] scripts/igt_doc.py: fix intelci testlist generation for complex cases Kamil Konieczny
2024-02-22 11:45 ` [PATCH i-g-t v2 2/4] scripts/igt_doc.py: ignore "all" when producing testlists Mauro Carvalho Chehab
2024-02-26 10:58   ` Kamil Konieczny
2024-02-22 11:45 ` [PATCH i-g-t v2 3/4] scripts/igt_doc.py: fix trivial case handling Mauro Carvalho Chehab
2024-02-26 11:04   ` Kamil Konieczny
2024-02-22 11:45 ` [PATCH i-g-t v2 4/4] scripts/igt_doc.py: fix intelci testlist join logic Mauro Carvalho Chehab
2024-02-26 11:06   ` Kamil Konieczny
2024-02-22 12:52 ` ✓ CI.xeBAT: success for Additional fixes for IntelCI testlist generation (rev2) Patchwork
2024-02-22 13:17 ` ✗ Fi.CI.BAT: failure " Patchwork
2024-02-26 11:09   ` Kamil Konieczny
2024-02-28  5:58     ` Illipilli, TejasreeX
2024-02-28  5:56 ` ✓ Fi.CI.BAT: success " Patchwork
2024-02-28 16:00 ` ✗ Fi.CI.IGT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240222114741.196042-2-mauro.chehab@linux.intel.com \
    --to=mauro.chehab@linux.intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox