Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Kamil Konieczny <kamil.konieczny@linux.intel.com>
To: igt-dev@lists.freedesktop.org
Cc: "Kamil Konieczny" <kamil.konieczny@linux.intel.com>,
	"Zbigniew Kempczyński" <zbigniew.kempczynski@intel.com>,
	"Dominik Karol Piątkowski" <dominik.karol.piatkowski@intel.com>,
	"Janusz Krzysztofik" <janusz.krzysztofik@linux.intel.com>
Subject: [PATCH i-g-t v14 5/5] tests/intel/gem_exec_gttfill: simplify multiGPU subtest
Date: Wed, 20 Mar 2024 16:56:59 +0100	[thread overview]
Message-ID: <20240320155659.33518-6-kamil.konieczny@linux.intel.com> (raw)
In-Reply-To: <20240320155659.33518-1-kamil.konieczny@linux.intel.com>

Simplify multi-GPU subtest with the help of new multigpu library.

v10: remove igt_require_multigpu() as it checks filters but we
  want to use legacy opens (Kamil), correct Cc name (Zbigniew)
v14: add missing igt_require_gem() in multigpu-basic (Janusz)

Cc: "Zbigniew Kempczyński" <zbigniew.kempczynski@intel.com>
Cc: "Dominik Karol Piątkowski" <dominik.karol.piatkowski@intel.com>
Cc: Janusz Krzysztofik <janusz.krzysztofik@linux.intel.com>
Signed-off-by: Kamil Konieczny <kamil.konieczny@linux.intel.com>
---
 tests/intel/gem_exec_gttfill.c | 14 ++++----------
 1 file changed, 4 insertions(+), 10 deletions(-)

diff --git a/tests/intel/gem_exec_gttfill.c b/tests/intel/gem_exec_gttfill.c
index b1063437b..d79a6ffd5 100644
--- a/tests/intel/gem_exec_gttfill.c
+++ b/tests/intel/gem_exec_gttfill.c
@@ -24,8 +24,8 @@
 #include "i915/gem.h"
 #include "i915/gem_create.h"
 #include "igt.h"
-#include "igt_device_scan.h"
 #include "igt_rand.h"
+#include "igt_multigpu.h"
 /**
  * TEST: gem exec gttfill
  * Description: Fill the GTT with batches.
@@ -251,7 +251,7 @@ igt_main
 {
 	const struct intel_execution_engine2 *e;
 	const intel_ctx_t *ctx;
-	int i915 = -1, gpu_count;
+	int i915 = -1;
 
 	igt_fixture {
 		i915 = drm_open_driver(DRIVER_INTEL);
@@ -285,17 +285,12 @@ igt_main
 	igt_fixture {
 		igt_stop_hang_detector();
 		intel_ctx_destroy(i915, ctx);
-		// prepare multigpu tests
-		gpu_count = igt_device_filter_count();
 	}
 
 	igt_subtest("multigpu-basic") { /* run on two or more discrete cards */
-		igt_require(gpu_count > 1);
-		igt_multi_fork(child, gpu_count) {
-			int g_fd;
+		igt_multi_fork_foreach_gpu(g_fd, gpu_idx, DRIVER_INTEL) {
 			// prepare
-			g_fd = __drm_open_driver_another(child, DRIVER_INTEL);
-			igt_assert(g_fd >= 0);
+			igt_require_gem(g_fd);
 			ctx = intel_ctx_create_all_physical(g_fd);
 			igt_fork_hang_detector(g_fd);
 			// subtest
@@ -303,7 +298,6 @@ igt_main
 			// release resources
 			igt_stop_hang_detector();
 			intel_ctx_destroy(g_fd, ctx);
-			drm_close_driver(g_fd);
 		}
 
 		igt_waitchildren();
-- 
2.42.0


  parent reply	other threads:[~2024-03-20 15:57 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-20 15:56 [PATCH i-g-t v14 0/5] introduce Xe multigpu and other multi-GPU helpers Kamil Konieczny
2024-03-20 15:56 ` [PATCH i-g-t v14 1/5] lib/igt_device_scan: Introduce filtering out non-PCI devices Kamil Konieczny
2024-03-20 19:47   ` Janusz Krzysztofik
2024-03-20 15:56 ` [PATCH i-g-t v14 2/5] lib/drmtest: Introduced drm_open_driver_another Kamil Konieczny
2024-03-20 19:49   ` Janusz Krzysztofik
2024-03-20 15:56 ` [PATCH i-g-t v14 3/5] lib/igt_multigpu: Introduce library for multi-GPU scenarios Kamil Konieczny
2024-03-20 19:49   ` Janusz Krzysztofik
2024-03-20 15:56 ` [PATCH i-g-t v14 4/5] tests/intel/xe_exec_basic: add multigpu subtests Kamil Konieczny
2024-03-20 19:49   ` Janusz Krzysztofik
2024-03-21 13:07   ` Piatkowski, Dominik Karol
2024-03-20 15:56 ` Kamil Konieczny [this message]
2024-03-20 19:50   ` [PATCH i-g-t v14 5/5] tests/intel/gem_exec_gttfill: simplify multiGPU subtest Janusz Krzysztofik
2024-03-20 18:32 ` ✓ Fi.CI.BAT: success for introduce Xe multigpu and other multi-GPU helpers (rev14) Patchwork
2024-03-20 18:33 ` ✓ CI.xeBAT: " Patchwork
2024-03-20 19:47 ` [PATCH i-g-t v14 0/5] introduce Xe multigpu and other multi-GPU helpers Janusz Krzysztofik
2024-03-21  7:46 ` ✗ Fi.CI.IGT: failure for introduce Xe multigpu and other multi-GPU helpers (rev14) Patchwork
2024-03-21 12:49   ` Kamil Konieczny
2024-03-25 12:52     ` Illipilli, TejasreeX
2024-03-25  8:28 ` ✓ Fi.CI.IGT: success " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240320155659.33518-6-kamil.konieczny@linux.intel.com \
    --to=kamil.konieczny@linux.intel.com \
    --cc=dominik.karol.piatkowski@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=janusz.krzysztofik@linux.intel.com \
    --cc=zbigniew.kempczynski@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox