Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Matt Roper <matthew.d.roper@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: matthew.d.roper@intel.com
Subject: [PATCH i-g-t] tests/xe_exec_threads: Fill in GT field for second balancer thread
Date: Wed, 20 Mar 2024 12:23:56 -0700	[thread overview]
Message-ID: <20240320192356.359327-1-matthew.d.roper@intel.com> (raw)

The balancer subtests spawn two pthreads per engine class if there are
multiple instances of the class.  The GT field of the data structure is
filled in properly for the first thread, but not for the second,
effectively leaving it set to "0."

For platforms with standalone media, this will result in failures when
the thread tries to find the instances of a media class on GT0 and trips
the "igt_assert(num_placements > 1)" assertion in test_balancer().

Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
---
 tests/intel/xe_exec_threads.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tests/intel/xe_exec_threads.c b/tests/intel/xe_exec_threads.c
index 55907e2b3..977e8c600 100644
--- a/tests/intel/xe_exec_threads.c
+++ b/tests/intel/xe_exec_threads.c
@@ -1081,6 +1081,7 @@ static void threads(int fd, int flags)
 						threads_data[i].fd = 0;
 					else
 						threads_data[i].fd = fd;
+					threads_data[i].gt = gt;
 					threads_data[i].vm_legacy_mode =
 						vm_legacy_mode;
 					threads_data[i].class = class;
-- 
2.43.0


             reply	other threads:[~2024-03-20 19:24 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-20 19:23 Matt Roper [this message]
2024-03-20 20:47 ` [PATCH i-g-t] tests/xe_exec_threads: Fill in GT field for second balancer thread Lucas De Marchi
2024-03-21  1:04   ` Matthew Brost
2024-03-21  6:01     ` Lucas De Marchi
2024-03-21 18:43       ` Matthew Brost
2024-03-20 21:02 ` ✓ Fi.CI.BAT: success for " Patchwork
2024-03-20 21:11 ` ✓ CI.xeBAT: " Patchwork
2024-03-20 21:35   ` Matt Roper
2024-03-21  9:14 ` ✗ Fi.CI.IGT: failure " Patchwork
2024-03-21 13:23   ` Kamil Konieczny
2024-03-25  8:54 ` ✓ Fi.CI.IGT: success " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240320192356.359327-1-matthew.d.roper@intel.com \
    --to=matthew.d.roper@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox