From: Alex Hung <alex.hung@amd.com>
To: <igt-dev@lists.freedesktop.org>
Cc: <rodrigo.siqueira@amd.com>, <harry.wentland@amd.com>,
<hersenxs.wu@amd.com>, Alex Hung <alex.hung@amd.com>
Subject: [PATCH 2/2] tests/amdgpu/amd_vrr_range: Skip on unsupported connector types
Date: Wed, 20 Mar 2024 20:03:54 -0600 [thread overview]
Message-ID: <20240321020354.843729-2-alex.hung@amd.com> (raw)
In-Reply-To: <20240321020354.843729-1-alex.hung@amd.com>
edid_database includes a set of EDID but does not includes one with
connector type == DRM_MODE_CONNECTOR_WRITEBACK. With writeback connector
enabled, this will always fail even if writeback connector does not
support freesync. As a result, freesync tests is skipped when there is
no match in edid_database.
Signed-off-by: Alex Hung <alex.hung@amd.com>
---
tests/amdgpu/amd_vrr_range.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tests/amdgpu/amd_vrr_range.c b/tests/amdgpu/amd_vrr_range.c
index a77895622..79db6f9c4 100644
--- a/tests/amdgpu/amd_vrr_range.c
+++ b/tests/amdgpu/amd_vrr_range.c
@@ -208,7 +208,6 @@ static int find_test_edid_index(uint32_t connector_type)
}
}
- igt_assert_f(0, "should not reach here");
return -1;
}
@@ -268,6 +267,8 @@ static void test_freesync_parsing_base(data_t *data, uint32_t test_flags)
for_each_connected_output(display, output) {
/* find a test EDID */
j = find_test_edid_index(output->config.connector->connector_type);
+ if (j == -1)
+ continue;
edid = (const struct edid *)edid_database[j].edid;
expected_range = edid_database[j].range;
--
2.34.1
next prev parent reply other threads:[~2024-03-21 2:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-21 2:03 [PATCH 1/2] lib/amd: check output has hpd before trigger hotplug Alex Hung
2024-03-21 2:03 ` Alex Hung [this message]
2024-03-21 13:59 ` [PATCH 2/2] tests/amdgpu/amd_vrr_range: Skip on unsupported connector types Harry Wentland
2024-03-21 3:30 ` ✓ CI.xeBAT: success for series starting with [1/2] lib/amd: check output has hpd before trigger hotplug Patchwork
2024-03-21 3:42 ` ✓ Fi.CI.BAT: " Patchwork
2024-03-21 13:56 ` [PATCH 1/2] " Harry Wentland
2024-03-22 1:11 ` ✗ Fi.CI.IGT: failure for series starting with [1/2] " Patchwork
2024-03-22 11:10 ` Kamil Konieczny
2024-03-22 3:29 ` ✗ Fi.CI.BAT: failure for series starting with [1/2] lib/amd: check output has hpd before trigger hotplug (rev2) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240321020354.843729-2-alex.hung@amd.com \
--to=alex.hung@amd.com \
--cc=harry.wentland@amd.com \
--cc=hersenxs.wu@amd.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=rodrigo.siqueira@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox