Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Jagmeet Randhawa <jagmeet.randhawa@intel.com>
Cc: igt-dev@lists.freedesktop.org, oak.zeng@intel.com,
	jonathan.cavitt@intel.com, matthew.auld@intel.com,
	kamil.konieczny@linux.intel.com,
	Jagmeet Randhawa <jagmeet.randhawa@intel.com>
Subject: [PATCH i-g-t] tests/intel/xe_vm: Fix WB caching PAT index for coherency mode
Date: Mon, 25 Mar 2024 14:26:59 -0700	[thread overview]
Message-ID: <20240325212700.127810-1-jagmeet.randhawa@intel.com> (raw)

Addressing Oaks comments: So the reason I mentioned COH_MODE
is because for the test failure, we go into the folllowing
if statement and throw an error:

 "if (XE_IOCTL_DBG(xe, coh_mode == XE_COH_NONE &&
     bos[i]->cpu_caching == DRM_XE_GEM_CPU_CACHING_WB)){ 
     err = -EINVAL;
     goto put_obj; }"

We got the failure because
coh_mode = XE_COH_NONE and we wanted to do a DRM_XE_GEM_CPU_CACHING_WB
but in order to do writeback we need atleast 1 way coherency.
COH_MODE is probably set by default to NONE. Which is why we use
"bind.bind.pat_index = intel_get_pat_idx_wb(fd);" to get the correct
COH_MODE which then allowed the test to pass correctly.

Addressing Kamils comments: I have updated the subject
and simplified the description.

Jagmeet Randhawa (1):
  Fix WB caching PAT index for coherency mode

 tests/intel/xe_vm.c | 1 +
 1 file changed, 1 insertion(+)

-- 
2.25.1


             reply	other threads:[~2024-03-25 21:27 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-25 21:26 Jagmeet Randhawa [this message]
2024-03-25 21:27 ` [PATCH i-g-t] tests/intel/xe_vm: Fix WB caching PAT index for coherency mode Jagmeet Randhawa
2024-03-26  7:51   ` Matthew Auld
2024-03-26 10:00     ` Kamil Konieczny
2024-03-26 18:46   ` Zeng, Oak
2024-03-27 18:25     ` Randhawa, Jagmeet
2024-03-25 22:34 ` ✓ CI.xeBAT: success for " Patchwork
2024-03-25 22:47 ` ✓ Fi.CI.BAT: " Patchwork
2024-03-26  4:46 ` ✗ Fi.CI.IGT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240325212700.127810-1-jagmeet.randhawa@intel.com \
    --to=jagmeet.randhawa@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=jonathan.cavitt@intel.com \
    --cc=kamil.konieczny@linux.intel.com \
    --cc=matthew.auld@intel.com \
    --cc=oak.zeng@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox