Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Jouni Högander" <jouni.hogander@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: "Jouni Högander" <jouni.hogander@intel.com>
Subject: [PATCH i-g-t 2/2]  tests/kms_dirtyfb: Ensure PSR is enabled
Date: Tue, 26 Mar 2024 15:20:12 +0200	[thread overview]
Message-ID: <20240326132012.3747302-2-jouni.hogander@intel.com> (raw)
In-Reply-To: <20240326132012.3747302-1-jouni.hogander@intel.com>

In certain cases PSR support is informed, but it doesn't get enabled
due to some limitations. This is causing failures which are actually just
expected behaviour. Fix this by checking PSR is really enabled and skip in
case it is not

Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/9735
Signed-off-by: Jouni Högander <jouni.hogander@intel.com>
---
 tests/intel/kms_dirtyfb.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tests/intel/kms_dirtyfb.c b/tests/intel/kms_dirtyfb.c
index 9e4832929..6121599ec 100644
--- a/tests/intel/kms_dirtyfb.c
+++ b/tests/intel/kms_dirtyfb.c
@@ -151,6 +151,7 @@ static void check_feature(data_t *data)
 			     "FBC still disabled\n");
 		break;
 	case FEATURE_PSR:
+		igt_require(!psr_disabled_check(data->debugfs_fd));
 		igt_assert_f(psr_wait_entry(data->debugfs_fd, PSR_MODE_1, NULL),
 			     "PSR still disabled\n");
 		break;
-- 
2.34.1


  reply	other threads:[~2024-03-26 13:20 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-26 13:20 [PATCH i-g-t 1/2] tests/kms_pm_dc: Ensure PSR is enabled Jouni Högander
2024-03-26 13:20 ` Jouni Högander [this message]
2024-03-27  8:04   ` [PATCH i-g-t 2/2] tests/kms_dirtyfb: " Thasleem, Mohammed
2024-03-26 18:40 ` ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/2] tests/kms_pm_dc: " Patchwork
2024-03-26 18:43 ` ✓ CI.xeBAT: " Patchwork
2024-03-27  6:42 ` [PATCH i-g-t 1/2] " Thasleem, Mohammed
2024-03-28 10:33   ` Hogander, Jouni
2024-03-27  9:52 ` ✓ CI.xeBAT: success for series starting with [i-g-t,1/2] tests/kms_pm_dc: Ensure PSR is enabled (rev2) Patchwork
2024-03-27 10:02 ` ✓ Fi.CI.BAT: " Patchwork
2024-03-27 14:21 ` ✗ Fi.CI.IGT: failure for series starting with [i-g-t,1/2] tests/kms_pm_dc: Ensure PSR is enabled Patchwork
2024-03-28  2:20 ` ✗ Fi.CI.IGT: failure for series starting with [i-g-t,1/2] tests/kms_pm_dc: Ensure PSR is enabled (rev2) Patchwork
2024-03-28 10:24   ` Hogander, Jouni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240326132012.3747302-2-jouni.hogander@intel.com \
    --to=jouni.hogander@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox