Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Nirmoy Das <nirmoy.das@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: Nirmoy Das <nirmoy.das@intel.com>,
	Janga Rahul Kumar <janga.rahul.kumar@intel.com>
Subject: [PATCH i-g-t] tests/intel/xe_compute_preempt: Run it on only CCS engine
Date: Thu,  4 Apr 2024 12:29:01 +0200	[thread overview]
Message-ID: <20240404102901.18803-1-nirmoy.das@intel.com> (raw)

Expectation is that mid thread preemption works on CCS and
RCS is optional. In future we should check with engine capability
when that such uAPI is supported by the KMD.

Cc: Janga Rahul Kumar <janga.rahul.kumar@intel.com>
Signed-off-by: Nirmoy Das <nirmoy.das@intel.com>
---
 tests/intel/xe_compute_preempt.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/tests/intel/xe_compute_preempt.c b/tests/intel/xe_compute_preempt.c
index b8448ef91..78b19158d 100644
--- a/tests/intel/xe_compute_preempt.c
+++ b/tests/intel/xe_compute_preempt.c
@@ -49,8 +49,7 @@ igt_main
 
 	igt_subtest_with_dynamic("compute-preempt") {
 		xe_for_each_engine(xe, hwe) {
-			if (hwe->engine_class != DRM_XE_ENGINE_CLASS_COMPUTE &&
-			    hwe->engine_class != DRM_XE_ENGINE_CLASS_RENDER)
+			if (hwe->engine_class != DRM_XE_ENGINE_CLASS_COMPUTE)
 				continue;
 
 			igt_dynamic_f("engine-%s", xe_engine_class_string(hwe->engine_class))
@@ -60,7 +59,6 @@ igt_main
 
 	igt_subtest_with_dynamic("compute-preempt-many") {
 		xe_for_each_engine(xe, hwe) {
-			/* TODO: This subtest fails on RCS engine */
 			if (hwe->engine_class != DRM_XE_ENGINE_CLASS_COMPUTE)
 				continue;
 
@@ -74,8 +72,7 @@ igt_main
 
 	igt_subtest_with_dynamic("compute-threadgroup-preempt") {
 		xe_for_each_engine(xe, hwe) {
-			if (hwe->engine_class != DRM_XE_ENGINE_CLASS_COMPUTE &&
-			    hwe->engine_class != DRM_XE_ENGINE_CLASS_RENDER)
+			if (hwe->engine_class != DRM_XE_ENGINE_CLASS_COMPUTE)
 				continue;
 
 			igt_dynamic_f("engine-%s", xe_engine_class_string(hwe->engine_class))
-- 
2.42.0


             reply	other threads:[~2024-04-04 10:43 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-04 10:29 Nirmoy Das [this message]
2024-04-04 11:55 ` ✓ CI.xeBAT: success for tests/intel/xe_compute_preempt: Run it on only CCS engine Patchwork
2024-04-04 12:12 ` ✓ Fi.CI.BAT: " Patchwork
2024-04-05 11:24 ` ✗ Fi.CI.IGT: failure " Patchwork
2024-04-09  8:56   ` Kamil Konieczny
2024-04-05 17:15 ` [PATCH i-g-t] " Lucas De Marchi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240404102901.18803-1-nirmoy.das@intel.com \
    --to=nirmoy.das@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=janga.rahul.kumar@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox