From: Lucas De Marchi <lucas.demarchi@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: Tvrtko Ursulin <tursulin@ursulin.net>,
Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>,
Lucas De Marchi <lucas.demarchi@intel.com>
Subject: [PATCH i-g-t 08/12] lib/igt_drm_fdinfo: Store 2 counters for "ticks" unit
Date: Fri, 5 Apr 2024 01:00:52 -0500 [thread overview]
Message-ID: <20240405060056.59379-9-lucas.demarchi@intel.com> (raw)
In-Reply-To: <20240405060056.59379-1-lucas.demarchi@intel.com>
When using "ticks" as the unit for engine busyness, 2 counters are
expected. Add the second counter and store it inside the info, together
with the unit.
Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
---
lib/igt_drm_fdinfo.c | 39 ++++++++++++++++++++++++++++-----------
lib/igt_drm_fdinfo.h | 7 +++++++
2 files changed, 35 insertions(+), 11 deletions(-)
diff --git a/lib/igt_drm_fdinfo.c b/lib/igt_drm_fdinfo.c
index 1541a62c9..12da1d699 100644
--- a/lib/igt_drm_fdinfo.c
+++ b/lib/igt_drm_fdinfo.c
@@ -63,7 +63,7 @@ static const char *ignore_space(const char *s)
static int parse_engine(const char *name, struct drm_client_fdinfo *info,
const char **name_map, unsigned int map_entries,
- uint64_t *val, const char **unit)
+ uint64_t *val, uint64_t *val2, const char **unit)
{
const char *p;
char *end_ptr;
@@ -111,6 +111,11 @@ static int parse_engine(const char *name, struct drm_client_fdinfo *info,
if (p == end_ptr)
return -1;
+ if (val2) {
+ p = end_ptr;
+ *val2 = strtoull(p, &end_ptr, 10);
+ }
+
if (unit)
*unit = end_ptr;
@@ -218,7 +223,7 @@ __igt_parse_drm_fdinfo(int dir, const char *fd, struct drm_client_fdinfo *info,
return 0;
while ((l = strtok_r(_buf, "\n", &ctx))) {
- uint64_t val = 0;
+ uint64_t val = 0, val2 = 0;
size_t keylen;
const char *v, *unit;
char *end_ptr;
@@ -245,21 +250,33 @@ __igt_parse_drm_fdinfo(int dir, const char *fd, struct drm_client_fdinfo *info,
strncpy(info->pdev, v, sizeof(info->pdev) - 1);
} else if (strstartswith(l, "drm-engine-capacity-", &keylen)) {
idx = parse_engine(l + keylen, info,
- name_map, map_entries, &val, NULL);
+ name_map, map_entries, &val, NULL, NULL);
if (idx >= 0) {
info->capacity[idx] = val;
num_capacity++;
}
} else if (strstartswith(l, "drm-engine-", &keylen)) {
idx = parse_engine(l + keylen, info,
- name_map, map_entries, &val, &unit);
- if (idx >= 0 && !strcmp(unit, " ns")) {
- if (!info->capacity[idx])
- info->capacity[idx] = 1;
- info->busy[idx] = val;
- info->num_engines++;
- if (idx > info->last_engine_index)
- info->last_engine_index = idx;
+ name_map, map_entries, &val, &val2, &unit);
+ if (idx >= 0) {
+ if (!strcmp(unit, " ns")) {
+ if (!info->capacity[idx])
+ info->capacity[idx] = 1;
+ info->busy[idx] = val;
+ info->unit[idx] = DRM_CLIENT_ENGINE_UNIT_NS;
+ info->num_engines++;
+ if (idx > info->last_engine_index)
+ info->last_engine_index = idx;
+ } else if (!strcmp(unit, " ticks")) {
+ if (!info->capacity[idx])
+ info->capacity[idx] = 1;
+ info->busy[idx] = val;
+ info->busy2[idx] = val2;
+ info->unit[idx] = DRM_CLIENT_ENGINE_UNIT_TICKS;
+ info->num_engines++;
+ if (idx > info->last_engine_index)
+ info->last_engine_index = idx;
+ }
}
} else if (strstartswith(l, "drm-total-", &keylen)) {
idx = parse_region(l + keylen, info,
diff --git a/lib/igt_drm_fdinfo.h b/lib/igt_drm_fdinfo.h
index 1999c4f2b..7f5bafd2a 100644
--- a/lib/igt_drm_fdinfo.h
+++ b/lib/igt_drm_fdinfo.h
@@ -41,6 +41,11 @@ struct drm_client_meminfo {
uint64_t active;
};
+enum drm_client_engine_unit {
+ DRM_CLIENT_ENGINE_UNIT_NS = 0,
+ DRM_CLIENT_ENGINE_UNIT_TICKS,
+};
+
struct drm_client_fdinfo {
char driver[128];
char pdev[128];
@@ -51,6 +56,8 @@ struct drm_client_fdinfo {
unsigned int capacity[DRM_CLIENT_FDINFO_MAX_ENGINES];
char names[DRM_CLIENT_FDINFO_MAX_ENGINES][256];
uint64_t busy[DRM_CLIENT_FDINFO_MAX_ENGINES];
+ uint64_t busy2[DRM_CLIENT_FDINFO_MAX_ENGINES];
+ uint8_t unit[DRM_CLIENT_FDINFO_MAX_ENGINES];
unsigned int num_regions;
unsigned int last_region_index;
--
2.44.0
next prev parent reply other threads:[~2024-04-05 6:01 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-05 6:00 [PATCH i-g-t 00/12] gputop: Add support for xe Lucas De Marchi
2024-04-05 6:00 ` [PATCH i-g-t 01/12] lib/igt_drm_fdinfo: Stop passing key twice Lucas De Marchi
2024-04-18 22:14 ` Umesh Nerlige Ramappa
2024-04-19 7:42 ` Tvrtko Ursulin
2024-04-19 16:35 ` Lucas De Marchi
2024-04-19 18:34 ` Tvrtko Ursulin
2024-04-05 6:00 ` [PATCH i-g-t 02/12] lib/igt_drm_fdinfo: Remove prefix arg from parse functions Lucas De Marchi
2024-04-05 6:00 ` [PATCH i-g-t 03/12] lib/igt_drm_fdinfo: Fix wrong name len assert Lucas De Marchi
2024-04-18 22:25 ` Umesh Nerlige Ramappa
2024-04-19 7:48 ` Tvrtko Ursulin
2024-04-19 7:49 ` Tvrtko Ursulin
2024-04-05 6:00 ` [PATCH i-g-t 04/12] lib/igt_drm_fdinfo: Assert pdev is not truncated Lucas De Marchi
2024-04-18 22:27 ` Umesh Nerlige Ramappa
2024-04-05 6:00 ` [PATCH i-g-t 05/12] lib/igt_drm_fdinfo: Detect invalid drm-client-id Lucas De Marchi
2024-04-18 22:31 ` Umesh Nerlige Ramappa
2024-04-05 6:00 ` [PATCH i-g-t 06/12] lib/igt_drm_fdinfo: Stop ignoring space where not needed Lucas De Marchi
2024-04-18 22:34 ` Umesh Nerlige Ramappa
2024-04-05 6:00 ` [PATCH i-g-t 07/12] lib/igt_drm_fdinfo: Parse unit for engine utilization Lucas De Marchi
2024-04-18 22:48 ` Umesh Nerlige Ramappa
2024-04-19 7:58 ` Tvrtko Ursulin
2024-04-19 16:21 ` Lucas De Marchi
2024-04-19 18:32 ` Tvrtko Ursulin
2024-04-05 6:00 ` Lucas De Marchi [this message]
2024-04-05 6:00 ` [PATCH i-g-t 09/12] lib/igt_drm_clients: Store second data for ticks busyness Lucas De Marchi
2024-04-05 6:00 ` [PATCH i-g-t 10/12] gputop: Extract method to update console size Lucas De Marchi
2024-04-18 22:51 ` Umesh Nerlige Ramappa
2024-04-05 6:00 ` [PATCH i-g-t 11/12] gputop: Extract clrscr() Lucas De Marchi
2024-04-18 22:52 ` Umesh Nerlige Ramappa
2024-04-05 6:00 ` [PATCH i-g-t 12/12] RFC: gputop: Add support for ticks unit Lucas De Marchi
2024-04-05 8:04 ` ✗ GitLab.Pipeline: warning for gputop: Add support for xe Patchwork
2024-04-05 8:17 ` ✓ CI.xeBAT: success " Patchwork
2024-04-05 8:27 ` ✓ Fi.CI.BAT: " Patchwork
2024-04-05 16:22 ` ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240405060056.59379-9-lucas.demarchi@intel.com \
--to=lucas.demarchi@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=tursulin@ursulin.net \
--cc=umesh.nerlige.ramappa@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox