From: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
Subject: [PATCH i-g-t 1/5] lib/igt_kms: Check validity of the selcted pipe/output combo
Date: Mon, 8 Apr 2024 11:42:17 +0530 [thread overview]
Message-ID: <20240408061221.291523-2-bhanuprakash.modem@intel.com> (raw)
In-Reply-To: <20240408061221.291523-1-bhanuprakash.modem@intel.com>
Add a check to identify the selcted pipe/output combination is
valid or not.
Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
lib/igt_kms.c | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/lib/igt_kms.c b/lib/igt_kms.c
index 2a518eb8d..8eb3b877c 100644
--- a/lib/igt_kms.c
+++ b/lib/igt_kms.c
@@ -6347,18 +6347,21 @@ bool intel_pipe_output_combo_valid(igt_display_t *display)
int combo = 0;
igt_output_t *output;
- if (!is_intel_device(display->drm_fd))
- return true;
-
for_each_connected_output(display, output) {
if (output->pending_pipe == PIPE_NONE)
continue;
+ if (!igt_pipe_connector_valid(output->pending_pipe, output))
+ return false;
+
combo++;
}
igt_assert_f(combo, "At least one pipe/output combo needed.\n");
+ if (!is_intel_device(display->drm_fd))
+ return true;
+
/*
* Check the given pipe/output combo is valid for Bigjoiner.
*
--
2.43.2
next prev parent reply other threads:[~2024-04-08 6:18 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-08 6:12 [PATCH i-g-t 0/5] Check the validity of selected pipe/output combo Bhanuprakash Modem
2024-04-08 6:12 ` Bhanuprakash Modem [this message]
2024-06-12 11:19 ` [PATCH i-g-t 1/5] lib/igt_kms: Check validity of the selcted " B, Jeevan
2024-04-08 6:12 ` [PATCH i-g-t 2/5] tests/kms: Drop redundant check for pipe/output combo validity Bhanuprakash Modem
2024-06-12 12:11 ` B, Jeevan
2024-04-08 6:12 ` [PATCH i-g-t 3/5] tests/chamelium: Use lib helper to check the " Bhanuprakash Modem
2024-06-12 12:13 ` B, Jeevan
2024-04-08 6:12 ` [PATCH i-g-t 4/5] tests/intel/kms: " Bhanuprakash Modem
2024-06-12 12:15 ` B, Jeevan
2024-04-08 6:12 ` [PATCH i-g-t 5/5] tests/kms: " Bhanuprakash Modem
2024-06-14 5:45 ` B, Jeevan
2024-04-09 1:34 ` ✓ CI.xeBAT: success for Check the validity of selected pipe/output combo Patchwork
2024-04-09 1:53 ` ✗ Fi.CI.BAT: failure " Patchwork
2024-04-09 2:55 ` ✓ Fi.CI.BAT: success for Check the validity of selected pipe/output combo (rev2) Patchwork
2024-04-09 2:55 ` ✓ CI.xeBAT: " Patchwork
2024-04-10 14:25 ` ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240408061221.291523-2-bhanuprakash.modem@intel.com \
--to=bhanuprakash.modem@intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox