Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Matthew Brost <matthew.brost@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: Matthew Brost <matthew.brost@intel.com>,
	Jonathan Cavitt <jonathan.cavitt@intel.com>
Subject: [PATCH 1/2] Revert "tests/intel/xe_vm: Do not error on -ECANCELED"
Date: Thu, 11 Apr 2024 21:18:40 -0700	[thread overview]
Message-ID: <20240412041841.491326-1-matthew.brost@intel.com> (raw)

The test should never unbind an address used by hammer thread nor should
the exec queue in the hammer thread get banned.

This reverts commit 81462e71323ae6764d7f509f4a1bbd3e41aab13e.

Cc: Jonathan Cavitt <jonathan.cavitt@intel.com>
Signed-off-by: Matthew Brost <matthew.brost@intel.com>
Acked-by: Jonathan Cavitt <jonathan.cavitt@intel.com>
---
 tests/intel/xe_vm.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/tests/intel/xe_vm.c b/tests/intel/xe_vm.c
index ecb2a783c4..bd4973cc38 100644
--- a/tests/intel/xe_vm.c
+++ b/tests/intel/xe_vm.c
@@ -1126,7 +1126,6 @@ static void *hammer_thread(void *tdata)
 	uint32_t exec_queue = xe_exec_queue_create(t->fd, t->vm, t->eci, 0);
 	int b;
 	int i = 0;
-	int err = 0;
 
 	sync[0].handle = syncobj_create(t->fd, 0);
 	pthread_barrier_wait(t->barrier);
@@ -1149,15 +1148,14 @@ static void *hammer_thread(void *tdata)
 		exec.address = batch_addr;
 		if (i % 32) {
 			exec.num_syncs = 0;
-			err = __xe_exec(t->fd, &exec);
+			xe_exec(t->fd, &exec);
 		} else {
 			exec.num_syncs = 1;
-			err = __xe_exec(t->fd, &exec);
+			xe_exec(t->fd, &exec);
 			igt_assert(syncobj_wait(t->fd, &sync[0].handle, 1,
 						INT64_MAX, 0, NULL));
 			syncobj_reset(t->fd, &sync[0].handle, 1);
 		}
-		igt_assert(!err || err == -ECANCELED);
 		++i;
 	}
 
-- 
2.34.1


             reply	other threads:[~2024-04-12  4:18 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-12  4:18 Matthew Brost [this message]
2024-04-12  4:18 ` [PATCH 2/2] tests/intel/xe_vm: Always have at least 2 pages bound in munmap hammer sections Matthew Brost
2024-04-12 18:16   ` Randhawa, Jagmeet
2024-04-12 18:28     ` [2/2] " Jonathan Cavitt
2024-04-12  4:51 ` ✓ CI.xeBAT: success for series starting with [1/2] Revert "tests/intel/xe_vm: Do not error on -ECANCELED" Patchwork
2024-04-12  4:59 ` ✓ Fi.CI.BAT: " Patchwork
2024-04-12 11:17 ` ✗ CI.xeFULL: failure " Patchwork
2024-04-12 12:04 ` ✗ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240412041841.491326-1-matthew.brost@intel.com \
    --to=matthew.brost@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=jonathan.cavitt@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox