From: nakshtra.goyal@intel.com
To: igt-dev@lists.freedesktop.org, ramadevi.gandi@intel.com
Cc: janga.rahul.kumar@intel.com, himal.prasad.ghimiray@intel.com,
priyanka.dandamudi@intel.com, kamil.konieczny@intel.com
Subject: [PATCH v3 i-g-t] tests/intel/xe_sysfs_defaults: Validate for all default values
Date: Fri, 12 Apr 2024 15:55:45 +0530 [thread overview]
Message-ID: <20240412102545.3931935-1-nakshtra.goyal@intel.com> (raw)
From: Nakshtra Goyal <nakshtra.goyal@intel.com>
Change in igt_assert_f function parameters so that it also validate for
property value equals to 0.
v2: use uint64_t for property_value,use bool __igt_sysfs_get_u64 in
igt_assert_f(Kamil)
v3: correcting format type for property value in igt_debug in test_defaults
function for uint64_t type(Kamil)
Cc: Himal Prasad Ghimiray <himal.prasad.ghimiray@intel.com>
Cc: Janga Rahul Kumar <janga.rahul.kumar@intel.com>
Cc: Priyanka Dandamudi <priyanka.dandamudi@intel.com>
Cc: Kamil Konieczny <kamil.konieczny@intel.com>
Signed-off-by: Nakshtra Goyal <nakshtra.goyal@intel.com>
Reviewed-by: Kamil Konieczny <kamil.konieczny@linux.intel.com>
Reviewed-by: Janga Rahul Kumar <janga.rahul.kumar@intel.com>
Reviewed-by: Priyanka Dandamudi <priyanka.dandamudi@intel.com>
---
tests/intel/xe_sysfs_defaults.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/tests/intel/xe_sysfs_defaults.c b/tests/intel/xe_sysfs_defaults.c
index b1ab36589..fd7dea77b 100644
--- a/tests/intel/xe_sysfs_defaults.c
+++ b/tests/intel/xe_sysfs_defaults.c
@@ -28,7 +28,7 @@
static void test_defaults(int xe, int engine, const char **property)
{
struct dirent *de;
- int property_value;
+ uint64_t property_value;
int defaults;
DIR *dir;
@@ -42,10 +42,10 @@ static void test_defaults(int xe, int engine, const char **property)
igt_debug("Checking attr '%s'\n", de->d_name);
- igt_assert_f(property_value = igt_sysfs_get_u64(defaults, de->d_name),
+ igt_assert_f(__igt_sysfs_get_u64(defaults, de->d_name, &property_value),
"Default value %s is not present!\n", de->d_name);
- igt_debug("Default property:%s, value:%d\n", de->d_name, property_value);
+ igt_debug("Default property:%s, value:0x%" PRId64 "\n", de->d_name, property_value);
igt_assert_f(!igt_sysfs_set(defaults, de->d_name, "garbage"),
"write into default value of %s succeeded!\n",
--
2.34.1
next reply other threads:[~2024-04-12 10:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-12 10:25 nakshtra.goyal [this message]
2024-04-16 5:43 ` ✓ CI.xeBAT: success for tests/intel/xe_sysfs_defaults: Validate for all default values (rev3) Patchwork
2024-04-16 5:46 ` ✗ Fi.CI.BAT: failure " Patchwork
2024-04-16 23:45 ` ✗ CI.xeFULL: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240412102545.3931935-1-nakshtra.goyal@intel.com \
--to=nakshtra.goyal@intel.com \
--cc=himal.prasad.ghimiray@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=janga.rahul.kumar@intel.com \
--cc=kamil.konieczny@intel.com \
--cc=priyanka.dandamudi@intel.com \
--cc=ramadevi.gandi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox