Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Nirmoy Das <nirmoy.das@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: Nirmoy Das <nirmoy.das@intel.com>
Subject: [PATCH i-g-t v3 3/4] tests/intel/xe_exec_atomic: Use new vm bind flag
Date: Mon, 15 Apr 2024 16:35:27 +0200	[thread overview]
Message-ID: <20240415143528.4107-4-nirmoy.das@intel.com> (raw)
In-Reply-To: <20240415143528.4107-1-nirmoy.das@intel.com>

Use new vm bind flag to probe device atomics support.

Signed-off-by: Nirmoy Das <nirmoy.das@intel.com>
---
 tests/intel/xe_exec_atomic.c | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/tests/intel/xe_exec_atomic.c b/tests/intel/xe_exec_atomic.c
index d9790da78..458539335 100644
--- a/tests/intel/xe_exec_atomic.c
+++ b/tests/intel/xe_exec_atomic.c
@@ -85,7 +85,8 @@ static void basic_inst(int fd, int inst_type, struct drm_xe_engine_class_instanc
 
 	exec_queue = xe_exec_queue_create(fd, vm, eci, 0);
 	bind_engine = xe_bind_exec_queue_create(fd, vm, 0);
-	xe_vm_bind_async(fd, vm, bind_engine, bo, 0, addr, bo_size, &sync, 1);
+	xe_vm_bind_async_flags(fd, vm, bind_engine, bo, 0, addr, bo_size,
+			       &sync, 1, DRM_XE_VM_BIND_FLAG_DEVICE_ATOMICS);
 	data = xe_bo_mmap_ext(fd, bo, bo_size, PROT_READ|PROT_WRITE);
 	data->data = value;
 
@@ -112,8 +113,11 @@ static void basic_inst(int fd, int inst_type, struct drm_xe_engine_class_instanc
 
 static bool has_atomics(int fd, uint32_t region)
 {
-	/* System memory atomics on dGPU is not functional as of now */
-	if (region == system_memory(fd) && xe_has_vram(fd))
+	struct drm_xe_query_config *config = xe_config(fd);
+
+	if (region == system_memory(fd) &&
+	    !(config->info[DRM_XE_QUERY_CONFIG_FLAGS] &
+	     DRM_XE_QUERY_CONFIG_FLAG_HAS_DEV_ATOMIC_ON_SMEM))
 		return false;
 
 	return true;
-- 
2.42.0


  parent reply	other threads:[~2024-04-15 14:49 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-15 14:35 [PATCH i-g-t v3 0/4] Update for atomics related uAPI changes Nirmoy Das
2024-04-15 14:35 ` [PATCH i-g-t v3 1/4] drm-uapi/xe: Add device atomics vm bind flags Nirmoy Das
2024-04-15 14:35 ` [PATCH i-g-t v3 2/4] drm-uapi/xe: Add query flag for dev atomics on SMEM Nirmoy Das
2024-04-15 14:35 ` Nirmoy Das [this message]
2024-04-16  9:39   ` [PATCH i-g-t v3 3/4] tests/intel/xe_exec_atomic: Use new vm bind flag Kumar, Janga Rahul
2024-04-15 14:35 ` [PATCH i-g-t v3 4/4] test/intel/xe_query: Print DRM_XE_QUERY_CONFIG_FLAG_HAS_DEV_ATOMIC_ON_SMEM Nirmoy Das
2024-04-16  9:35   ` Kumar, Janga Rahul
2024-04-16  7:15 ` ✓ Fi.CI.BAT: success for Update for atomics related uAPI changes Patchwork
2024-04-16  7:26 ` ✗ CI.xeBAT: failure " Patchwork
2024-04-16 18:12 ` ✓ Fi.CI.IGT: success " Patchwork
2024-04-17  3:27 ` ✗ CI.xeFULL: failure " Patchwork
2024-04-17 10:09   ` Kamil Konieczny

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240415143528.4107-4-nirmoy.das@intel.com \
    --to=nirmoy.das@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox