From: Ville Syrjala <ville.syrjala@linux.intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [PATCH i-g-t] tools/intel_reg: Fix mchbar register write
Date: Thu, 18 Apr 2024 14:26:33 +0300 [thread overview]
Message-ID: <20240418112633.2423-1-ville.syrjala@linux.intel.com> (raw)
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
I somehow lost the write part of the mchbar register support.
Add it back so that we can also write mchbar registers without
having to remember the address of the mirror range.
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
tools/intel_reg.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/tools/intel_reg.c b/tools/intel_reg.c
index 6c37e14d127d..aae5a23956b9 100644
--- a/tools/intel_reg.c
+++ b/tools/intel_reg.c
@@ -586,6 +586,7 @@ static int write_register(struct config *config, struct reg *reg, uint32_t val)
}
switch (reg->port_desc.port) {
+ case PORT_MCHBAR_32:
case PORT_MMIO_32:
if (reg->engine) {
register_srm(config, reg, &val);
@@ -593,6 +594,7 @@ static int write_register(struct config *config, struct reg *reg, uint32_t val)
OUTREG(reg->mmio_offset + reg->addr, val);
}
break;
+ case PORT_MCHBAR_16:
case PORT_MMIO_16:
if (val > 0xffff) {
fprintf(stderr, "value 0x%08x out of range for port %s\n",
@@ -601,6 +603,7 @@ static int write_register(struct config *config, struct reg *reg, uint32_t val)
}
OUTREG16(reg->mmio_offset + reg->addr, val);
break;
+ case PORT_MCHBAR_8:
case PORT_MMIO_8:
if (val > 0xff) {
fprintf(stderr, "value 0x%08x out of range for port %s\n",
--
2.43.2
next reply other threads:[~2024-04-18 11:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-18 11:26 Ville Syrjala [this message]
2024-04-18 11:44 ` [PATCH i-g-t] tools/intel_reg: Fix mchbar register write Jani Nikula
2024-04-18 20:50 ` ✗ Fi.CI.BAT: failure for " Patchwork
2024-04-19 14:13 ` Kamil Konieczny
2024-04-25 11:07 ` Illipilli, TejasreeX
2024-04-18 21:07 ` ✓ CI.xeBAT: success " Patchwork
2024-04-25 9:57 ` ✓ Fi.CI.BAT: " Patchwork
2024-04-25 15:32 ` ✗ Fi.CI.IGT: failure " Patchwork
2024-04-25 16:42 ` Kamil Konieczny
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240418112633.2423-1-ville.syrjala@linux.intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox