Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Mauro Carvalho Chehab <mauro.chehab@linux.intel.com>
To: Katarzyna Piecielska <katarzyna.piecielska@intel.com>
Cc: igt-dev@lists.freedesktop.org,
	Kamil Konieczny <kamil.konieczny@intel.com>,
	Jari Tahvanainen <jari.tahvanainen@intel.com>
Subject: Re: [PATCH i-g-t 1/1] tests/intel: Put "Run type" highest in documentation hierarchy
Date: Mon, 22 Apr 2024 09:59:41 +0200	[thread overview]
Message-ID: <20240422095941.5a3c08c2@maurocar-mobl2> (raw)
In-Reply-To: <20240417111324.3231762-2-katarzyna.piecielska@intel.com>

On Wed, 17 Apr 2024 11:13:24 +0000
Katarzyna Piecielska <katarzyna.piecielska@intel.com> wrote:

> Let's put "Run type" at highest place in documentation hierarchy. It
> will be reflected in html generated documentation.

If this works best for validation leaders, it works for me.

You should likely do the same also for KMS and i915, having all
using the same basic hierarchy.

Once you add KMS and i915 patches, feel free to add:
	Acked-by: Mauro Carvalho Chehab <mauro.chehab@linux.intel.com>

To the patch(es).

Regards,
Mauro

> 
> Signed-off-by: Katarzyna Piecielska <katarzyna.piecielska@intel.com>
> Cc: Kamil Konieczny <kamil.konieczny@intel.com>
> Cc: Jari Tahvanainen <jari.tahvanainen@intel.com>
> Cc: Mauro Carvalho Chehab <mauro.chehab@linux.intel.com>
> ---
>  tests/intel/xe_test_config.json | 66 ++++++++++++++++-----------------
>  1 file changed, 33 insertions(+), 33 deletions(-)
> 
> diff --git a/tests/intel/xe_test_config.json b/tests/intel/xe_test_config.json
> index 22b43ffac..f88883414 100644
> --- a/tests/intel/xe_test_config.json
> +++ b/tests/intel/xe_test_config.json
> @@ -4,51 +4,51 @@
>      "drivers": [ "xe" ],
>      "files": [ "xe_*.c", "../core_hotunplug.c", "../sriov_basic.c", "intel_hwmon.c" ],
>      "fields": {
> -        "Category": {
> +        "Run type": {
>              "_properties_": {
>                  "mandatory": true,
> -                "description": "Contains the major group for the tested functionality, being hardware, software or firmware"
> +                "description": "Defines what category of testlist it belongs",
> +                "default-testlist": "FULL",
> +                "update-from-file": {
> +                    "exclude-type": "regex-ignorecase",
> +                    "append-value-if-not-excluded": "Xe FULL",
> +                    "include": [
> +                        { "Xe BAT": "../intel-ci/xe-fast-feedback.testlist" }
> +                    ],
> +                    "exclude": [
> +                        { "Xe BAT, Xe FULL": "../intel-ci/xe.blocklist.txt" }
> +                    ]
> +                },
> +                "order": [
> +                    "boot",
> +                    "__all__",
> +                    "kunit"
> +                ]
>              },
> -            "Mega feature": {
> +            "Category": {
>                  "_properties_": {
> -                    "description": "Contains the mega feature for end to end use case, e. g. the 'sellable' feature."
> +                    "mandatory": true,
> +                    "description": "Contains the major group for the tested functionality, being hardware, software or firmware"
>                  },
> -                "Sub-category": {
> +                "Mega feature": {
>                      "_properties_": {
> -                        "mandatory": true,
> -                        "description": "Contains the the technical feature/functionality"
> +                        "description": "Contains the mega feature for end to end use case, e. g. the 'sellable' feature."
>                      },
> -                    "Functionality": {
> +                    "Sub-category": {
>                          "_properties_": {
>                              "mandatory": true,
> -                            "description": "Groups page table tests on buckets containg more detailed functionality"
> +                            "description": "Contains the technical feature/functionality"
>                          },
> -                        "Feature": {
> +                        "Functionality": {
>                              "_properties_": {
> -                                "description": "Describes the lowest level feature bucket"
> -                            }
> -                        }
> -                    },
> -                    "Run type": {
> -                        "_properties_": {
> -                            "mandatory": true,
> -                            "description": "Defines what category of testlist it belongs",
> -                            "default-testlist": "FULL",
> -                            "update-from-file": {
> -                                "exclude-type": "regex-ignorecase",
> -                                "append-value-if-not-excluded": "Xe FULL",
> -                                "include": [
> -                                    { "Xe BAT": "../intel-ci/xe-fast-feedback.testlist" }
> -                                ],
> -                                "exclude": [
> -                                    { "Xe BAT, Xe FULL": "../intel-ci/xe.blocklist.txt" }
> -                                ]
> +                                "mandatory": true,
> +                                "description": "Groups page table tests on buckets containg more detailed functionality"
>                              },
> -                            "order": [
> -                                "boot",
> -                                "__all__",
> -                                "kunit"
> -                            ]
> +                            "Feature": {
> +                                "_properties_": {
> +                                    "description": "Describes the lowest level feature bucket"
> +                                }
> +                            }
>                          }
>                      }
>                  }

  parent reply	other threads:[~2024-04-22  7:59 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-17 11:13 [PATCH i-g-t 0/1] Put "Run type" highest in documentation hierarchy Katarzyna Piecielska
2024-04-17 11:13 ` [PATCH i-g-t 1/1] tests/intel: " Katarzyna Piecielska
2024-04-17 16:14   ` Kamil Konieczny
2024-04-22  7:59   ` Mauro Carvalho Chehab [this message]
2024-04-17 13:32 ` ✗ CI.xeBAT: failure for " Patchwork
2024-04-17 13:34 ` ✓ Fi.CI.BAT: success " Patchwork
2024-04-18  1:52 ` ✗ Fi.CI.IGT: failure " Patchwork
2024-04-19 14:12   ` Kamil Konieczny
2024-04-18 22:40 ` ✓ CI.xeFULL: success " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240422095941.5a3c08c2@maurocar-mobl2 \
    --to=mauro.chehab@linux.intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=jari.tahvanainen@intel.com \
    --cc=kamil.konieczny@intel.com \
    --cc=katarzyna.piecielska@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox