Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Zbigniew Kempczyński" <zbigniew.kempczynski@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: "Zbigniew Kempczyński" <zbigniew.kempczynski@intel.com>,
	"Dominik Grzegorzek" <dominik.grzegorzek@intel.com>
Subject: [PATCH i-g-t 1/2] lib/rendercopy: Fix horizontal stride
Date: Tue, 23 Apr 2024 09:04:48 +0200	[thread overview]
Message-ID: <20240423070449.150518-2-zbigniew.kempczynski@intel.com> (raw)
In-Reply-To: <20240423070449.150518-1-zbigniew.kempczynski@intel.com>

According to regioning spec horizontal stride must be 0. There's
no functional change in render-copy execution on hardware.

Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
Cc: Dominik Grzegorzek <dominik.grzegorzek@intel.com>
---
 lib/i915/shaders/ps/gen20_render_copy.asm | 8 ++++----
 lib/rendercopy_gen9.c                     | 8 ++++----
 2 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/lib/i915/shaders/ps/gen20_render_copy.asm b/lib/i915/shaders/ps/gen20_render_copy.asm
index 48057f441e..c4e12a3687 100644
--- a/lib/i915/shaders/ps/gen20_render_copy.asm
+++ b/lib/i915/shaders/ps/gen20_render_copy.asm
@@ -1,8 +1,8 @@
 L0:
-(W)     mad (16|M0)              acc0.0<1>:f   r6.0<0;0>:f      r1.0<1;1>:f       r6.6<0>:f
-(W)     mad (16|M0)              r113.0<1>:f   acc0.0<1;1>:f    r1.0<1;1>:f       r6.1<0>:f
-(W)     mad (16|M0)              acc0.0<1>:f   r6.3<0;0>:f      r1.0<1;1>:f       r6.4<0>:f
-(W)     mad (16|M0)              r114.0<1>:f   acc0.0<1;1>:f    r2.0<1;1>:f       r6.5<0>:f
+(W)     mad (16|M0)              acc0.0<1>:f   r6.0<0;0>:f      r1.0<1;0>:f       r6.6<0>:f
+(W)     mad (16|M0)              r113.0<1>:f   acc0.0<1;0>:f    r1.0<1;0>:f       r6.1<0>:f
+(W)     mad (16|M0)              acc0.0<1>:f   r6.3<0;0>:f      r1.0<1;0>:f       r6.4<0>:f
+(W)     mad (16|M0)              r114.0<1>:f   acc0.0<1;0>:f    r2.0<1;0>:f       r6.5<0>:f
 (W)     send.smpl (16|M0)        r12      r113  null:0  0x0            0x04420001           {F@1,$0} // wr:2+0, rd:4; simd16 sample:u+v+r+ai+mlod using sampler index 0
 (W)     send.rc (16|M0)          null     r12   null:0  0x0            0x08031400           {EOT,$0} // wr:4+0, rd:0; full-precision render target write SIMD16; last render target to surface 0
 L96:
diff --git a/lib/rendercopy_gen9.c b/lib/rendercopy_gen9.c
index 392d68653b..7c7563d50c 100644
--- a/lib/rendercopy_gen9.c
+++ b/lib/rendercopy_gen9.c
@@ -138,10 +138,10 @@ static const uint32_t gen12p71_render_copy[][4] = {
 };
 
 static const uint32_t xe2_render_copy[][4] = {
-	{ 0x8010005b, 0x200002a0, 0x020a0604, 0x06640105 },
-	{ 0x8010005b, 0x710402a8, 0x020a2001, 0x06140105 },
-	{ 0x8010005b, 0x200002a0, 0x020a0634, 0x06440105 },
-	{ 0x8010005b, 0x720402a8, 0x020a2001, 0x06540205 },
+	{ 0x8010005b, 0x200002a0, 0x020a0604, 0x06640104 },
+	{ 0x8010005b, 0x710402a8, 0x020a2000, 0x06140104 },
+	{ 0x8010005b, 0x200002a0, 0x020a0634, 0x06440104 },
+	{ 0x8010005b, 0x720402a8, 0x020a2000, 0x06540204 },
 	{ 0x80122031, 0x0c240000, 0x20027114, 0x00800000 },
 	{ 0x8010c031, 0x00000004, 0x58000c24, 0x00c40000 },
 };
-- 
2.34.1


  reply	other threads:[~2024-04-23  7:05 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-23  7:04 [PATCH i-g-t 0/2] Use xe2 render-copy on newer hardware Zbigniew Kempczyński
2024-04-23  7:04 ` Zbigniew Kempczyński [this message]
2024-04-23  8:29   ` [PATCH i-g-t 1/2] lib/rendercopy: Fix horizontal stride Grzegorzek, Dominik
2024-04-23  7:04 ` [PATCH i-g-t 2/2] lib/intel_batchbuffer: Be ready to use xe2 render-copy on newer hardware Zbigniew Kempczyński
2024-04-23  8:30   ` Grzegorzek, Dominik
2024-04-23  9:29 ` ✓ Fi.CI.BAT: success for Use " Patchwork
2024-04-23  9:58 ` ✓ CI.xeBAT: " Patchwork
2024-04-23 15:20 ` ✗ CI.xeFULL: failure " Patchwork
2024-04-24  6:08   ` Zbigniew Kempczyński
2024-04-24  8:07 ` ✓ Fi.CI.IGT: success " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240423070449.150518-2-zbigniew.kempczynski@intel.com \
    --to=zbigniew.kempczynski@intel.com \
    --cc=dominik.grzegorzek@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox