Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Mauro Carvalho Chehab <mauro.chehab@linux.intel.com>
To: Katarzyna Piecielska <katarzyna.piecielska@intel.com>
Cc: igt-dev@lists.freedesktop.org,
	Kamil Konieczny <kamil.konieczny@intel.com>,
	Jari Tahvanainen <jari.tahvanainen@intel.com>
Subject: Re: [PATCH i-g-t v2 2/3] tests/intel: Put "Run type" highest in KMS documentation hierarchy
Date: Wed, 24 Apr 2024 09:42:58 +0200	[thread overview]
Message-ID: <20240424094258.05256a9b@maurocar-mobl2> (raw)
In-Reply-To: <20240423095344.3518545-3-katarzyna.piecielska@intel.com>

On Tue, 23 Apr 2024 09:53:43 +0000
Katarzyna Piecielska <katarzyna.piecielska@intel.com> wrote:

> Let's put "Run type" at highest place in KMS documentation hierarchy. It
> will be reflected in html generated documentation.
> 
> Signed-off-by: Katarzyna Piecielska <katarzyna.piecielska@intel.com>
> Cc: Kamil Konieczny <kamil.konieczny@intel.com>
> Cc: Jari Tahvanainen <jari.tahvanainen@intel.com>
> Cc: Mauro Carvalho Chehab <mauro.chehab@linux.intel.com>
> ---
>  tests/intel/kms_test_config.json | 94 ++++++++++++++++----------------
>  1 file changed, 47 insertions(+), 47 deletions(-)
> 
> diff --git a/tests/intel/kms_test_config.json b/tests/intel/kms_test_config.json
> index f3f6bfad6..35010d886 100644
> --- a/tests/intel/kms_test_config.json
> +++ b/tests/intel/kms_test_config.json
JSON file doesn't look right, as it is placing Description and other
fields below Run type level.

What about using, instead:

{
    "description": "JSON file to be used to parse KMS documentation",
    "name": "Display and KMS Tests for Intel i915 and Xe Drivers",
    "drivers": [ "xe", "i915" ],
    "files": [ "../chamelium/kms_*.c", "../kms_*.c", "../testdisplay.c", "kms_*.c" ],
    "exclude_files": [ "../chamelium/kms_chamelium_helper.c", "../kms_color_helper.c",
                       "kms_dsc_helper.c" ],
    "fields": {
        "Run type": {
            "_properties_": {
                "description": "Defines what category of testlist it belongs",
                "update-from-file": {
                    "append-value-if-not-excluded": "Xe FULL, i915 FULL",
                    "exclude-type": "regex-ignorecase",
                    "include": [
                        { "i915 BAT": "../intel-ci/fast-feedback.testlist" },
                        { "i915 BAT chamelium": "../intel-ci/fast-feedback-chamelium-only.testlist" },
                        { "i915 chamelium": "../intel-ci/chamelium-only.testlist" },

                        { "Xe BAT": "../intel-ci/xe-fast-feedback.testlist" },
                        { "Xe BAT chamelium": "../intel-ci/xe-fast-feedback-chamelium-only.testlist" }
                    ],
                    "exclude": [
                        { "i915 BAT, i915 BAT chamelium, i915 chamelium, i915 FULL": "../intel-ci/blacklist.txt" },
                            { "Xe BAT, Xe BAT chamelium, Xe FULL": "../intel-ci/xe.blocklist.txt" }
                        ]
                    }
                },
            "Category": {
                "_properties_": {
                    "description": "Contains the major group for the tested functionality 'Display'"
                },
                "Mega feature": {
                    "_properties_": {
                        "description": "Contains the mega feature for end to end use case, e.g. the 'PSR' feature."
                    },
                    "Functionality": {
                        "_properties_": {
                            "description": "Groups tests on buckets containg more detailed functionality"
                        }
                    }
                }
            }
        },
        "Driver requirement": {
            "_properties_": {
                "description": "Describes any Driver specific requrirement, like i915/xe."
            }
        },
        "Test category": {
            "_properties_": {
                "description": "Defines the test category. Usually used at subtest level."
            }
        },
        "Description" : {
            "_properties_": {
                "description": "Provides a description for the test/subtest."
            }
        }
    }
}

  reply	other threads:[~2024-04-24  7:44 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-23  9:53 [PATCH i-g-t v2 0/3] Put "Run type" highest in documentation hierarchy Katarzyna Piecielska
2024-04-23  9:53 ` [PATCH i-g-t v2 1/3] tests/intel: Put "Run type" highest in Xe " Katarzyna Piecielska
2024-04-23  9:53 ` [PATCH i-g-t v2 2/3] tests/intel: Put "Run type" highest in KMS " Katarzyna Piecielska
2024-04-24  7:42   ` Mauro Carvalho Chehab [this message]
2024-04-23  9:53 ` [PATCH i-g-t v2 3/3] tests/intel: Put "Run type" highest in i915 " Katarzyna Piecielska
2024-04-24  7:45   ` Mauro Carvalho Chehab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240424094258.05256a9b@maurocar-mobl2 \
    --to=mauro.chehab@linux.intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=jari.tahvanainen@intel.com \
    --cc=kamil.konieczny@intel.com \
    --cc=katarzyna.piecielska@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox