Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Zbigniew Kempczyński" <zbigniew.kempczynski@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: "Zbigniew Kempczyński" <zbigniew.kempczynski@intel.com>
Subject: [PATCH i-g-t 6/7] lib/rendercopy_gen9: Allow to use all tilings on flatccs platforms
Date: Thu, 25 Apr 2024 12:47:20 +0200	[thread overview]
Message-ID: <20240425104721.52376-7-zbigniew.kempczynski@intel.com> (raw)
In-Reply-To: <20240425104721.52376-1-zbigniew.kempczynski@intel.com>

Instead of limiting compression to Tile4 lets enable it for any
tiling when platform has flatccs area.

Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
---
 lib/rendercopy_gen9.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/rendercopy_gen9.c b/lib/rendercopy_gen9.c
index 7c7563d50c..67bb7cfacd 100644
--- a/lib/rendercopy_gen9.c
+++ b/lib/rendercopy_gen9.c
@@ -175,6 +175,7 @@ gen9_bind_buf(struct intel_bb *ibb, const struct intel_buf *buf, int is_dst,
 		case 64: ss->ss0.surface_format = SURFACEFORMAT_R16G16B16A16_FLOAT; break;
 		default: igt_assert(0);
 	}
+
 	ss->ss0.vertical_alignment = 1; /* align 4 */
 	ss->ss0.horizontal_alignment = 1; /* align 4 or HALIGN_32 on display ver >= 13*/
 
@@ -232,7 +233,6 @@ gen9_bind_buf(struct intel_bb *ibb, const struct intel_buf *buf, int is_dst,
 		ss->ss6.aux_mode = 0x5; /* AUX_CCS_E */
 
 		if (buf->ccs[0].stride) {
-
 			ss->ss6.aux_pitch = (buf->ccs[0].stride / 128) - 1;
 
 			address = intel_bb_offset_reloc_with_delta(ibb, buf->handle,
@@ -268,7 +268,7 @@ gen9_bind_buf(struct intel_bb *ibb, const struct intel_buf *buf, int is_dst,
 			ss->ss13.clear_address_hi = (address + buf->cc.offset) >> 32;
 		}
 
-		if (HAS_4TILE(ibb->devid)) {
+		if (HAS_FLATCCS(ibb->devid)) {
 			ss->ss7.dg2.memory_compression_type = 0;
 			ss->ss7.dg2.memory_compression_enable = 0;
 			ss->ss7.dg2.disable_support_for_multi_gpu_partial_writes = 1;
-- 
2.34.1


  parent reply	other threads:[~2024-04-25 10:47 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-25 10:47 [PATCH i-g-t 0/7] Add render-copy compression on Xe+ Zbigniew Kempczyński
2024-04-25 10:47 ` [PATCH i-g-t 1/7] lib/intel_bufops: Store devid on buffer ops creation Zbigniew Kempczyński
2024-04-25 10:47 ` [PATCH i-g-t 2/7] lib/intel_blt: Rename confusing fb tile to i915 tile Zbigniew Kempczyński
2024-04-25 10:47 ` [PATCH i-g-t 3/7] lib/intel_blt: Add i915 -> blt tile helper converter Zbigniew Kempczyński
2024-04-25 10:47 ` [PATCH i-g-t 4/7] lib/intel_bufops: Drop tilings restrictions Zbigniew Kempczyński
2024-04-25 13:08   ` Juha-Pekka Heikkila
2024-04-25 15:52     ` Zbigniew Kempczyński
2024-04-26 10:14       ` Juha-Pekka Heikkila
2024-04-26 11:22         ` Zbigniew Kempczyński
2024-04-25 10:47 ` [PATCH i-g-t 5/7] lib/intel_bufops: Start supporting compression on Xe2+ Zbigniew Kempczyński
2024-04-25 10:47 ` Zbigniew Kempczyński [this message]
2024-04-25 12:26   ` [PATCH i-g-t 6/7] lib/rendercopy_gen9: Allow to use all tilings on flatccs platforms Juha-Pekka Heikkila
2024-04-25 15:53     ` Zbigniew Kempczyński
2024-04-26  8:21     ` Zbigniew Kempczyński
2024-04-25 10:47 ` [PATCH i-g-t 7/7] tests/xe_render_copy: Add subtest which exercises compression Zbigniew Kempczyński
2024-04-25 11:43 ` ✓ CI.xeBAT: success for Add render-copy compression on Xe+ Patchwork
2024-04-25 11:49 ` ✗ Fi.CI.BAT: failure " Patchwork
2024-04-26  3:59   ` Zbigniew Kempczyński
2024-04-26  7:59     ` Illipilli, TejasreeX
2024-04-25 23:59 ` ✗ CI.xeFULL: " Patchwork
2024-04-26  7:56 ` ✓ Fi.CI.BAT: success " Patchwork
2024-04-26 10:06 ` ✗ Fi.CI.IGT: failure " Patchwork
2024-05-06  7:27   ` Zbigniew Kempczyński

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240425104721.52376-7-zbigniew.kempczynski@intel.com \
    --to=zbigniew.kempczynski@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox