Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Alex Hung <alex.hung@amd.com>
To: <igt-dev@lists.freedesktop.org>, <harry.wentland@amd.com>,
	<hersenxs.wu@amd.com>, <quic_abhinavk@quicinc.com>
Cc: Alex Hung <alex.hung@amd.com>
Subject: [PATCH] tests/kms_writeback: Set atomic and writeback_connector early
Date: Mon, 13 May 2024 17:03:56 -0600	[thread overview]
Message-ID: <20240513230356.695515-1-alex.hung@amd.com> (raw)

With dc2d7fb4f978, all kms_writeback subtests are skipped.

DRM_CLIENT_CAP_ATOMIC and DRM_CLIENT_CAP_WRITEBACK_CONNECTORS
need to be set before igt_require which initializes a list
of outputs including writeback.

Fixes: dc2d7fb4f978 ("lib/igt_kms: move setting DRM_CLIENT_CAP_WRITEBACK_CONNECTORS to kms_writeback")
Signed-off-by: Alex Hung <alex.hung@amd.com>
---
 tests/kms_writeback.c | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/tests/kms_writeback.c b/tests/kms_writeback.c
index f89b2d62f..65d4db26b 100644
--- a/tests/kms_writeback.c
+++ b/tests/kms_writeback.c
@@ -567,14 +567,17 @@ igt_main_args("b:c:f:dl", long_options, help_str, opt_handler, NULL)
 
 		kmstest_set_vt_graphics_mode();
 
-		igt_display_require(&display, display.drm_fd);
-
-		igt_require(display.is_atomic);
+		if (drmSetClientCap(display.drm_fd, DRM_CLIENT_CAP_ATOMIC, 1) == 0)
+			display.is_atomic = 1;
 
 		ret = drmSetClientCap(display.drm_fd, DRM_CLIENT_CAP_WRITEBACK_CONNECTORS, 1);
 
 		igt_require_f(!ret, "error setting DRM_CLIENT_CAP_WRITEBACK_CONNECTORS\n");
 
+		igt_display_require(&display, display.drm_fd);
+
+		igt_require(display.is_atomic);
+
 		output = kms_writeback_get_output(&display);
 		igt_require(output);
 
-- 
2.34.1


             reply	other threads:[~2024-05-13 23:04 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-13 23:03 Alex Hung [this message]
2024-05-13 23:09 ` [PATCH] tests/kms_writeback: Set atomic and writeback_connector early Abhinav Kumar
2024-05-13 23:51 ` ✓ CI.xeBAT: success for " Patchwork
2024-05-14  0:00 ` ✓ Fi.CI.BAT: " Patchwork
2024-05-14  2:28 ` ✗ CI.xeFULL: failure " Patchwork
2024-05-14 10:59   ` Kamil Konieczny
2024-05-14 11:08 ` ✗ Fi.CI.IGT: " Patchwork
2024-05-14 13:27   ` Kamil Konieczny

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240513230356.695515-1-alex.hung@amd.com \
    --to=alex.hung@amd.com \
    --cc=harry.wentland@amd.com \
    --cc=hersenxs.wu@amd.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=quic_abhinavk@quicinc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox