Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Pranay Samala <pranay.samala@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: karthik.b.s@intel.com, jeevan.b@intel.com,
	sameer.lattannavar@intel.com, pranay.samala@intel.com
Subject: [PATCH i-g-t v2] tests/intel/kms_big_fb: Introducing this restriction to optimize the test execution time on simulation
Date: Thu, 16 May 2024 15:58:17 +0530	[thread overview]
Message-ID: <20240516102817.424967-1-pranay.samala@intel.com> (raw)

This test executes on only one pipe and all the availble planes with
set of 6 coordinates. Due to this, test takes long duration to execute
on simulation and gets timeout.

Restricting the test to execute only on primary plane with one of the
coordinates for simulation.

v2:
- Breaking the loop instead of using variable m to test only one
  coordinate for simulation (Kamil)
- Removed the variable m (Kamil)
- By default the test is running on only one pipe (Kamil)
- Testing on (0,0) coordinate (Kamil)

Signed-off-by: Pranay Samala <pranay.samala@intel.com>
---
 tests/intel/kms_big_fb.c | 18 +++++++++++++++---
 1 file changed, 15 insertions(+), 3 deletions(-)

diff --git a/tests/intel/kms_big_fb.c b/tests/intel/kms_big_fb.c
index 1e45d8e42..f1207e21f 100644
--- a/tests/intel/kms_big_fb.c
+++ b/tests/intel/kms_big_fb.c
@@ -455,6 +455,11 @@ static bool test_plane(data_t *data)
 		{ w, h, },
 	};
 
+	if (igt_run_in_simulation()) {
+		plane = igt_output_get_plane_type(data->output, DRM_PLANE_TYPE_PRIMARY);
+		igt_plane_set_fb(plane, NULL);
+	}
+
 	if (!igt_plane_has_format_mod(plane, data->format, data->modifier))
 		return false;
 
@@ -529,6 +534,9 @@ static bool test_plane(data_t *data)
 
 		igt_assert_crc_equal(&big_crc, &small_crc);
 		igt_pipe_crc_stop(data->pipe_crc);
+
+		if (igt_run_in_simulation())
+			break;
 	}
 
 	return true;
@@ -595,10 +603,14 @@ static bool test_pipe(data_t *data)
 	data->pipe_crc = igt_pipe_crc_new(data->drm_fd, data->pipe,
 					  IGT_PIPE_CRC_SOURCE_AUTO);
 
-	for_each_plane_on_pipe(&data->display, data->pipe, data->plane) {
+	if (igt_run_in_simulation())
 		ret = test_plane(data);
-		if (ret)
-			break;
+	else {
+		for_each_plane_on_pipe(&data->display, data->pipe, data->plane) {
+			ret = test_plane(data);
+			if (ret)
+				break;
+		}
 	}
 
 	if (data->format == DRM_FORMAT_C8)
-- 
2.34.1


             reply	other threads:[~2024-05-16 10:28 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-16 10:28 Pranay Samala [this message]
2024-05-16 10:58 ` ✓ CI.xeBAT: success for tests/intel/kms_big_fb: Introducing this restriction to optimize the test execution time on simulation (rev2) Patchwork
2024-05-16 12:08 ` ✗ CI.xeFULL: failure " Patchwork
2024-05-17 15:31   ` Kamil Konieczny
2024-05-16 17:02 ` ✓ Fi.CI.BAT: success " Patchwork
2024-05-16 21:22 ` ✗ Fi.CI.IGT: failure " Patchwork
2024-05-17 15:30   ` Kamil Konieczny
2024-05-17 15:27 ` [PATCH i-g-t v2] tests/intel/kms_big_fb: Introducing this restriction to optimize the test execution time on simulation Kamil Konieczny

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240516102817.424967-1-pranay.samala@intel.com \
    --to=pranay.samala@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=jeevan.b@intel.com \
    --cc=karthik.b.s@intel.com \
    --cc=sameer.lattannavar@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox