Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Pranay Samala <pranay.samala@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: karthik.b.s@intel.com, jeevan.b@intel.com,
	sameer.lattannavar@intel.com, pranay.samala@intel.com
Subject: [PATCH i-g-t v4] tests/intel/kms_big_fb: Restrict runs on simulation
Date: Mon, 20 May 2024 22:58:10 +0530	[thread overview]
Message-ID: <20240520172810.455947-1-pranay.samala@intel.com> (raw)

This test executes on only one pipe and all the available planes with
set of 6 coordinates. Due to this, test takes long duration to execute
on simulation and gets timeout.

Restricting the test to execute only on one of the coordinates for
simulation.

v4:
- Inserted simulation check right after for loop (Kamil)
- Executing only on 1 coordinate (w, h) on simulation

Signed-off-by: Pranay Samala <pranay.samala@intel.com>
---
 tests/intel/kms_big_fb.c | 13 ++++++++++---
 1 file changed, 10 insertions(+), 3 deletions(-)

diff --git a/tests/intel/kms_big_fb.c b/tests/intel/kms_big_fb.c
index 1e45d8e42..605813f7f 100644
--- a/tests/intel/kms_big_fb.c
+++ b/tests/intel/kms_big_fb.c
@@ -443,6 +443,7 @@ static bool test_plane(data_t *data)
 	struct igt_fb *big_fb = &data->big_fb;
 	int w = data->big_fb_width - small_fb->width;
 	int h = data->big_fb_height - small_fb->height;
+	bool run_in_simulation = igt_run_in_simulation();
 	struct {
 		int x, y;
 	} coords[] = {
@@ -467,8 +468,13 @@ static bool test_plane(data_t *data)
 
 	for (int i = 0; i < ARRAY_SIZE(coords); i++) {
 		igt_crc_t small_crc, big_crc;
-		int x = coords[i].x;
-		int y = coords[i].y;
+		int x, y;
+
+		if (run_in_simulation)
+			i = ARRAY_SIZE(coords) - 1;
+
+		x = coords[i].x;
+		y = coords[i].y;
 
 		/* Hardware limitation */
 		if (data->format == DRM_FORMAT_RGB565 &&
@@ -540,6 +546,7 @@ static bool test_pipe(data_t *data)
 	drmModeModeInfo *mode;
 	igt_plane_t *primary;
 	bool ret = false;
+	bool run_in_simulation = igt_run_in_simulation();
 
 	igt_info("Using (pipe %s + %s) to run the subtest.\n",
 		 kmstest_pipe_name(data->pipe), igt_output_name(data->output));
@@ -597,7 +604,7 @@ static bool test_pipe(data_t *data)
 
 	for_each_plane_on_pipe(&data->display, data->pipe, data->plane) {
 		ret = test_plane(data);
-		if (ret)
+		if (ret || run_in_simulation)
 			break;
 	}
 
-- 
2.34.1


             reply	other threads:[~2024-05-20 17:28 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-20 17:28 Pranay Samala [this message]
2024-05-20 19:58 ` ✓ CI.xeBAT: success for tests/intel/kms_big_fb: Restrict runs on simulation (rev2) Patchwork
2024-05-20 20:13 ` ✓ Fi.CI.BAT: " Patchwork
2024-05-20 20:59 ` ✗ CI.xeFULL: failure " Patchwork
2024-05-21  9:18   ` Kamil Konieczny
2024-05-21  9:16 ` [PATCH i-g-t v4] tests/intel/kms_big_fb: Restrict runs on simulation Kamil Konieczny
2024-05-21 16:35 ` ✗ Fi.CI.IGT: failure for tests/intel/kms_big_fb: Restrict runs on simulation (rev2) Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240520172810.455947-1-pranay.samala@intel.com \
    --to=pranay.samala@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=jeevan.b@intel.com \
    --cc=karthik.b.s@intel.com \
    --cc=sameer.lattannavar@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox