From: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
Subject: [PATCH i-g-t] HAX/DONOT_MERGE: Add debug prints to HDR tests.
Date: Tue, 21 May 2024 15:15:28 +0530 [thread overview]
Message-ID: <20240521094528.2591672-1-bhanuprakash.modem@intel.com> (raw)
Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
lib/igt_kms.c | 10 ++++++++--
tests/kms_hdr.c | 21 +++++++++++++++++----
2 files changed, 25 insertions(+), 6 deletions(-)
diff --git a/lib/igt_kms.c b/lib/igt_kms.c
index f82102144..df6c8f8fc 100644
--- a/lib/igt_kms.c
+++ b/lib/igt_kms.c
@@ -6189,15 +6189,21 @@ bool igt_max_bpc_constraint(igt_display_t *display, enum pipe pipe,
for_each_connector_mode(output) {
igt_output_override_mode(output, &connector->modes[j__]);
+ kmstest_dump_mode(&connector->modes[j__]);
+
if (is_intel_device(display->drm_fd) &&
- !igt_check_bigjoiner_support(display))
+ !igt_check_bigjoiner_support(display)) {
+ igt_info("Bigjoiner not supported, on selected combo, trying another mode\n");
continue;
+ }
igt_display_commit2(display, display->is_atomic ? COMMIT_ATOMIC : COMMIT_LEGACY);
if (!igt_check_output_bpc_equal(display->drm_fd, pipe,
- output->name, bpc))
+ output->name, bpc)) {
+ igt_info("Can't use this mode to match the requested bpc-%d, trying another mode\n", bpc);
continue;
+ }
return true;
}
diff --git a/tests/kms_hdr.c b/tests/kms_hdr.c
index 99b78f7ef..cc5a08f8c 100644
--- a/tests/kms_hdr.c
+++ b/tests/kms_hdr.c
@@ -621,25 +621,37 @@ static void test_hdr(data_t *data, uint32_t flags)
* set MAX_BPC property to 10bpc prior to setting
* HDR metadata property. Therefore, checking.
*/
- if (!has_max_bpc(output) || !has_hdr(output))
+ if (!has_max_bpc(output) || !has_hdr(output)) {
+ igt_info("Output %s: doesn't support IGT_CONNECTOR_MAX_BPC or IGT_CONNECTOR_HDR_OUTPUT_METADATA\n", output->name);
continue;
+ }
/* For negative test, panel should be non-hdr. */
- if ((flags & TEST_INVALID_HDR) && is_panel_hdr(data, output))
+ if ((flags & TEST_INVALID_HDR) && is_panel_hdr(data, output)) {
+ igt_info("Output %s: Can't run negative test on HDR panel\n", output->name);
continue;
+ }
- if ((flags & ~TEST_INVALID_HDR) && !is_panel_hdr(data, output))
+ if ((flags & ~TEST_INVALID_HDR) && !is_panel_hdr(data, output)) {
+ igt_info("Output %s: Can't run HDR tests on non-HDR panel\n", output->name);
continue;
+ }
- if (igt_get_output_max_bpc(data->fd, output->name) < 10)
+ if (igt_get_output_max_bpc(data->fd, output->name) < 10) {
+ igt_info("Output %s: doesn't support 10 bpc\n", output->name);
continue;
+ }
for_each_pipe(display, pipe) {
+ igt_info("Using the combo: pipe-%s + %s\n", kmstest_pipe_name(pipe), output->name);
+
if (igt_pipe_connector_valid(pipe, output)) {
prepare_test(data, output, pipe);
if (is_intel_device(data->fd) &&
!igt_max_bpc_constraint(display, pipe, output, 10)) {
+ igt_info("No suitable mode found to use 10 bpc.\n");
+
test_fini(data);
break;
}
@@ -661,6 +673,7 @@ static void test_hdr(data_t *data, uint32_t flags)
/* One pipe is enough */
break;
}
+ igt_info("pipe-%s-%s: Invalid combo\n", kmstest_pipe_name(pipe), output->name);
}
}
}
--
2.43.2
next reply other threads:[~2024-05-21 9:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-21 9:45 Bhanuprakash Modem [this message]
2024-05-21 12:02 ` ✓ CI.xeBAT: success for HAX/DONOT_MERGE: Add debug prints to HDR tests Patchwork
2024-05-21 12:09 ` ✓ Fi.CI.BAT: " Patchwork
2024-05-21 14:45 ` ✓ CI.xeFULL: " Patchwork
2024-05-22 5:08 ` ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240521094528.2591672-1-bhanuprakash.modem@intel.com \
--to=bhanuprakash.modem@intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox