Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cavitt <jonathan.cavitt@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: jonathan.cavitt@intel.com, saurabhg.gupta@intel.com,
	matthew.brost@intel.com, john.c.harrison@intel.com,
	stuart.summers@intel.com
Subject: [PATCH i-g-t 2/2] test/intel/xe_exec_reset: Synchronize cm-gt-reset gt resets
Date: Wed,  5 Jun 2024 08:12:48 -0700	[thread overview]
Message-ID: <20240605151248.2736694-3-jonathan.cavitt@intel.com> (raw)
In-Reply-To: <20240605151248.2736694-1-jonathan.cavitt@intel.com>

The cm-gt-reset test has the potential to race with itself on the gt
reset, so force the gt reset to be synchronous here.  The race condition
occurs because the test does not have a fencing mechanism (I.E.
dma-fence) to protect against this race, unlike in the gt-reset test
case, for example.

Suggested-by: Matthew Brost <matthew.brost@intel.com>
Signed-off-by: Jonathan Cavitt <jonathan.cavitt@intel.com>
CC: John Harrison <john.c.harrison@intel.com>
CC: Stuart Summers <stuart.summers@intel.com>
---
 tests/intel/xe_exec_reset.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/intel/xe_exec_reset.c b/tests/intel/xe_exec_reset.c
index ed67284800..5a5ce32837 100644
--- a/tests/intel/xe_exec_reset.c
+++ b/tests/intel/xe_exec_reset.c
@@ -530,7 +530,7 @@ test_compute_mode(int fd, struct drm_xe_engine_class_instance *eci,
 	}
 
 	if (flags & GT_RESET)
-		xe_force_gt_reset(fd, eci->gt_id, false);
+		xe_force_gt_reset(fd, eci->gt_id, true);
 
 	if (flags & CLOSE_FD) {
 		if (flags & CLOSE_EXEC_QUEUES) {
-- 
2.25.1


  parent reply	other threads:[~2024-06-05 15:28 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-05 15:12 [PATCH i-g-t 0/2] lib/xe: Use synchronous gt resets when needed Jonathan Cavitt
2024-06-05 15:12 ` [PATCH i-g-t 1/2] lib/xe: Add sync tag to xe_force_gt_reset Jonathan Cavitt
2024-06-05 16:26   ` Matthew Brost
2024-06-05 15:12 ` Jonathan Cavitt [this message]
2024-06-05 17:02 ` ✓ CI.xeBAT: success for lib/xe: Use synchronous gt resets when needed Patchwork
2024-06-05 17:10 ` ✓ Fi.CI.BAT: " Patchwork
2024-06-05 22:57 ` ✗ Fi.CI.IGT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240605151248.2736694-3-jonathan.cavitt@intel.com \
    --to=jonathan.cavitt@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=john.c.harrison@intel.com \
    --cc=matthew.brost@intel.com \
    --cc=saurabhg.gupta@intel.com \
    --cc=stuart.summers@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox