Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Mohammed Thasleem <mohammed.thasleem@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: imre.deak@intel.com, Mohammed Thasleem <mohammed.thasleem@intel.com>
Subject: [PATCH i-g-t] tests/intel/kms_pm_backlight: Brightness test during DPMS on and off
Date: Fri,  7 Jun 2024 16:03:29 +0530	[thread overview]
Message-ID: <20240607103329.16841-1-mohammed.thasleem@intel.com> (raw)
In-Reply-To: <20220424005737.228759-1-mohammed.thasleem@intel.com>

Set brightness by deviding max brightness, store and read it back.
The actual brightness should be same during DPMS on and off cycle.

v2: Update test path and testplan documentation.

Signed-off-by: Mohammed Thasleem <mohammed.thasleem@intel.com>
---
 tests/intel/kms_pm_backlight.c | 41 ++++++++++++++++++++++++++++++++++
 1 file changed, 41 insertions(+)

diff --git a/tests/intel/kms_pm_backlight.c b/tests/intel/kms_pm_backlight.c
index 2e691dab0..107b7d668 100644
--- a/tests/intel/kms_pm_backlight.c
+++ b/tests/intel/kms_pm_backlight.c
@@ -64,6 +64,10 @@
  * SUBTEST: fade-with-suspend
  * Description: Test the fade with suspend.
  * Functionality: backlight, suspend
+ *
+ * SUBTEST: brightness-with-dpms
+ * Description: test brightness with dpms on and off cycle.
+ * Functionality: backlight, backlight
  */
 
 struct context {
@@ -217,6 +221,32 @@ check_suspend(igt_output_t *output)
 	igt_system_suspend_autoresume(SUSPEND_STATE_MEM, SUSPEND_TEST_NONE);
 }
 
+static void check_dpms_cycle(igt_display_t *display, igt_output_t *output, struct context *context)
+{
+	int max, val_1, val_2;
+
+	backlight_read(&max, "max_brightness", context);
+	igt_assert(max);
+
+	backlight_write(max / 2, "brightness", context);
+	backlight_read(&val_1, "actual_brightness", context);
+
+	igt_require(igt_setup_runtime_pm(output->display->drm_fd));
+
+	kmstest_set_connector_dpms(output->display->drm_fd,
+				   output->config.connector,
+				   DRM_MODE_DPMS_OFF);
+	igt_require(igt_wait_for_pm_status(IGT_RUNTIME_PM_STATUS_SUSPENDED));
+
+	kmstest_set_connector_dpms(output->display->drm_fd,
+				   output->config.connector,
+				   DRM_MODE_DPMS_ON);
+	igt_assert(igt_wait_for_pm_status(IGT_RUNTIME_PM_STATUS_ACTIVE));
+
+	backlight_read(&val_2, "actual_brightness", context);
+	igt_assert_eq(val_1, val_2);
+}
+
 static void test_cleanup(igt_display_t *display, igt_output_t *output)
 {
 	igt_output_set_pipe(output, PIPE_NONE);
@@ -354,6 +384,17 @@ igt_main
 		}
 	}
 
+	igt_describe("test brightness with dpms on and off cycle");
+	igt_subtest_with_dynamic("brightness-with-dpms") {
+		for (int j = 0; j < (dual_edp ? 2 : 1); j++) {
+			test_setup(display, &contexts->output[j]);
+			igt_dynamic_f("%s", igt_output_name(contexts[j].output)) {
+				check_dpms_cycle(&display, &contexts->output[j], &contexts[j]);
+				test_cleanup(&display, &contexts->output[j]);
+			}
+		}
+	}
+
 	igt_fixture {
 		/* Restore old brightness */
 		for (i = 0; i < (dual_edp ? 2 : 1); i++)
-- 
2.25.1


  parent reply	other threads:[~2024-06-07 10:34 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-24  0:57 [igt-dev] [PATCH i-g-t] tests/i915/i915_pm_backlight: Brightness test during DPMS on and off Mohammed Thasleem
2023-03-25 19:05 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2023-03-25 20:12 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2024-06-07 10:33 ` Mohammed Thasleem [this message]
2024-06-07 11:15   ` [PATCH i-g-t] tests/intel/kms_pm_backlight: " Jani Nikula
2024-07-04 11:31   ` Mohammed Thasleem
2024-09-18  5:31     ` Hogander, Jouni
2024-09-18  7:36       ` Jani Nikula
2024-09-26 19:38     ` Mohammed Thasleem
2024-09-28  9:44       ` Naladala, Ramanaidu
2024-06-07 21:08 ` ✓ Fi.CI.BAT: success for tests/i915/i915_pm_backlight: Brightness test during DPMS on and off (rev2) Patchwork
2024-06-07 21:31 ` ✓ CI.xeBAT: " Patchwork
2024-06-08 11:05 ` ✗ CI.xeFULL: failure " Patchwork
2024-06-08 11:10 ` ✗ Fi.CI.IGT: " Patchwork
2024-07-04 18:28 ` ✓ Fi.CI.BAT: success for tests/i915/i915_pm_backlight: Brightness test during DPMS on and off (rev3) Patchwork
2024-07-04 18:29 ` ✓ CI.xeBAT: " Patchwork
2024-07-04 23:46 ` ✓ CI.xeFULL: " Patchwork
2024-07-05  7:51 ` ✗ Fi.CI.IGT: failure " Patchwork
2024-09-26 21:03 ` ✓ Fi.CI.BAT: success for tests/i915/i915_pm_backlight: Brightness test during DPMS on and off (rev4) Patchwork
2024-09-26 21:11 ` ✓ CI.xeBAT: " Patchwork
2024-09-27  3:44 ` ✗ Fi.CI.IGT: failure " Patchwork
2024-09-27 23:14 ` ✗ CI.xeFULL: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240607103329.16841-1-mohammed.thasleem@intel.com \
    --to=mohammed.thasleem@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=imre.deak@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox