From: Vinod Govindapillai <vinod.govindapillai@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: vinod.govindapillai@intel.com, juha-pekka.heikkila@intel.com,
jouni.hogander@intel.com, jonathan.cavitt@intel.com
Subject: [PATCH i-g-t v2 3/5] tests/kms_dirtyfb: disable psr feature only if psr possible
Date: Mon, 10 Jun 2024 14:59:39 +0300 [thread overview]
Message-ID: <20240610115941.35279-4-vinod.govindapillai@intel.com> (raw)
In-Reply-To: <20240610115941.35279-1-vinod.govindapillai@intel.com>
When kms_dirtyfb tests are executed on cases where PSR is not
possible the tests are getting skipped. This is because igt_skip
is use in psr_set function. So avoid calling the psr_disable if
not necessary.
Reviewed-by: Jonathan Cavitt <jonathan.cavitt@intel.com>
Signed-off-by: Vinod Govindapillai <vinod.govindapillai@intel.com>
---
tests/intel/kms_dirtyfb.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/tests/intel/kms_dirtyfb.c b/tests/intel/kms_dirtyfb.c
index 6121599ec..2a32fab56 100644
--- a/tests/intel/kms_dirtyfb.c
+++ b/tests/intel/kms_dirtyfb.c
@@ -169,7 +169,10 @@ static void check_feature(data_t *data)
static void disable_features(data_t *data)
{
intel_fbc_disable(data->drm_fd);
- psr_disable(data->drm_fd, data->debugfs_fd, NULL);
+
+ if (psr_sink_support(data->drm_fd, data->debugfs_fd, PSR_MODE_1, NULL))
+ psr_disable(data->drm_fd, data->debugfs_fd, NULL);
+
intel_drrs_disable(data->drm_fd, data->pipe);
}
--
2.34.1
next prev parent reply other threads:[~2024-06-10 12:00 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-10 11:59 [PATCH i-g-t v2 0/5] tests/kms_dirtyfb: few fbc related updates Vinod Govindapillai
2024-06-10 11:59 ` [PATCH i-g-t v2 1/5] lib/i915/fbc: print current fbc status if cannot be enabled Vinod Govindapillai
2024-06-10 11:59 ` [PATCH i-g-t v2 2/5] lib/i915/fbc: add fbc frame size check helper functions Vinod Govindapillai
2024-06-10 11:59 ` Vinod Govindapillai [this message]
2024-06-10 11:59 ` [PATCH i-g-t v2 4/5] tests/kms_dirtyfb: populate modeinfo before feature support check Vinod Govindapillai
2024-06-10 14:36 ` Cavitt, Jonathan
2024-06-10 11:59 ` [PATCH i-g-t v2 5/5] tests/kms_dirtyfb: ensure plane size is within fbc supported limit Vinod Govindapillai
2024-06-10 12:41 ` ✓ Fi.CI.BAT: success for tests/kms_dirtyfb: few fbc related updates (rev2) Patchwork
2024-06-10 13:45 ` ✓ CI.xeBAT: " Patchwork
2024-06-10 15:31 ` ✗ Fi.CI.IGT: failure " Patchwork
2024-06-11 8:11 ` Govindapillai, Vinod
2024-06-10 15:44 ` ✗ CI.xeFULL: " Patchwork
2024-06-11 8:06 ` Govindapillai, Vinod
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240610115941.35279-4-vinod.govindapillai@intel.com \
--to=vinod.govindapillai@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=jonathan.cavitt@intel.com \
--cc=jouni.hogander@intel.com \
--cc=juha-pekka.heikkila@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox