From: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
Subject: [PATCH i-g-t 3/9] tests/intel/kms_pwrite_crc: Test cleanup
Date: Mon, 10 Jun 2024 22:04:51 +0530 [thread overview]
Message-ID: <20240610163457.3711476-4-bhanuprakash.modem@intel.com> (raw)
In-Reply-To: <20240610163457.3711476-1-bhanuprakash.modem@intel.com>
Make sure the below points in IGT cleanup:
- Sanitize the state before starting the subtest.
- Clear the states before exiting the subtest.
- Update existing libdrm APIs with IGT kms APIs.
- Other misc (Ex: update deprecated APIs/macros/enums, FB leaks etc..)
Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
tests/intel/kms_pwrite_crc.c | 25 ++++++++++++++-----------
1 file changed, 14 insertions(+), 11 deletions(-)
diff --git a/tests/intel/kms_pwrite_crc.c b/tests/intel/kms_pwrite_crc.c
index 12add5da6..c6e4a29fa 100644
--- a/tests/intel/kms_pwrite_crc.c
+++ b/tests/intel/kms_pwrite_crc.c
@@ -125,7 +125,6 @@ static void prepare_crtc(data_t *data)
igt_output_t *output = data->output;
drmModeModeInfo *mode;
- igt_display_reset(display);
/* select the pipe we want to use */
igt_output_set_pipe(output, data->pipe);
@@ -161,7 +160,7 @@ static void cleanup_crtc(data_t *data)
igt_plane_set_fb(data->primary, NULL);
- igt_output_set_pipe(output, PIPE_ANY);
+ igt_output_set_pipe(output, PIPE_NONE);
igt_display_commit(display);
igt_remove_fb(data->drm_fd, &data->fb[0]);
@@ -195,18 +194,22 @@ static data_t data;
igt_simple_main
{
- data.drm_fd = drm_open_driver_master(DRIVER_INTEL);
+ igt_fixture {
+ data.drm_fd = drm_open_driver_master(DRIVER_INTEL);
+ kmstest_set_vt_graphics_mode();
- data.devid = intel_get_drm_devid(data.drm_fd);
+ igt_display_require(&data.display, data.drm_fd);
+ igt_display_require_output(&data.display);
+ igt_require_pipe_crc(data.drm_fd);
- kmstest_set_vt_graphics_mode();
-
- igt_require_pipe_crc(data.drm_fd);
-
- igt_display_require(&data.display, data.drm_fd);
+ data.devid = intel_get_drm_devid(data.drm_fd);
+ data.pipe_crc = NULL;
+ }
run_test(&data);
- igt_display_fini(&data.display);
- drm_close_driver(data.drm_fd);
+ igt_fixture {
+ igt_display_fini(&data.display);
+ drm_close_driver(data.drm_fd);
+ }
}
--
2.43.2
next prev parent reply other threads:[~2024-06-10 16:42 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-10 16:34 [PATCH i-g-t 0/9] IGT KMS Test cleanup Bhanuprakash Modem
2024-06-10 16:34 ` [PATCH i-g-t 1/9] tests/intel/kms_fence_pin_leak: " Bhanuprakash Modem
2024-06-10 16:34 ` [PATCH i-g-t 2/9] tests/intel/kms_pipe_b_c_ivb: " Bhanuprakash Modem
2024-06-10 16:34 ` Bhanuprakash Modem [this message]
2024-06-10 16:34 ` [PATCH i-g-t 4/9] tests/kms_dp_aux_dev: " Bhanuprakash Modem
2024-06-10 16:34 ` [PATCH i-g-t 5/9] tests/kms_hdmi_inject: " Bhanuprakash Modem
2024-06-10 16:34 ` [PATCH i-g-t 6/9] tests/kms_tiled_display: " Bhanuprakash Modem
2024-06-10 16:34 ` [PATCH i-g-t 7/9] tests/kms_tv_load_detect: " Bhanuprakash Modem
2024-06-10 16:34 ` [PATCH i-g-t 8/9] tests/kms_universal_plane: " Bhanuprakash Modem
2024-06-10 16:34 ` [PATCH i-g-t 9/9] tests/kms_properties: Create dynamic subtests Bhanuprakash Modem
2024-06-10 17:14 ` ✓ CI.xeBAT: success for IGT KMS Test cleanup Patchwork
2024-06-10 17:25 ` ✗ Fi.CI.BAT: failure " Patchwork
2024-06-10 18:19 ` ✗ CI.xeFULL: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240610163457.3711476-4-bhanuprakash.modem@intel.com \
--to=bhanuprakash.modem@intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox