Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Vinod Govindapillai <vinod.govindapillai@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: vinod.govindapillai@intel.com, juha-pekka.heikkila@intel.com,
	jouni.hogander@intel.com, jonathan.cavitt@intel.com
Subject: [PATCH i-g-t v3 1/5] lib/i915/fbc: print current fbc status if cannot be enabled
Date: Tue, 11 Jun 2024 11:04:12 +0300	[thread overview]
Message-ID: <20240611080416.56878-2-vinod.govindapillai@intel.com> (raw)
In-Reply-To: <20240611080416.56878-1-vinod.govindapillai@intel.com>

Print the current fbc status if the fbc is not enabled after
the timeout.

Reviewed-by: Jonathan Cavitt <jonathan.cavitt@intel.com>
Signed-off-by: Vinod Govindapillai <vinod.govindapillai@intel.com>
---
 lib/i915/intel_fbc.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/lib/i915/intel_fbc.c b/lib/i915/intel_fbc.c
index 3fac60087..07ed7f469 100644
--- a/lib/i915/intel_fbc.c
+++ b/lib/i915/intel_fbc.c
@@ -92,6 +92,10 @@ bool intel_fbc_is_enabled(int device, enum pipe pipe, int log_level)
 bool intel_fbc_wait_until_enabled(int device, enum pipe pipe)
 {
 	char last_fbc_buf[FBC_STATUS_BUF_LEN] = {'\0'};
+	bool enabled = igt_wait(_intel_fbc_is_enabled(device, pipe, IGT_LOG_DEBUG, last_fbc_buf), 2000, 1);
 
-	return igt_wait(_intel_fbc_is_enabled(device, pipe, IGT_LOG_DEBUG, last_fbc_buf), 2000, 1);
+	if (!enabled)
+		igt_info("FBC is not enabled: \n%s\n", last_fbc_buf);
+
+	return enabled;
 }
-- 
2.34.1


  reply	other threads:[~2024-06-11  8:04 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-11  8:04 [PATCH i-g-t v3 0/5] tests/kms_dirtyfb: few fbc related updates Vinod Govindapillai
2024-06-11  8:04 ` Vinod Govindapillai [this message]
2024-06-11  8:04 ` [PATCH i-g-t v3 2/5] lib/i915/fbc: add fbc frame size check helper functions Vinod Govindapillai
2024-06-11  8:04 ` [PATCH i-g-t v3 3/5] tests/kms_dirtyfb: disable psr feature only if psr possible Vinod Govindapillai
2024-06-11  8:04 ` [PATCH i-g-t v3 4/5] tests/kms_dirtyfb: populate modeinfo before feature support check Vinod Govindapillai
2024-06-11  8:04 ` [PATCH i-g-t v3 5/5] tests/kms_dirtyfb: ensure plane size is within fbc supported limit Vinod Govindapillai
2024-06-11  9:53 ` ✓ CI.xeBAT: success for tests/kms_dirtyfb: few fbc related updates (rev3) Patchwork
2024-06-11 10:12 ` ✗ Fi.CI.BAT: failure " Patchwork
2024-06-11 12:38 ` ✗ CI.xeFULL: " Patchwork
2024-06-12  4:41 ` ✓ Fi.CI.BAT: success " Patchwork
2024-06-12  8:56 ` ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240611080416.56878-2-vinod.govindapillai@intel.com \
    --to=vinod.govindapillai@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=jonathan.cavitt@intel.com \
    --cc=jouni.hogander@intel.com \
    --cc=juha-pekka.heikkila@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox