From: "Jouni Högander" <jouni.hogander@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: kunal1.joshi@intel.com, "Jouni Högander" <jouni.hogander@intel.com>
Subject: [PATCH i-g-t v2 3/6] lib/igt_psr: Handle PR_MODE2_SEL_FETCH and eDP PR_* in psr active check
Date: Thu, 13 Jun 2024 12:25:11 +0300 [thread overview]
Message-ID: <20240613092514.1288801-4-jouni.hogander@intel.com> (raw)
In-Reply-To: <20240613092514.1288801-1-jouni.hogander@intel.com>
Panel Replay expected state is always SRDENT for DP2.0 Panel Replay.
For eDP1.5 Panel Replay it is SLEEP. Due to this output is now mandatory
parameter to psr_active_check if PSR mode is Panel Replay.
Bspec: 68920, 68934
v2: fix mode checks
Signed-off-by: Jouni Högander <jouni.hogander@intel.com>
Reviewed-by: Kunal Joshi <kunal1.joshi@intel.com>
---
lib/igt_psr.c | 18 +++++++++++++++++-
1 file changed, 17 insertions(+), 1 deletion(-)
diff --git a/lib/igt_psr.c b/lib/igt_psr.c
index d1286276c..012521fc5 100644
--- a/lib/igt_psr.c
+++ b/lib/igt_psr.c
@@ -57,9 +57,25 @@ static bool psr_active_check(int debugfs_fd, enum psr_mode mode, igt_output_t *o
{
char debugfs_file[128] = {0};
char buf[PSR_STATUS_MAX_LEN];
- const char *state = (mode == PSR_MODE_1 || mode == PR_MODE) ? "SRDENT" : "DEEP_SLEEP";
+ drmModeConnector *c;
+ const char *state;
int ret;
+ if (mode == PR_MODE || mode == PR_MODE_SEL_FETCH) {
+ igt_assert_f(output, "Output not given\n");
+ c = output->config.connector;
+ }
+
+ if ((mode == PR_MODE || mode == PR_MODE_SEL_FETCH) &&
+ c && c->connector_type == DRM_MODE_CONNECTOR_eDP)
+ state = "SLEEP";
+ else if (mode == PSR_MODE_1 || mode == PR_MODE || mode == PR_MODE_SEL_FETCH)
+ state = "SRDENT";
+ else if (mode == PSR_MODE_2 || mode == PSR_MODE_2_SEL_FETCH)
+ state = "DEEP_SLEEP";
+ else
+ igt_assert_f(false, "Invalid psr mode\n");
+
SET_DEBUGFS_PATH(output, debugfs_file);
ret = igt_debugfs_simple_read(debugfs_fd, debugfs_file,
buf, sizeof(buf));
--
2.34.1
next prev parent reply other threads:[~2024-06-13 9:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-13 9:25 [PATCH i-g-t v2 0/6] Panel Replay eDP changes Jouni Högander
2024-06-13 9:25 ` [PATCH i-g-t v2 1/6] lib/igt_psr: Set Panel Replay disable bit for PSR modes Jouni Högander
2024-06-13 9:25 ` [PATCH i-g-t v2 2/6] lib/igt_psr: Psr status debugfs interface print "enabled" not "Enabled" Jouni Högander
2024-06-13 9:25 ` Jouni Högander [this message]
2024-06-13 9:25 ` [PATCH i-g-t v2 4/6] tests/intel/kms_psr_stress_test: Provide output to psr_wait_entry Jouni Högander
2024-06-13 9:25 ` [PATCH i-g-t v2 5/6] tests/kms_psr2_sf: Use stored psr mode instead of PSR_MODE_2_SEL_FETCH Jouni Högander
2024-06-13 9:25 ` [PATCH i-g-t v2 6/6] lib/igt_psr: Fix PR_MODE sink support check Jouni Högander
2024-06-13 12:58 ` ✓ Fi.CI.BAT: success for Panel Replay eDP changes (rev2) Patchwork
2024-06-13 13:10 ` ✓ CI.xeBAT: " Patchwork
2024-06-13 16:19 ` ✗ CI.xeFULL: failure " Patchwork
2024-06-14 17:08 ` ✗ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240613092514.1288801-4-jouni.hogander@intel.com \
--to=jouni.hogander@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=kunal1.joshi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox