From: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: Bhanuprakash Modem <bhanuprakash.modem@intel.com>,
Jeevan B <jeevan.b@intel.com>
Subject: [i-g-t V6 1/6] lib/igt_kms: Check validity of the selcted pipe/output combo
Date: Tue, 18 Jun 2024 11:51:45 +0530 [thread overview]
Message-ID: <20240618062150.4004768-2-bhanuprakash.modem@intel.com> (raw)
In-Reply-To: <20240618062150.4004768-1-bhanuprakash.modem@intel.com>
Add a check to identify the selcted pipe/output combination is
valid or not.
Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
Reviewed-by: Jeevan B <jeevan.b@intel.com>
---
lib/igt_kms.c | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/lib/igt_kms.c b/lib/igt_kms.c
index af63d13b1..2e6f44e3c 100644
--- a/lib/igt_kms.c
+++ b/lib/igt_kms.c
@@ -6480,18 +6480,21 @@ bool intel_pipe_output_combo_valid(igt_display_t *display)
int combo = 0;
igt_output_t *output;
- if (!is_intel_device(display->drm_fd))
- return true;
-
for_each_connected_output(display, output) {
if (output->pending_pipe == PIPE_NONE)
continue;
+ if (!igt_pipe_connector_valid(output->pending_pipe, output))
+ return false;
+
combo++;
}
igt_assert_f(combo, "At least one pipe/output combo needed.\n");
+ if (!is_intel_device(display->drm_fd))
+ return true;
+
/*
* Check the given pipe/output combo is valid for Bigjoiner.
*
--
2.43.2
next prev parent reply other threads:[~2024-06-18 6:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-18 6:21 [i-g-t V6 0/6] Force joiner support in bigjoiner checks Bhanuprakash Modem
2024-06-18 6:21 ` Bhanuprakash Modem [this message]
2024-06-18 6:21 ` [i-g-t V6 2/6] tests/kms: Drop redundant check for pipe/output combo validity Bhanuprakash Modem
2024-06-18 6:21 ` [i-g-t V6 3/6] tests/chamelium: Use lib helper to check the " Bhanuprakash Modem
2024-06-18 6:21 ` [i-g-t V6 4/6] tests/intel/kms: " Bhanuprakash Modem
2024-06-18 6:21 ` [i-g-t V6 5/6] tests/kms_dither: " Bhanuprakash Modem
2024-06-18 6:21 ` [i-g-t V6 6/6] tests/kms_hdr: " Bhanuprakash Modem
-- strict thread matches above, loose matches on Subject: below --
2024-06-18 6:23 [i-g-t V6 0/6] Check the validity of selected pipe/output combo Bhanuprakash Modem
2024-06-18 6:24 ` [i-g-t V6 1/6] lib/igt_kms: Check validity of the selcted " Bhanuprakash Modem
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240618062150.4004768-2-bhanuprakash.modem@intel.com \
--to=bhanuprakash.modem@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=jeevan.b@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox