From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9AB52C2BB9A for ; Tue, 18 Jun 2024 06:29:53 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id EC52410E57D; Tue, 18 Jun 2024 06:29:52 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="UCOs88k2"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.11]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7DEF110E57D for ; Tue, 18 Jun 2024 06:29:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1718692192; x=1750228192; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=RcPZpnveJGeMEH8FAZM5oyWPUEl2zCwm8j8hr00gni8=; b=UCOs88k2qegDYUMshrIjy4NiLgArezynSXGl8ai80/8PsMK8M9aDBc9z U80DNNFX0/uAist0g/oo5lJ30X+z4NodRhRBb/iisk+5nO3DEk5acNPGj G1l6IW1GvWZLDlX9AHoP0Q9GRa9nt15NW5rnvr6CCUkbacXyOBMV5yzjz oX0bx8ghmjY4Uh/CYJJZcJ+jSkgc10/dATPmbdR+krkTT1rH+HwzBWFJa 851Fyi57pB3K5dJB7uJLNf4jfxr6IF+xG/io13/6Vikzb0vrDeta0EBMB JPoGUFscEAo8Iq4j54mKX/jKYAfjbeMAShobUar/HPd8t9uVsyZfvVsT1 A==; X-CSE-ConnectionGUID: Yb5VLldNTtK8zkk9a1euwQ== X-CSE-MsgGUID: js3Zor5qS06o9D1gI4+OUw== X-IronPort-AV: E=McAfee;i="6700,10204,11106"; a="26177403" X-IronPort-AV: E=Sophos;i="6.08,247,1712646000"; d="scan'208";a="26177403" Received: from orviesa010.jf.intel.com ([10.64.159.150]) by fmvoesa105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Jun 2024 23:29:51 -0700 X-CSE-ConnectionGUID: dQ6cJCLkQF2gPxm0cLDzxw== X-CSE-MsgGUID: hB/aLlYWTxGhnZIPtLkmYw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,247,1712646000"; d="scan'208";a="41360318" Received: from bhanu-nuclab.iind.intel.com ([10.145.169.172]) by orviesa010-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Jun 2024 23:29:51 -0700 From: Bhanuprakash Modem To: igt-dev@lists.freedesktop.org Cc: Bhanuprakash Modem , Jeevan B Subject: [i-g-t V6 2/6] tests/kms: Drop redundant check for pipe/output combo validity Date: Tue, 18 Jun 2024 11:51:46 +0530 Message-ID: <20240618062150.4004768-3-bhanuprakash.modem@intel.com> X-Mailer: git-send-email 2.43.2 In-Reply-To: <20240618062150.4004768-1-bhanuprakash.modem@intel.com> References: <20240618062150.4004768-1-bhanuprakash.modem@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: igt-dev@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development mailing list for IGT GPU Tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" As intel_pipe_output_combo_valid() is taking care of pipe/output combo validity, drop other redundant checks. Signed-off-by: Bhanuprakash Modem Reviewed-by: Jeevan B --- tests/kms_content_protection.c | 3 --- tests/kms_properties.c | 3 --- tests/kms_vrr.c | 22 ++++++++++------------ 3 files changed, 10 insertions(+), 18 deletions(-) diff --git a/tests/kms_content_protection.c b/tests/kms_content_protection.c index 6858b22e2..e9a468eb0 100644 --- a/tests/kms_content_protection.c +++ b/tests/kms_content_protection.c @@ -564,9 +564,6 @@ test_content_protection(enum igt_commit_style s, int content_type) for_each_connected_output(display, output) { for_each_pipe(display, pipe) { - if (!igt_pipe_connector_valid(pipe, output)) - continue; - igt_display_reset(display); igt_output_set_pipe(output, pipe); diff --git a/tests/kms_properties.c b/tests/kms_properties.c index bd414f534..6f92b218e 100644 --- a/tests/kms_properties.c +++ b/tests/kms_properties.c @@ -337,9 +337,6 @@ static void connector_properties(igt_display_t *display, bool atomic) bool found = false; for_each_pipe(display, pipe) { - if (!igt_pipe_connector_valid(pipe, output)) - continue; - igt_display_reset(display); igt_output_set_pipe(output, pipe); diff --git a/tests/kms_vrr.c b/tests/kms_vrr.c index 7f64d6806..5af220b5b 100644 --- a/tests/kms_vrr.c +++ b/tests/kms_vrr.c @@ -794,22 +794,20 @@ run_vrr_test(data_t *data, test_t test, uint32_t flags) continue; for_each_pipe(&data->display, pipe) { - if (igt_pipe_connector_valid(pipe, output)) { - igt_output_set_pipe(output, pipe); + igt_output_set_pipe(output, pipe); - if (!intel_pipe_output_combo_valid(&data->display)) { - igt_output_set_pipe(output, PIPE_NONE); - continue; - } + if (!intel_pipe_output_combo_valid(&data->display)) { + igt_output_set_pipe(output, PIPE_NONE); + continue; + } - igt_dynamic_f("pipe-%s-%s", - kmstest_pipe_name(pipe), output->name) - test(data, pipe, output, flags); + igt_dynamic_f("pipe-%s-%s", + kmstest_pipe_name(pipe), output->name) + test(data, pipe, output, flags); - test_cleanup(data, pipe, output); + test_cleanup(data, pipe, output); - break; - } + break; } } } -- 2.43.2