From: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: Bhanuprakash Modem <bhanuprakash.modem@intel.com>,
Jeevan B <jeevan.b@intel.com>
Subject: [i-g-t V6 6/6] tests/kms_hdr: Use lib helper to check the pipe/output combo validity
Date: Tue, 18 Jun 2024 11:54:05 +0530 [thread overview]
Message-ID: <20240618062405.4004955-7-bhanuprakash.modem@intel.com> (raw)
In-Reply-To: <20240618062405.4004955-1-bhanuprakash.modem@intel.com>
Use IGT lib helper intel_pipe_output_combo_valid() to make sure the
selected pipe/output/mode combo is valid.
Cc: Jeevan B <jeevan.b@intel.com>
Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
tests/kms_hdr.c | 90 ++++++++++++++++++++++++++++---------------------
1 file changed, 51 insertions(+), 39 deletions(-)
diff --git a/tests/kms_hdr.c b/tests/kms_hdr.c
index 99b78f7ef..475463c21 100644
--- a/tests/kms_hdr.c
+++ b/tests/kms_hdr.c
@@ -261,6 +261,8 @@ static void test_bpc_switch(data_t *data, uint32_t flags)
igt_display_t *display = &data->display;
igt_output_t *output;
+ igt_display_reset(display);
+
for_each_connected_output(display, output) {
enum pipe pipe;
@@ -271,26 +273,30 @@ static void test_bpc_switch(data_t *data, uint32_t flags)
continue;
for_each_pipe(display, pipe) {
- if (igt_pipe_connector_valid(pipe, output)) {
- prepare_test(data, output, pipe);
-
- if (is_intel_device(data->fd) &&
- !igt_max_bpc_constraint(display, pipe, output, 10)) {
- test_fini(data);
- break;
- }
-
- data->mode = igt_output_get_mode(output);
- data->w = data->mode->hdisplay;
- data->h = data->mode->vdisplay;
+ igt_output_set_pipe(output, pipe);
+ if (intel_pipe_output_combo_valid(display)) {
+ igt_output_set_pipe(output, PIPE_NONE);
+ continue;
+ }
- igt_dynamic_f("pipe-%s-%s",
- kmstest_pipe_name(pipe), output->name)
- test_bpc_switch_on_output(data, pipe, output, flags);
+ prepare_test(data, output, pipe);
- /* One pipe is enough */
+ if (is_intel_device(data->fd) &&
+ !igt_max_bpc_constraint(display, pipe, output, 10)) {
+ test_fini(data);
break;
}
+
+ data->mode = igt_output_get_mode(output);
+ data->w = data->mode->hdisplay;
+ data->h = data->mode->vdisplay;
+
+ igt_dynamic_f("pipe-%s-%s",
+ kmstest_pipe_name(pipe), output->name)
+ test_bpc_switch_on_output(data, pipe, output, flags);
+
+ /* One pipe is enough */
+ break;
}
}
}
@@ -614,6 +620,8 @@ static void test_hdr(data_t *data, uint32_t flags)
igt_display_t *display = &data->display;
igt_output_t *output;
+ igt_display_reset(display);
+
for_each_connected_output(display, output) {
enum pipe pipe;
@@ -635,32 +643,36 @@ static void test_hdr(data_t *data, uint32_t flags)
continue;
for_each_pipe(display, pipe) {
- if (igt_pipe_connector_valid(pipe, output)) {
- prepare_test(data, output, pipe);
+ igt_output_set_pipe(output, pipe);
+ if (!intel_pipe_output_combo_valid(display)) {
+ igt_output_set_pipe(output, PIPE_NONE);
+ continue;
+ }
- if (is_intel_device(data->fd) &&
- !igt_max_bpc_constraint(display, pipe, output, 10)) {
- test_fini(data);
- break;
- }
-
- data->mode = igt_output_get_mode(output);
- data->w = data->mode->hdisplay;
- data->h = data->mode->vdisplay;
-
- igt_dynamic_f("pipe-%s-%s",
- kmstest_pipe_name(pipe), output->name) {
- if (flags & (TEST_NONE | TEST_DPMS | TEST_SUSPEND | TEST_INVALID_HDR))
- test_static_toggle(data, pipe, output, flags);
- if (flags & TEST_SWAP)
- test_static_swap(data, pipe, output);
- if (flags & TEST_INVALID_METADATA_SIZES)
- test_invalid_metadata_sizes(data, output);
- }
-
- /* One pipe is enough */
+ prepare_test(data, output, pipe);
+
+ if (is_intel_device(data->fd) &&
+ !igt_max_bpc_constraint(display, pipe, output, 10)) {
+ test_fini(data);
break;
}
+
+ data->mode = igt_output_get_mode(output);
+ data->w = data->mode->hdisplay;
+ data->h = data->mode->vdisplay;
+
+ igt_dynamic_f("pipe-%s-%s",
+ kmstest_pipe_name(pipe), output->name) {
+ if (flags & (TEST_NONE | TEST_DPMS | TEST_SUSPEND | TEST_INVALID_HDR))
+ test_static_toggle(data, pipe, output, flags);
+ if (flags & TEST_SWAP)
+ test_static_swap(data, pipe, output);
+ if (flags & TEST_INVALID_METADATA_SIZES)
+ test_invalid_metadata_sizes(data, output);
+ }
+
+ /* One pipe is enough */
+ break;
}
}
}
--
2.43.2
next prev parent reply other threads:[~2024-06-18 6:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-18 6:23 [i-g-t V6 0/6] Check the validity of selected pipe/output combo Bhanuprakash Modem
2024-06-18 6:24 ` [i-g-t V6 1/6] lib/igt_kms: Check validity of the selcted " Bhanuprakash Modem
2024-06-18 6:24 ` [i-g-t V6 2/6] tests/kms: Drop redundant check for pipe/output combo validity Bhanuprakash Modem
2024-06-18 6:24 ` [i-g-t V6 3/6] tests/chamelium: Use lib helper to check the " Bhanuprakash Modem
2024-06-18 6:24 ` [i-g-t V6 4/6] tests/intel/kms: " Bhanuprakash Modem
2024-06-18 6:24 ` [i-g-t V6 5/6] tests/kms_dither: " Bhanuprakash Modem
2024-06-18 8:45 ` B, Jeevan
2024-06-18 6:24 ` Bhanuprakash Modem [this message]
2024-06-18 8:46 ` [i-g-t V6 6/6] tests/kms_hdr: " B, Jeevan
-- strict thread matches above, loose matches on Subject: below --
2024-06-18 6:21 [i-g-t V6 0/6] Force joiner support in bigjoiner checks Bhanuprakash Modem
2024-06-18 6:21 ` [i-g-t V6 6/6] tests/kms_hdr: Use lib helper to check the pipe/output combo validity Bhanuprakash Modem
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240618062405.4004955-7-bhanuprakash.modem@intel.com \
--to=bhanuprakash.modem@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=jeevan.b@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox