From: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
To: igt-dev@lists.freedesktop.org, jeevan.b@intel.com
Cc: Bhanuprakash Modem <bhanuprakash.modem@intel.com>,
Kunal Joshi <kunal1.joshi@intel.com>
Subject: [i-g-t V6 4/8] lib/igt_kms: Force joiner support in bigjoiner checks
Date: Tue, 18 Jun 2024 13:52:44 +0530 [thread overview]
Message-ID: <20240618082248.4070611-5-bhanuprakash.modem@intel.com> (raw)
In-Reply-To: <20240618082248.4070611-1-bhanuprakash.modem@intel.com>
As we recently introduced the option (through debugfs) to
force the bigjoiner, needs to extend the support in bigjoiner
checks to handle the force joiner.
Cc: Kunal Joshi <kunal1.joshi@intel.com>
Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
lib/igt_kms.c | 19 +++++++++++--------
1 file changed, 11 insertions(+), 8 deletions(-)
diff --git a/lib/igt_kms.c b/lib/igt_kms.c
index 9fdfadde1..d565e79ce 100644
--- a/lib/igt_kms.c
+++ b/lib/igt_kms.c
@@ -6415,6 +6415,7 @@ bool igt_check_bigjoiner_support(igt_display_t *display)
enum pipe idx;
drmModeModeInfo *mode;
igt_output_t *output;
+ bool force_joiner;
} pipes[IGT_MAX_PIPES];
int max_dotclock;
@@ -6433,6 +6434,7 @@ bool igt_check_bigjoiner_support(igt_display_t *display)
pipes[pipes_in_use].idx = output->pending_pipe;
pipes[pipes_in_use].mode = igt_output_get_mode(output);
pipes[pipes_in_use].output = output;
+ pipes[pipes_in_use].force_joiner = igt_check_force_joiner_status(display->drm_fd, output->name);
pipes_in_use++;
}
@@ -6444,21 +6446,22 @@ bool igt_check_bigjoiner_support(igt_display_t *display)
max_dotclock = igt_get_max_dotclock(display->drm_fd);
/*
- * if mode resolution > 5K (or) mode.clock > max dot-clock, then ignore
+ * if force joiner (or) mode resolution > 5K (or) mode.clock > max dot-clock,
+ * then ignore
* - if the consecutive pipe is not available
* - last crtc in single/multi-connector config
* - consecutive crtcs in multi-connector config
*
* in multi-connector config ignore if
- * - previous crtc (mode resolution > 5K or mode.clock > max dot-clock) and
+ * - previous crtc (force joiner or mode resolution > 5K or mode.clock > max dot-clock) and
* - current & previous crtcs are consecutive
*/
for (i = 0; i < pipes_in_use; i++) {
- if (igt_bigjoiner_possible(pipes[i].mode, max_dotclock)) {
- igt_info("pipe-%s-%s: (Max dot-clock: %d KHz)",
+ if (pipes[i].force_joiner || igt_bigjoiner_possible(pipes[i].mode, max_dotclock)) {
+ igt_info("pipe-%s-%s: (Max dot-clock: %d KHz), force joiner: %s\n",
kmstest_pipe_name(pipes[i].idx),
igt_output_name(pipes[i].output),
- max_dotclock);
+ max_dotclock, pipes[i].force_joiner ? "Yes" : "No");
kmstest_dump_mode(pipes[i].mode);
if (pipes[i].idx >= (total_pipes - 1)) {
@@ -6481,11 +6484,11 @@ bool igt_check_bigjoiner_support(igt_display_t *display)
}
}
- if ((i > 0) && igt_bigjoiner_possible(pipes[i - 1].mode, max_dotclock)) {
- igt_info("pipe-%s-%s: (Max dot-clock: %d KHz)",
+ if ((i > 0) && (pipes[i - 1].force_joiner || igt_bigjoiner_possible(pipes[i - 1].mode, max_dotclock))) {
+ igt_info("pipe-%s-%s: (Max dot-clock: %d KHz), force joiner: %s\n",
kmstest_pipe_name(pipes[i - 1].idx),
igt_output_name(pipes[i - 1].output),
- max_dotclock);
+ max_dotclock, pipes[i - 1].force_joiner ? "Yes" : "No");
kmstest_dump_mode(pipes[i - 1].mode);
if (!display->pipes[pipes[i - 1].idx + 1].enabled) {
--
2.43.2
next prev parent reply other threads:[~2024-06-18 8:31 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-18 8:22 [i-g-t V6 0/8] Force joiner support in bigjoiner checks Bhanuprakash Modem
2024-06-18 8:22 ` [i-g-t V6 1/8] lib/igt_kms: Split the bigjoiner check into multiple Bhanuprakash Modem
2024-06-24 18:15 ` B, Jeevan
2024-06-18 8:22 ` [i-g-t V6 2/8] lib/igt_kms: Update force joiner debugfs check Bhanuprakash Modem
2024-06-18 8:22 ` [i-g-t V6 3/8] lib/igt_kms: New helper to check force joiner status Bhanuprakash Modem
2024-06-27 6:50 ` B, Jeevan
2024-06-18 8:22 ` Bhanuprakash Modem [this message]
2024-06-27 6:54 ` [i-g-t V6 4/8] lib/igt_kms: Force joiner support in bigjoiner checks B, Jeevan
2024-06-18 8:22 ` [i-g-t V6 5/8] tests/intel/kms_pm_lpsp: " Bhanuprakash Modem
2024-06-27 6:58 ` B, Jeevan
2024-06-18 8:22 ` [i-g-t V6 6/8] tests/kms_flip: " Bhanuprakash Modem
2024-06-27 7:04 ` B, Jeevan
2024-06-27 7:20 ` Modem, Bhanuprakash
2024-06-27 8:28 ` B, Jeevan
2024-06-18 8:22 ` [i-g-t V6 7/8] tests/kms_setmode: " Bhanuprakash Modem
2024-06-27 7:05 ` B, Jeevan
2024-06-27 8:29 ` B, Jeevan
2024-06-18 8:22 ` [i-g-t V6 8/8] HAX: Test force joiner on BAT Bhanuprakash Modem
2024-06-18 13:54 ` ✓ CI.xeBAT: success for Force joiner support in bigjoiner checks (rev8) Patchwork
2024-06-18 13:58 ` ✓ Fi.CI.BAT: " Patchwork
2024-06-18 21:35 ` ✗ Fi.CI.IGT: failure " Patchwork
2024-06-19 2:24 ` ✗ CI.xeFULL: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240618082248.4070611-5-bhanuprakash.modem@intel.com \
--to=bhanuprakash.modem@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=jeevan.b@intel.com \
--cc=kunal1.joshi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox