Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Badal Nilawar <badal.nilawar@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: vinay.belgaumkar@intel.com, kamil.konieczny@linux.intel.com,
	riana.tauro@intel.com
Subject: [PATCH i-g-t] test/intel/xe_gt_freq: Remove act freq check from freq_low_max test
Date: Thu, 20 Jun 2024 18:24:37 +0530	[thread overview]
Message-ID: <20240620125437.181215-1-badal.nilawar@intel.com> (raw)

First we check gt idle status and then check act freq. However, it’s
important to note that there may be a race condition where the gt
transitions to c6 before we complete the act freq check.

Closes: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/1045
Fixes: 1a1e668e774e ("tests/intel/xe_gt_freq: Fix freq_low_max test")
Cc: Vinay Belgaumkar <vinay.belgaumkar@intel.com>
Signed-off-by: Badal Nilawar <badal.nilawar@intel.com>
---
 tests/intel/xe_gt_freq.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/tests/intel/xe_gt_freq.c b/tests/intel/xe_gt_freq.c
index d2e4d1a09..b3562181d 100644
--- a/tests/intel/xe_gt_freq.c
+++ b/tests/intel/xe_gt_freq.c
@@ -277,9 +277,6 @@ static void test_freq_low_max(int fd, int gt_id)
 	rpe = get_freq(fd, gt_id, "rpe");
 
 	igt_assert(get_freq(fd, gt_id, "cur") == rpe);
-
-	if (!xe_is_gt_in_c6(fd, gt_id))
-		igt_assert(get_freq(fd, gt_id, "act") == rpe);
 }
 
 /**
-- 
2.34.1


             reply	other threads:[~2024-06-20 12:37 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-20 12:54 Badal Nilawar [this message]
2024-06-20 15:24 ` ✗ CI.xeBAT: failure for test/intel/xe_gt_freq: Remove act freq check from freq_low_max test Patchwork
2024-06-26 14:17   ` Nilawar, Badal
2024-06-26 15:45     ` Gupta, Anshuman
2024-06-20 15:28 ` ✓ Fi.CI.BAT: success " Patchwork
2024-06-20 16:04 ` [PATCH i-g-t] " Belgaumkar, Vinay
2024-06-20 16:22 ` Riana Tauro
2024-06-20 17:03 ` ✗ CI.xeFULL: failure for " Patchwork
2024-06-20 21:44 ` ✗ Fi.CI.IGT: " Patchwork
2024-06-22 13:57 ` ✓ Fi.CI.IGT: success " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240620125437.181215-1-badal.nilawar@intel.com \
    --to=badal.nilawar@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=kamil.konieczny@linux.intel.com \
    --cc=riana.tauro@intel.com \
    --cc=vinay.belgaumkar@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox